Re: Process of adding a package

[Ricardo Wurmus <rekado@elephly.net>]

Hi Zelphir,

> I submitted the patch via e-mail attachment. It was recently 
> said on the mailing
> list, that it should not matter, or even be more reliable, when 
> submitting it as
> an attachment. However, as I see mostly patches being submitted 
> in the e-mail
> body, perhaps something automated does not work correctly with 
> patches submitted
> as attachment?

No, it all worked fine.  It’s just that the people who could have 
applied your patch did not.  Part of the reason is that one of 
them (me!) is no longer subscribed to the guix-patches list, 
another part is that people are busy preparing the upcoming 
release.

So I guess it just fell through the cracks.  You are welcome to 
ping people.  If you’re on the #guix IRC channel you can also ask 
for review there.

> I thought I had written the patch commit message answering all 
> questions on
> https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs
> <https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs>.
> However, perhaps I should have checked the linked pages there, 
> especially
> https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs
> <https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs>?
> Or is it something else, that can be done in a better way about 
> the commit message?

There is a standard format, yes.

We have tools to generate a commit message in the correct format, 
such as “etc/committer.scm” or the “add” yasnippet when using 
Magit.

-- 
Ricardo