Re: Process of adding a package

[Zelphir Kaltstahl <zelphirkaltstahl@posteo.de>]

Hi Ricardo!

Thank you for your quick reply!

I submitted the patch via e-mail attachment. It was recently said on the mailing
list, that it should not matter, or even be more reliable, when submitting it as
an attachment. However, as I see mostly patches being submitted in the e-mail
body, perhaps something automated does not work correctly with patches submitted
as attachment? Wildly guessing around here : )

Anyway, thank you for looking at the patch.

I thought I had written the patch commit message answering all questions on
https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs
<https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs>.
However, perhaps I should have checked the linked pages there, especially
https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs
<https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs>?
Or is it something else, that can be done in a better way about the commit message?

Best regards,
Zelphir

On 5/10/21 12:08 PM, Ricardo Wurmus wrote:
>
> Hi,
>
>> What is the usual process, after one has sent in a patch adding a new package to
>> GNU Guix?
>
> Someone would review it, apply the patch, and then push.
>
>> The background of the question is, that approximately 2 months ago, I sent in a
>> patch adding `guile-fslib`
>
> 2 months is too long.  If you don’t hear from us after a week your patch
> likely fell through the cracks and nobody realized it.  You can ping us.
>
> I wasn’t aware of your patch, but I found it here:
>
>    https://issues.guix.gnu.org/47697
>
> The commit message isn’t according to our standards, but that’s easy to fix. 
> The patch itself looks fine, so I’m going to apply it in a moment.  Sorry
> about taking so long!
>
-- 
repositories: https://notabug.org/ZelphirKaltstahl