Beginner trying to package org-noter-plus

Beginner trying to package org-noter-plus

[Samuel Schmidt]

Hello,

I am trying to package org-noter-plus (https://github.com/dmitrym0/org-noter-plus). 
I have no prior experience with packaging software and appreciate any help :)

There are two problems:
1. In the file emacs-devel.el (https://github.com/dmitrym0/org-noter-plus/blob/master/emacs-devel.el) of org-noter-plus, a path for cask is specified ((require 'cask "/opt/homebrew/share/emacs/site-lisp/cask/cask.el")). This resulted in an error message, which I resolved by just deleting the file and disabling tests.
Is there are a better solution? 

2. After building and installing, the files located at "https://github.com/dmitrym0/org-noter-plus/tree/master/modules" are not installed at all.
I have no idea, how to solve this ...

Thanks in advance,

Samuel Schmidt

--- Here the .scm file --- 

(define-module (gnu packages my-guix-packages)
  #:use-module ((guix licenses) #:prefix license:)
  #:use-module (guix packages)
  #:use-module (guix git-download)
  #:use-module (guix build-system emacs)
  #:use-module (gnu packages emacs-xyz)
  )

(define-public emacs-org-noter-plus
  (let ((commit "f4c318b1bea6a14a20bf82269dc2614dbf15a1cb")
        (revision "1"))
  (package
    (name "emacs-org-noter-plus")
    (version (git-version "1.4.1" revision commit))
    (source
     (origin
       (method git-fetch)
       (uri (git-reference
              (url "https://github.com/dmitrym0/org-noter-plus")
              (commit commit)))
       (file-name (git-file-name name version))
       (sha256
        (base32
         "0lhx8nypzihwasj63qbjbj0dk18bdr8ms1q5aakc5mn6s65jc2n5"))))
    (build-system emacs-build-system)
    (arguments
     '(#:tests? #f
       #:phases
       (modify-phases %standard-phases
         (add-after 'unpack 'remove-emacs-dev
           (lambda _
             ;; Remove emacs-dev.el to avoid requiring cask
             (delete-file "emacs-devel.el"))))))
    (propagated-inputs
     (list emacs-org
           emacs-pdf-tools
           emacs-log4e))
    (home-page "https://github.com/dmitrym0/org-noter-plus")
    (synopsis "Updated, synchronized, Org-mode, document annotator")
    (description
     "This is an updated version of org-note. Refer to the home page for more details. In general, this package lets you create notes that are kept in sync when you
scroll through the document, but that are external to it---the notes
themselves live in an Org-mode file.  As such, this leverages the power of
Org-mode (the notes may have outlines, latex fragments, babel, etc...) while
acting like notes that are made @emph{in} the document.")
    (license license:gpl3+))))

emacs-org-noter-plus

--- End ---

Re: Beginner trying to package org-noter-plus

[Simon Tournier]

Hi,

On Tue, 28 Feb 2023 at 11:05, Samuel Schmidt <samuel@schmidt-contact.com> wrote:

> There are two problems:
> 1. In the file emacs-devel.el
> (https://github.com/dmitrym0/org-noter-plus/blob/master/emacs-devel.el)
> of org-noter-plus, a path for cask is specified ((require 'cask
> "/opt/homebrew/share/emacs/site-lisp/cask/cask.el")). This resulted in
> an error message, which I resolved by just deleting the file and
> disabling tests. 
> Is there are a better solution?

Well, maybe do the removal in a snippet instead of a phase.

https://guix.gnu.org/manual/devel/en/guix.html#Snippets-versus-Phases

It depends on if your intent is that “guix build -S
emacs-org-noter-plus” would be usable the upstream development way.

> 2. After building and installing, the files located at
> "https://github.com/dmitrym0/org-noter-plus/tree/master/modules" are
> not installed at all.
> I have no idea, how to solve this ...

That’s because they are in EMACSLOADPATH, I guess.

Well, two solutions: either extend it, either move the Emacs Lisp from
modules/ to the root visible by EMACSLOADPATH.  Give a look to
gnu/packages/emacs-xyz.scm for examples [1]. :-)

1:
https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/emacs-xyz.scm

Cheers,
simon