From: c4droid <c4droid@foxmail.com>
To: Bruno Victal <mirai@makinata.eu>
Cc: 62324@debbugs.gnu.org
Subject: [bug#62324] gnu: Add emu8051
Date: Wed, 22 Mar 2023 08:53:41 +0800 [thread overview]
Message-ID: <tencent_88A81461B1E20F335E3B2061AF50D0CB380A@qq.com> (raw)
Message-ID: <87ttydbo5c.fsf@foxmail.com> (raw)
In-Reply-To: <6ad8a739-992c-e578-ea8f-76e762f70c42@makinata.eu>
Hi, Bruno
Bruno Victal <mirai@makinata.eu> writes:
> Hi,
>
> On 2023-03-21 07:20, c4droid wrote:
>>
>> + (arguments
>> + `(#:tests? #f ;No test suite
>> + #:make-flags (list (string-append "CC="
>> + ,(cc-for-target)))
>> + #:phases (modify-phases %standard-phases
>> + (delete 'configure) ;No ./configure script
>> + (add-before 'build 'patch-ncurses
>> + ;; Replace LDFLAGS -lcurses to -lncurses
>> + (lambda* _
>> + (substitute* "Makefile"
>> + (("-lcurses")
>> + "-lncurses"))))
>
> How about turning this 'patch-ncurses phase into a patch snippet instead? i.e.
>
I'll change it later, thanks for the hints.
> (source
> (origin
> (method ...)
> ...
> (modules '((guix build utils)))
> (snippet
> #~(begin
> ;; Replace LDFLAGS -lcurses to -lncurses
> (substitute* "Makefile"
> (("-lcurses") "-lncurses"))))))
>
> [...]
>
>> + (replace 'install
>> + ;; No installation procedure
>> + (lambda _
>> + (install-file "emu"
>> + (string-append (assoc-ref %outputs "out")
>> + "/bin")))))))
>
> Use G-Expressions here, i.e.
>
> (arguments
> (list
> #:tests? #f ;No test suite
> #:make-flags #~(list ...)
> #:phases
> #~(modify-phases ...
> ...
> (replace 'install
> (lambda _
> (install-file "emu" (string-append #$output "/bin")))))))
>
>
> Cheers,
> Bruno
next prev parent reply other threads:[~2023-03-22 0:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 7:20 [bug#62324] gnu: Add emu8051 c4droid
2023-03-21 13:43 ` Bruno Victal
[not found] ` <87ttydbo5c.fsf@foxmail.com>
2023-03-22 0:53 ` c4droid [this message]
[not found] ` <87h6udo8ml.fsf@foxmail.com>
2023-03-22 1:48 ` c4droid
2023-03-21 14:47 ` Simon South
[not found] ` <87pm91bo2u.fsf@foxmail.com>
2023-03-22 0:56 ` c4droid
[not found] ` <87cz51o841.fsf@foxmail.com>
2023-03-22 1:58 ` [bug#62324] [PATCH 0/1] gnu: emu8051: Using snippet to replace patch-ncurses phases c4droid
2023-03-22 2:13 ` Bruno Victal
[not found] ` <87pm91dyam.fsf@foxmail.com>
2023-03-22 7:43 ` [bug#62324] [PATCH 1/1] gnu: emu8051: Fix build error for quasiquote c4droid
2023-03-30 12:48 ` [bug#62324] gnu: Add emu8051 宋文武 via Guix-patches via
[not found] ` <87fs9l2z6g.fsf@foxmail.com>
2023-03-31 6:48 ` [bug#62324] [PATCH] " c4droid
2023-03-31 11:33 ` bug#62324: " 宋文武 via Guix-patches via
2023-03-31 11:22 ` [bug#62324] [PATCH v2] " iyzsong--- via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_88A81461B1E20F335E3B2061AF50D0CB380A@qq.com \
--to=c4droid@foxmail.com \
--cc=62324@debbugs.gnu.org \
--cc=mirai@makinata.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).