From: Z572 <873216071@qq.com>
To: 47776@debbugs.gnu.org
Subject: [bug#47776] [PATCH] import: go: Fix goproxy option argument's format.
Date: Wed, 14 Apr 2021 23:00:20 +0800 [thread overview]
Message-ID: <tencent_6F94BF96A0D4FE6EDAA41A6541FE55EB380A@qq.com> (raw)
Message-ID: <878s5k9aij.fsf@qq.com> (raw)
[-- Attachment #1: 0001-import-go-Fix-goproxy-option-argument-s-format.patch --]
[-- Type: text/x-patch, Size: 1756 bytes --]
From e34f281d39f9b1e247fa649a15657da70f2b548d Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071@qq.com>
Date: Wed, 14 Apr 2021 22:37:50 +0800
Subject: [PATCH] import: go: Fix goproxy option argument's format.
Commit a8b927a562 Added new procedure go-module-available-versions use
'string-append' to GOPROXY, but 'string->symbol' let GOPROXY is a symbol (it
must be a string), which would lead to wrong-type-arg errors in the
'string-append' procedure.
* guix/scripts/import/go.scm (%options)[goproxy]: Remove call to
'string->symbol'.
---
guix/scripts/import/go.scm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/guix/scripts/import/go.scm b/guix/scripts/import/go.scm
index 04b07f80cc..74e8e60cce 100644
--- a/guix/scripts/import/go.scm
+++ b/guix/scripts/import/go.scm
@@ -1,6 +1,7 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2020 Katherine Cox-Buday <cox.katherine.e@gmail.com>
;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2021 Zheng Junjie <873216071@qq.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -68,9 +69,7 @@ that are not yet in Guix"))
(alist-cons 'recursive #t result)))
(option '(#\p "goproxy") #t #f
(lambda (opt name arg result)
- (alist-cons 'goproxy
- (string->symbol arg)
- (alist-delete 'goproxy result))))
+ (alist-cons 'goproxy arg (alist-delete 'goproxy result))))
(option '("pin-versions") #f #f
(lambda (opt name arg result)
(alist-cons 'pin-versions? #t result)))
--
2.31.1
next reply other threads:[~2021-04-14 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <878s5k9aij.fsf@qq.com>
2021-04-14 15:00 ` Z572 [this message]
2021-05-14 10:41 ` bug#47776: [PATCH] import: go: Fix goproxy option argument's format Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_6F94BF96A0D4FE6EDAA41A6541FE55EB380A@qq.com \
--to=873216071@qq.com \
--cc=47776@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).