unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Rodriguez <yewscion@gmail.com>
To: Christine Lemmer-Webber <cwebber@dustycloud.org>
Cc: yewscion@gmail.com, 54529@debbugs.gnu.org
Subject: [bug#54529] Checking In
Date: Sun, 12 Jun 2022 14:35:00 -0400	[thread overview]
Message-ID: <pkmp4eo7yxg20g.fsf@crane.ant.amazon.com> (raw)
In-Reply-To: <87mtejf5hu.fsf@dustycloud.org>

[-- Attachment #1: Type: text/plain, Size: 1291 bytes --]


Christine Lemmer-Webber <cwebber@dustycloud.org> writes:

> Hello!  Checking in on this again.

Hi Christine!

> If you give an updated version of the patch, it can be merged I think.
> With the commented out part, I'm uncertain whether or not it was
> commented out because it's no longer needed or because it was but you
> were debugging, based on what you've said so that's the main concern I
> have.

I will rebase the patch on a new pull of guix from git, clean it up, and
send it here within the next hour or so. That way, I'll be sure that it
still works with all of the changes since then and now.

> Could you also use git format-patch for the next version you send?
> That'll make it easy to apply!

Between my last comment and now I've become used to the `git send-email`
style workflow. Is that what You are asking for? If not, let me know and
I will send a patch in the preferred format ASAP.

> Thanks!  Sorry for the delays on this review cycle!  It's busy here.

No worries! Frankly, looking at the number and depth of the commits that
GNU Guix gets on a daily basis, I'm very impressed with the speed with
which our maintainers work! Thank You all for Your efforts; they are
very appreciated!

>  - Christine

-- 

Christopher Rodriguez

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2022-06-12 18:40 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 22:46 [bug#54529] [PATCH] Added orca-lang package Christopher Rodriguez
2022-03-23  2:30 ` [bug#54529] [PATCH v2] " Christopher Rodriguez
2022-03-23  7:29   ` Maxime Devos
2022-03-23  7:29   ` Maxime Devos
2022-03-23  7:30   ` Maxime Devos
2022-03-23  7:30   ` Maxime Devos
2022-03-23  7:30   ` Maxime Devos
2022-03-23  7:32   ` Maxime Devos
2022-03-23  7:33   ` Maxime Devos
2022-03-23  7:33   ` Maxime Devos
2022-03-23  7:34   ` Maxime Devos
2022-03-23  7:35   ` Maxime Devos
2022-03-23  7:36   ` Maxime Devos
2022-03-23  7:36   ` Maxime Devos
2022-03-23  7:36   ` Maxime Devos
2022-03-23  7:38   ` Maxime Devos
2022-03-23  7:38   ` Maxime Devos
2022-03-23  7:40   ` Maxime Devos
2022-03-23 14:45 ` [bug#54529] [PATCH v3] " Christopher Rodriguez
2022-03-25 21:55   ` Christine Lemmer-Webber
2022-03-29 18:51 ` [bug#54529] [PATCH v4] " Christopher Rodriguez
2022-04-18 15:07 ` [bug#54529] Checking In Christopher Rodriguez
2022-04-21 15:59   ` Christine Lemmer-Webber
2022-04-22  1:20     ` Christopher Rodriguez
2022-06-11 17:55       ` Christine Lemmer-Webber
2022-06-12 18:35         ` Christopher Rodriguez [this message]
2022-06-13  2:38           ` Christine Lemmer-Webber
2022-06-13  2:48 ` [bug#54529] [PATCH v5] Added orca-music package Christopher Rodriguez
2022-06-26 19:43   ` Christine Lemmer-Webber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pkmp4eo7yxg20g.fsf@crane.ant.amazon.com \
    --to=yewscion@gmail.com \
    --cc=54529@debbugs.gnu.org \
    --cc=cwebber@dustycloud.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).