unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Rodriguez <yewscion@gmail.com>
To: Christine Lemmer-Webber <cwebber@dustycloud.org>
Cc: yewscion@gmail.com, 54529@debbugs.gnu.org
Subject: [bug#54529] Checking In
Date: Thu, 21 Apr 2022 21:20:37 -0400	[thread overview]
Message-ID: <pkmp4eilr1q54z.fsf@crane.ant.amazon.com> (raw)
In-Reply-To: <87k0bi4eac.fsf@dustycloud.org>

[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]


Christine Lemmer-Webber <cwebber@dustycloud.org> writes:

> Christopher Rodriguez <yewscion@gmail.com> writes:
>
>> [[PGP Signed Part:Undecided]]
>> Hello all,
>>
>> Just want to confirm if this is waiting on me for anything. Trying to stay on
>> top of the issues I'm opening, as I'm planning to open more soon and don't want
>> to pollute the queue with a bunch of forgotten issues.
>>
>> Is there anything else that needs done from my end concerning the above patch?
>>
>> Thanks for Your time!
>
> I've been overwhelmed with other things, but I did try the patch out and
> it did work great.  Then I got overwhelmed again.  ;P
>
> I think I made a suggestion about the moving the binary name after
> install bit.  Did you / could you give that a try?

Hi Christine!

I did give it a try, and it worked! I actually decided to do it after
the build step, before the install.

The above patch should have the updated version, though I do notice now
(upon reading through it again) that it includes a rather large section
I had commented out during debugging.

I'll remove that and send a revised patch tonight; With the package name issue
out of the way I believe this /should/ be ready to merge.

--

Christopher Rodriguez

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2022-04-22  1:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 22:46 [bug#54529] [PATCH] Added orca-lang package Christopher Rodriguez
2022-03-23  2:30 ` [bug#54529] [PATCH v2] " Christopher Rodriguez
2022-03-23  7:29   ` Maxime Devos
2022-03-23  7:29   ` Maxime Devos
2022-03-23  7:30   ` Maxime Devos
2022-03-23  7:30   ` Maxime Devos
2022-03-23  7:30   ` Maxime Devos
2022-03-23  7:32   ` Maxime Devos
2022-03-23  7:33   ` Maxime Devos
2022-03-23  7:33   ` Maxime Devos
2022-03-23  7:34   ` Maxime Devos
2022-03-23  7:35   ` Maxime Devos
2022-03-23  7:36   ` Maxime Devos
2022-03-23  7:36   ` Maxime Devos
2022-03-23  7:36   ` Maxime Devos
2022-03-23  7:38   ` Maxime Devos
2022-03-23  7:38   ` Maxime Devos
2022-03-23  7:40   ` Maxime Devos
2022-03-23 14:45 ` [bug#54529] [PATCH v3] " Christopher Rodriguez
2022-03-25 21:55   ` Christine Lemmer-Webber
2022-03-29 18:51 ` [bug#54529] [PATCH v4] " Christopher Rodriguez
2022-04-18 15:07 ` [bug#54529] Checking In Christopher Rodriguez
2022-04-21 15:59   ` Christine Lemmer-Webber
2022-04-22  1:20     ` Christopher Rodriguez [this message]
2022-06-11 17:55       ` Christine Lemmer-Webber
2022-06-12 18:35         ` Christopher Rodriguez
2022-06-13  2:38           ` Christine Lemmer-Webber
2022-06-13  2:48 ` [bug#54529] [PATCH v5] Added orca-music package Christopher Rodriguez
2022-06-26 19:43   ` Christine Lemmer-Webber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pkmp4eilr1q54z.fsf@crane.ant.amazon.com \
    --to=yewscion@gmail.com \
    --cc=54529@debbugs.gnu.org \
    --cc=cwebber@dustycloud.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).