From: jgart via Guix-patches via <guix-patches@gnu.org>
To: "Leo Prikler" <leo.prikler@student.tugraz.at>, 46699@debbugs.gnu.org
Cc: rg@raghavgururajan.name, LibreMiami <packaging-guix@libremiami.org>
Subject: [bug#46699] [PATCH 1/2] gnu: mumble: Update to 1.3.4.
Date: Sun, 07 Mar 2021 04:22:36 +0000 [thread overview]
Message-ID: <fe5dd646139573b0b2013c23e3ec89c8@dismail.de> (raw)
In-Reply-To: <65482f4bdf27e820e180928f8955f1e11c24efea.camel@student.tugraz.at>
Hi Leo,
It is fine to close this bug.
Thank you for taking the time to review these changes and for merging the other patch.
We'll keep CELT in mind going forward. Thank you for pointing that out.
all the best,
jgart
libremiami.org
March 6, 2021 12:38 PM, "Leo Prikler" <leo.prikler@student.tugraz.at> wrote:
> Am Samstag, den 06.03.2021, 17:35 +0100 schrieb Leo Prikler:
>
>> Am Samstag, den 06.03.2021, 16:22 +0000 schrieb jgart:
>> Hi Leo,
>>
>> These two patches change the logic in the snippet block from list
>> of
>> directories to delete to list of directories to keep as well as add
>> indentation to the mumble package. This is an addition to commit
>> ea13b3a14cb079e33b59cf60cdabf500ecc51cf1.
>>
>> best regards,
>>
>> jgart
>> Hi jgart,
>>
>> 0001 suffers from similar issues as your previous patch set. In
>> particular, it adds a spurious level of indentation in arguments!
>> 0002 LGTM, I'll push it after some testing. On that note, could
>> someone investigate why we keep ancient versions of CELT around? It
>> seems newer ones have been merged into opus.
>>
>> Regards,
>> Leo
>
> I've now pushed 0002. As far as keeping ancient CELT, it seems version
> 1.4.0 will at least drop 0.11, while keeping 0.7 for backwards
> compatibility.
>
> Do you want to keep this bug open for more indentation adjustments or
> is it fine to close?
>
> Regards,
> Leo
next prev parent reply other threads:[~2021-03-07 4:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 0:59 [bug#46699] [PATCH] gnu: mumble: Update to 1.3.4 jgart via Guix-patches via
2021-02-22 16:18 ` Leo Prikler
2021-02-22 19:09 ` jgart via Guix-patches via
2021-02-22 19:28 ` Leo Prikler
2021-03-06 16:22 ` [bug#46699] [PATCH 1/2] " jgart via Guix-patches via
2021-03-06 16:35 ` Leo Prikler
2021-03-06 17:38 ` Leo Prikler
2021-03-07 4:22 ` jgart via Guix-patches via [this message]
2021-03-07 8:09 ` bug#46699: " Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe5dd646139573b0b2013c23e3ec89c8@dismail.de \
--to=guix-patches@gnu.org \
--cc=46699@debbugs.gnu.org \
--cc=jgart@dismail.de \
--cc=leo.prikler@student.tugraz.at \
--cc=packaging-guix@libremiami.org \
--cc=rg@raghavgururajan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).