unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Prikler <leo.prikler@student.tugraz.at>
To: jgart <jgart@dismail.de>, 46699@debbugs.gnu.org
Cc: rg@raghavgururajan.name, LibreMiami <packaging-guix@libremiami.org>
Subject: [bug#46699] [PATCH] gnu: mumble: Update to 1.3.4.
Date: Mon, 22 Feb 2021 17:18:29 +0100	[thread overview]
Message-ID: <88fad40b7a501a43517bce0d85509fb271a2026f.camel@student.tugraz.at> (raw)
In-Reply-To: <039c316d735faa0a21cdacd1a28296cf@dismail.de>

Hi jgart and all the others listening from LibreMiami,

Am Montag, den 22.02.2021, 00:59 +0000 schrieb jgart:
> Co-author: jgart <jgart@dismail.de>
> Co-author: Raghav Gururajan <rg@raghavgururajan.name>
IIRC, the correct tag would be Co-authored-by.

> * gnu/packages/telephony.scm (mumble): Update to 1.3.4.
This is not enough of a ChangeLog for the changes made here.

> -     `(#:tests? #f  ; no "check" target
> +     `(#:tests? #f                      ; no "check" target

> -                                           "no-oss" ; use pulse
> -                                           "no-alsa" ; use pulse
> +                                           "no-oss"       ; use
> pulse
> +                                           "no-alsa"      ; use
> pulse

> -              (with-output-to-file "scripts/mumble-overlay"
> -                (lambda ()
> -                  (format #t "#!~a~%" (which "bash"))
> -                  (format #t "export LD_PRELOAD=\"~a
> $LD_PRELOAD\"~%"
> -                          (string-append (assoc-ref outputs "out")
> -                                         "/lib/mumble/libmumble.so.1
> "))
> -                  (format #t "exec \"${@}\"")))
> -              #t))
> +             (with-output-to-file "scripts/mumble-overlay"
> +               (lambda ()
> +                 (format #t "#!~a~%" (which "bash"))
> +                 (format #t "export LD_PRELOAD=\"~a $LD_PRELOAD\"~%"
> +                         (string-append (assoc-ref outputs "out")
> +                                        "/lib/mumble/libmumble.so.1"
> ))
> +                 (format #t "exec \"${@}\"")))
> +             #t))

> -         (replace 'install ; install phase does not exist
> +         (replace 'install              ; install phase does not
> exist

> -       ("mesa" ,mesa) ; avoid bundled
> +       ("mesa" ,mesa)                   ; avoid bundled
>         ("openssl" ,openssl)
> -       ("opus" ,opus) ; avoid bundled
> +       ("opus" ,opus)                   ; avoid bundled

> -       ("speex" ,speex) ; avoid bundled
> -       ("speexdsp" ,speexdsp))) ; avoid bundled
> +       ("speex" ,speex)                 ; avoid bundled
> +       ("speexdsp" ,speexdsp)))         ; avoid bundled
These lines appear to be noise, some of them definitely are. 

> -     `(("pkg-config" ,pkg-config)
> -       ("python" ,python)
> -       ("qttools" ,qttools)))
> +     `(("perl" ,perl)
> +       ("pkg-config" ,pkg-config)
> +       ("python" ,python-wrapper)
> +       ("qttools" ,qttools)
> +       ("ruby" ,ruby)))
Are perl and ruby really required?  If so, what for?

Regards,
Leo





  reply	other threads:[~2021-02-22 16:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22  0:59 [bug#46699] [PATCH] gnu: mumble: Update to 1.3.4 jgart via Guix-patches via
2021-02-22 16:18 ` Leo Prikler [this message]
2021-02-22 19:09 ` jgart via Guix-patches via
2021-02-22 19:28   ` Leo Prikler
2021-03-06 16:22 ` [bug#46699] [PATCH 1/2] " jgart via Guix-patches via
2021-03-06 16:35   ` Leo Prikler
2021-03-06 17:38     ` Leo Prikler
2021-03-07  4:22     ` jgart via Guix-patches via
2021-03-07  8:09       ` bug#46699: " Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88fad40b7a501a43517bce0d85509fb271a2026f.camel@student.tugraz.at \
    --to=leo.prikler@student.tugraz.at \
    --cc=46699@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=packaging-guix@libremiami.org \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).