unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#65898] [core-updates] gnu: ocaml: Allow not to build the native compiler.
@ 2023-09-12 20:31 Vivien Kraus via Guix-patches via
  2023-09-12 21:32 ` [bug#65898] Ocaml optional native compiler: it still fails for i686-linux Vivien Kraus via Guix-patches via
  2023-09-16  7:48 ` bug#65898: Closing Andreas Enge
  0 siblings, 2 replies; 3+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2023-09-12 20:31 UTC (permalink / raw)
  To: 65898; +Cc: julien, pukkamustard

* gnu/packages/ocaml.scm (ocaml-5.0) [entry point]: Build "defaultentry", not
"world.opt", so that the build system decides whether to build the native
compiler or just the bytecode compiler. The native compiler is not available
for 32-bit architectures.
---
 gnu/packages/ocaml.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 8ff755aea9..ea9d3e3594 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -219,7 +219,7 @@ (define-public ocaml-5.0
     (arguments
      `(#:configure-flags '("--enable-ocamltest")
        #:test-target "tests"
-       #:make-flags '("world.opt")
+       #:make-flags '("defaultentry")
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'patch-/bin/sh-references

base-commit: e79afd5d2574eb35f54c070a3f6048806721ef04
-- 
2.41.0




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#65898] Ocaml optional native compiler: it still fails for i686-linux
  2023-09-12 20:31 [bug#65898] [core-updates] gnu: ocaml: Allow not to build the native compiler Vivien Kraus via Guix-patches via
@ 2023-09-12 21:32 ` Vivien Kraus via Guix-patches via
  2023-09-16  7:48 ` bug#65898: Closing Andreas Enge
  1 sibling, 0 replies; 3+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2023-09-12 21:32 UTC (permalink / raw)
  To: 65898

Hi,

The native compiler for ocaml is not always available, especially for
i686-linux. The first step is to get the "best" possible compiler
instead of requiring the native compiler. However, building for i686-
linux still fails. The test suite reports no failure nor error, but it
still fails. What does that mean?

```
Summary:
  2285 tests passed
  592 tests skipped
    0 tests failed
  569 tests not started (parent test skipped or failed)
    0 unexpected errors
  3446 tests considered
make[1]: Leaving directory '/tmp/guix-build-ocaml-5.0.0.drv-
0/source/testsuite'

Test suite failed, dumping logs.
```

Vivien




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#65898: Closing
  2023-09-12 20:31 [bug#65898] [core-updates] gnu: ocaml: Allow not to build the native compiler Vivien Kraus via Guix-patches via
  2023-09-12 21:32 ` [bug#65898] Ocaml optional native compiler: it still fails for i686-linux Vivien Kraus via Guix-patches via
@ 2023-09-16  7:48 ` Andreas Enge
  1 sibling, 0 replies; 3+ messages in thread
From: Andreas Enge @ 2023-09-16  7:48 UTC (permalink / raw)
  To: 65898-done

Hello Vivien,

it has been built by QA, so I have pushed the patch and close this issue.
Thanks!

Andreas





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-09-16  7:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-12 20:31 [bug#65898] [core-updates] gnu: ocaml: Allow not to build the native compiler Vivien Kraus via Guix-patches via
2023-09-12 21:32 ` [bug#65898] Ocaml optional native compiler: it still fails for i686-linux Vivien Kraus via Guix-patches via
2023-09-16  7:48 ` bug#65898: Closing Andreas Enge

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).