From: goodoldpaul@autistici.org
To: 41219@debbugs.gnu.org
Subject: [bug#41219] Enforce "files" directive in node build system
Date: Tue, 12 May 2020 21:30:48 +0000 [thread overview]
Message-ID: <f5d2082ad387f7547fa2f143b742559b@autistici.org> (raw)
In-Reply-To: <5ec7ac973bb248a3cca0197836d35459@autistici.org>
On 2020-05-12 21:26, goodoldpaul@autistici.org wrote:
> Hi,
>
> I'm sending a couple of patches to fix
> https://issues.guix.gnu.org/40710, I tried to base my implementation
> on [0].
>
> The first patch adds "globstar" support to (guix glob), namely the
> ability of recursively matching subdirectories in a glob pattern (i.e.
> "foo/**/bar.scm" matches both "foo/bar.scm" and "foo/baz/bar.scm").
>
> The second patch adds (guix glob) to the imported modules of
> node-build-system and uses that to parse glob patterns in the "files"
> array of a package.json and then install all the matching files.
>
> I tested the patches by verifying that
>
> ./pre-inst-env guix build -K node-semver node-util-deprecate
> node-statsd-parser node-stack-trace node-oop node-mersenne
> node-long-stack-traces node-far node-env-variable node-color-name
>
> runs without error and and by running make check
> TESTS="tests/glob.scm" .
I apologize I sent by error without finishing.
Anyway I verified that the installed files match the "files" directive
when present, otherwise we fall back to the original behavior of
installing everything. I'm not really sure i added enough test cases in
"tests/glob.scm", please do tell me if you believe I should add more.
Thank for your patience in reviewing this.
Giacomo
next prev parent reply other threads:[~2020-05-12 21:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 21:26 [bug#41219] Enforce "files" directive in node build system goodoldpaul
2020-05-12 21:30 ` goodoldpaul [this message]
2020-05-12 21:31 ` [bug#41219] [PATCH 1/2] guix: Add globstar support Giacomo Leidi
2020-05-12 21:31 ` [bug#41219] [PATCH 2/2] guix: Enforce package.json "files" directive Giacomo Leidi
2020-06-05 23:09 ` goodoldpaul
2020-09-19 15:15 ` paul
2020-09-20 19:51 ` Jelle Licht
2020-09-21 20:33 ` paul
2020-09-22 15:47 ` paul
2020-09-22 18:09 ` Jelle Licht
2020-10-18 23:32 ` paul
2020-10-19 13:44 ` paul
2020-10-24 13:23 ` Jelle Licht
2020-10-24 17:07 ` paul
2020-11-30 23:30 ` paul
2020-12-09 21:45 ` bug#41219: " Jelle Licht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5d2082ad387f7547fa2f143b742559b@autistici.org \
--to=goodoldpaul@autistici.org \
--cc=41219@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).