From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uHEkDM0Vu16wQwAA0tVLHw (envelope-from ) for ; Tue, 12 May 2020 21:31:57 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MEM8KNsVu16CTAAAB5/wlQ (envelope-from ) for ; Tue, 12 May 2020 21:32:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1AA2C940D36 for ; Tue, 12 May 2020 21:32:09 +0000 (UTC) Received: from localhost ([::1]:39428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYcVV-000762-Am for larch@yhetil.org; Tue, 12 May 2020 17:32:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYcUR-0006vx-Q4 for guix-patches@gnu.org; Tue, 12 May 2020 17:31:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45152) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYcUR-0000Em-FF for guix-patches@gnu.org; Tue, 12 May 2020 17:31:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jYcUQ-0000yo-Bj for guix-patches@gnu.org; Tue, 12 May 2020 17:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41219] Enforce "files" directive in node build system Resent-From: goodoldpaul@autistici.org Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 May 2020 21:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41219 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 41219@debbugs.gnu.org Received: via spool by 41219-submit@debbugs.gnu.org id=B41219.15893190523207 (code B ref 41219); Tue, 12 May 2020 21:31:02 +0000 Received: (at 41219) by debbugs.gnu.org; 12 May 2020 21:30:52 +0000 Received: from localhost ([127.0.0.1]:56698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYcUG-0000pK-AU for submit@debbugs.gnu.org; Tue, 12 May 2020 17:30:52 -0400 Received: from confino.investici.org ([212.103.72.250]:31591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYcUE-0000md-S3 for 41219@debbugs.gnu.org; Tue, 12 May 2020 17:30:51 -0400 Received: from 1.mail-backend.investici.org (unknown [10.0.0.11]) by confino.investici.org (Postfix) with ESMTP id 1458A20FA4 for <41219@debbugs.gnu.org>; Tue, 12 May 2020 21:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1589319049; bh=nSN96N9jkGv/Lx3SWKy/Suag5cJdjxQCXxvuh94W7Is=; h=Date:From:To:Subject:In-Reply-To:References:From; b=Oy3OSGCCQDOhyarBNSDVejWZq1k2Iv+bdh++0r5HL+Lkd8R57DeBS68TF6g3FrH+G PQvWXHUmMVh5sKrj/22lVYFRYzgk6o0/t8MUapxborlcsHypfO/c92Pk3ePC5Ij3dh yPont96/SrG56tFUFIZBtYqFdIIdmu7HlCj2qKYk= Received: from 1.webmail.investici.org (localhost [127.0.0.1]) (Authenticated sender: goodoldpaul@autistici.org) by 1.mail-backend.investici.org (Postfix) with ESMTPA id E0BA7BEE39 for <41219@debbugs.gnu.org>; Tue, 12 May 2020 21:30:48 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 12 May 2020 21:30:48 +0000 From: goodoldpaul@autistici.org In-Reply-To: <5ec7ac973bb248a3cca0197836d35459@autistici.org> References: <5ec7ac973bb248a3cca0197836d35459@autistici.org> User-Agent: Roundcube Webmail Message-ID: X-Sender: goodoldpaul@autistici.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -0.00 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=autistici.org header.s=stigmate header.b=Oy3OSGCC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-0.00 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.53963692183357]; XM_UA_NO_VERSION(0.01)[]; DWL_DNSWL_FAIL(0.00)[209.51.188.17:server fail]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.06), country: US(-0.00), ip: 209.51.188.17(-0.54)]; TO_DN_NONE(0.00)[]; R_DKIM_REJECT(1.00)[autistici.org:s=stigmate]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; DKIM_TRACE(0.00)[autistici.org:-]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[goodoldpaul@autistici.org,guix-patches-bounces@gnu.org]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[autistici.org:email,gnu.org:url]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[41219@debbugs.gnu.org]; DMARC_NA(0.00)[autistici.org]; HAS_LIST_UNSUB(-0.01)[]; RCPT_COUNT_ONE(0.00)[1]; DNSWL_BLOCKED(0.00)[209.51.188.17:from]; FROM_NO_DN(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.51.188.17:from]; RCVD_COUNT_SEVEN(0.00)[9]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: jP8bn0tsUrDM On 2020-05-12 21:26, goodoldpaul@autistici.org wrote: > Hi, > > I'm sending a couple of patches to fix > https://issues.guix.gnu.org/40710, I tried to base my implementation > on [0]. > > The first patch adds "globstar" support to (guix glob), namely the > ability of recursively matching subdirectories in a glob pattern (i.e. > "foo/**/bar.scm" matches both "foo/bar.scm" and "foo/baz/bar.scm"). > > The second patch adds (guix glob) to the imported modules of > node-build-system and uses that to parse glob patterns in the "files" > array of a package.json and then install all the matching files. > > I tested the patches by verifying that > > ./pre-inst-env guix build -K node-semver node-util-deprecate > node-statsd-parser node-stack-trace node-oop node-mersenne > node-long-stack-traces node-far node-env-variable node-color-name > > runs without error and and by running make check > TESTS="tests/glob.scm" . I apologize I sent by error without finishing. Anyway I verified that the installed files match the "files" directive when present, otherwise we fall back to the original behavior of installing everything. I'm not really sure i added enough test cases in "tests/glob.scm", please do tell me if you believe I should add more. Thank for your patience in reviewing this. Giacomo