* [bug#69244] [PATCH] gnu: go-golang-org-x-net-html: Add missing input. @ 2024-02-17 17:38 Troy Figiel 2024-02-18 22:08 ` Sharlatan Hellseher 2024-02-20 0:04 ` bug#69244: " Sharlatan Hellseher 0 siblings, 2 replies; 4+ messages in thread From: Troy Figiel @ 2024-02-17 17:38 UTC (permalink / raw) To: 69244 * gnu/packages/golang-build.scm (go-golang-org-x-net-html): Add missing input. [propagated-inputs]: Add go-golang-org-x-text. --- gnu/packages/golang-build.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/golang-build.scm b/gnu/packages/golang-build.scm index 8b7dca46a6..04267845a5 100644 --- a/gnu/packages/golang-build.scm +++ b/gnu/packages/golang-build.scm @@ -16,6 +16,7 @@ ;;; Copyright © 2023 Katherine Cox-Buday <cox.katherine.e@gmail.com> ;;; Copyright © 2023 Nicolas Graves <ngraves@ngraves.fr> ;;; Copyright © 2023 Timo Wilken <guix@twilken.net> +;;; Copyright © 2024 Troy Figiel <troy@troyfigiel.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -252,6 +253,7 @@ (define-public go-golang-org-x-net-html (arguments '(#:import-path "golang.org/x/net/html" #:unpack-path "golang.org/x/net")) + (propagated-inputs (list go-golang-org-x-text)) (home-page "https://godoc.org/golang.org/x/net/html") (synopsis "HTML5-compliant tokenizer and parser") (description base-commit: 91d80460296e2d5a01704d0f34fb966a45a165ae -- 2.42.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#69244] [PATCH] gnu: go-golang-org-x-net-html: Add missing input. 2024-02-17 17:38 [bug#69244] [PATCH] gnu: go-golang-org-x-net-html: Add missing input Troy Figiel @ 2024-02-18 22:08 ` Sharlatan Hellseher 2024-02-18 22:47 ` Troy Figiel 2024-02-20 0:04 ` bug#69244: " Sharlatan Hellseher 1 sibling, 1 reply; 4+ messages in thread From: Sharlatan Hellseher @ 2024-02-18 22:08 UTC (permalink / raw) To: 69244; +Cc: Troy Figiel [-- Attachment #1: Type: text/plain, Size: 766 bytes --] Hi Troy, I've started review process for all Golang related patches sent. Did you check the go.mod for the commit of go-golang-org-x-net package? It looks like it need 2 more modules <https://cs.opensource.google/go/x/net/+/8e0e7d8d38f2b6d21d742845570dde2902d06a1d:go.mod> --8<---------------cut here---------------start------------->8--- module golang.org/x/net go 1.17 require ( golang.org/x/sys v0.4.0 golang.org/x/term v0.4.0 golang.org/x/text v0.6.0 ) --8<---------------cut here---------------end--------------->8--- Due to large amount of impact for any packages in golang-build, I would place it in go-team branch (not existing yet). May, please, double check if we need golang.org/x/sys and golang.org/x/term and send v2 if so. -- Oleg [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#69244] [PATCH] gnu: go-golang-org-x-net-html: Add missing input. 2024-02-18 22:08 ` Sharlatan Hellseher @ 2024-02-18 22:47 ` Troy Figiel 0 siblings, 0 replies; 4+ messages in thread From: Troy Figiel @ 2024-02-18 22:47 UTC (permalink / raw) To: Sharlatan Hellseher, 69244 [-- Attachment #1.1.1: Type: text/plain, Size: 1336 bytes --] Hi Oleg, On 2024-02-18 23:08, Sharlatan Hellseher wrote> Did you check the go.mod for the commit of go-golang-org-x-net package? > It looks like it need 2 more modules > The entire module (golang.org/x/net) does need those two Go packages, but the golang.org/x/net/html Go package does not, i.e. the inputs as I sent them are correct. This is a result of how Guix has packaged Go in the past, with a Guix package per Go package, not per Go module. This means we cannot reliably use the go.mod file to determine dependencies, as there might be a bunch that we do not need. For future Guix packages, I think it will be easier to follow the Go module structure instead, but that is a topic for the mailing list :-) > Due to large amount of impact for any packages in golang-build, I would > place it in go-team branch (not existing yet). > With "guix refresh -l go-golang-org-x-net-html" I only see 2 dependents (emacs-ghq rebuilds both). I am not sure I understand what you mean. In general though, feel free to apply these missing inputs, fixes, etc. whenever is convenient. I am locally working with a separate branch, which already uses the "/..." fix (for both the build and check phases) and I regularly rebase this branch on master. Sending updated patches is no issue. Best wishes, Troy [-- Attachment #1.1.2: OpenPGP public key --] [-- Type: application/pgp-keys, Size: 6367 bytes --] [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#69244: [PATCH] gnu: go-golang-org-x-net-html: Add missing input. 2024-02-17 17:38 [bug#69244] [PATCH] gnu: go-golang-org-x-net-html: Add missing input Troy Figiel 2024-02-18 22:08 ` Sharlatan Hellseher @ 2024-02-20 0:04 ` Sharlatan Hellseher 1 sibling, 0 replies; 4+ messages in thread From: Sharlatan Hellseher @ 2024-02-20 0:04 UTC (permalink / raw) To: 69244-done [-- Attachment #1: Type: text/plain, Size: 77 bytes --] Hi, Pushed as d234999cac6d6f16ce121ed2ead28adc0d41b5ed to master. -- Oleg [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-20 0:07 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-02-17 17:38 [bug#69244] [PATCH] gnu: go-golang-org-x-net-html: Add missing input Troy Figiel 2024-02-18 22:08 ` Sharlatan Hellseher 2024-02-18 22:47 ` Troy Figiel 2024-02-20 0:04 ` bug#69244: " Sharlatan Hellseher
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).