unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#48308] [PATCH] gnu: racket: Update to 8.1.
@ 2021-05-09  7:28 Philip McGrath
  2021-05-09 20:34 ` Jack Hill
  0 siblings, 1 reply; 4+ messages in thread
From: Philip McGrath @ 2021-05-09  7:28 UTC (permalink / raw)
  To: 48308; +Cc: Philip McGrath

* gnu/packages/racket.scm (racket-minimal): Update to 8.1.
[arguments](#:phases): Remove 'patch-chez-configure: fixes applied upstream.
(racket): Update to 8.1.
---
 gnu/packages/racket.scm | 36 +++---------------------------------
 1 file changed, 3 insertions(+), 33 deletions(-)

diff --git a/gnu/packages/racket.scm b/gnu/packages/racket.scm
index f2bbf28564..18af14b2ec 100644
--- a/gnu/packages/racket.scm
+++ b/gnu/packages/racket.scm
@@ -66,14 +66,14 @@
 (define-public racket-minimal
   (package
     (name "racket-minimal")
-    (version "8.0")            ; note: remember to also update racket!
+    (version "8.1")            ; note: remember to also update racket!
     (source
      (origin
        (method url-fetch)
        (uri (map (lambda (base)
                    (string-append base version "/racket-minimal-src.tgz"))
                  %installer-mirrors))
-       (sha256 "0mwyffw4gcci8wmzxa3j28h03h0gsz55aard8qrk3lri8r2xyg21")
+       (sha256 "04zzqybpxss50n1jrwwq98539gw0y0ygpw9civl2sq3s4ww7m8l3")
        (patches (search-patches
                  "racket-sh-via-rktio.patch"))))
     (home-page "https://racket-lang.org")
@@ -100,36 +100,6 @@
         (srfi srfi-1))
        #:phases
        (modify-phases %standard-phases
-         (add-after 'unpack 'patch-chez-configure
-           (lambda* (#:key inputs outputs #:allow-other-keys)
-             (substitute* "src/cs/c/Makefile.in"
-               (("/bin/sh") (which "sh")))
-             ;; TODO: Racket CS uses a fork of Chez Scheme.
-             ;; Most of this is copy-pasted from the "chez.scm",
-             ;; but maybe there's a way to reuse more directly.
-             (with-directory-excursion "src/ChezScheme"
-               (substitute* (find-files "mats" "Mf-.*")
-                 (("^[[:space:]]+(cc ) *") "\tgcc "))
-               (substitute*
-                   (find-files "." (string-append
-                                    "("
-                                    "Mf-[a-zA-Z0-9.]+"
-                                    "|Makefile[a-zA-Z0-9.]*"
-                                    "|checkin"
-                                    "|stex\\.stex"
-                                    "|newrelease"
-                                    "|workarea"
-                                    "|unix\\.ms"
-                                    "|^6\\.ms"
-                                    ;;"|[a-zA-Z0-9.]+\\.ms" ; guile can't read
-                                    ")"))
-                 (("/bin/rm") (which "rm"))
-                 (("/bin/ln") (which "ln"))
-                 (("/bin/cp") (which "cp"))
-                 (("/bin/echo") (which "echo")))
-               (substitute* "makefiles/installsh"
-                 (("/bin/true") (which "true"))))
-             #t))
          (add-before 'configure 'pre-configure-minimal
            (lambda* (#:key inputs #:allow-other-keys)
              (chdir "src")
@@ -215,7 +185,7 @@ DrRacket IDE, are not included.")
                  %installer-mirrors))
        (sha256
         (base32
-         "047wpjblfzmf1msz7snrp2c2h0zxyzlmbsqr9bwsyvz3frcg0888"))))
+         "0xdqwrwm604bbnr97h75dps2ixxz2svlw0fn0f674bn04dcfd60f"))))
     (inputs
      `(;; sqlite and libraries for `racket/draw' are needed to build the doc.
        ("cairo" ,cairo)
-- 
2.30.2





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#48308] [PATCH] gnu: racket: Update to 8.1.
  2021-05-09  7:28 [bug#48308] [PATCH] gnu: racket: Update to 8.1 Philip McGrath
@ 2021-05-09 20:34 ` Jack Hill
  2021-05-09 21:06   ` Philip McGrath
  2021-05-10 13:13   ` bug#48308: " Efraim Flashner
  0 siblings, 2 replies; 4+ messages in thread
From: Jack Hill @ 2021-05-09 20:34 UTC (permalink / raw)
  To: Philip McGrath; +Cc: 48308

On Sun, 9 May 2021, Philip McGrath wrote:

> * gnu/packages/racket.scm (racket-minimal): Update to 8.1.
> [arguments](#:phases): Remove 'patch-chez-configure: fixes applied upstream.
> (racket): Update to 8.1.

Thanks for making the update. I tested building both racket and 
racket-minimal on x86_64, and was able to do a lite REPL session in each 
one without problems.

Its nice that you CS building patch made it into upstream. 
Congratulations.

Not related to the update, but I noticed `guix lint` complain about the 
racket synopsis (it begins with an article). I think we could just drop 
the 'a' and leave the rest of it as is and it would still make sense and 
satisfy the linter.

Best,
Jack




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#48308] [PATCH] gnu: racket: Update to 8.1.
  2021-05-09 20:34 ` Jack Hill
@ 2021-05-09 21:06   ` Philip McGrath
  2021-05-10 13:13   ` bug#48308: " Efraim Flashner
  1 sibling, 0 replies; 4+ messages in thread
From: Philip McGrath @ 2021-05-09 21:06 UTC (permalink / raw)
  To: Jack Hill; +Cc: 48308

On 5/9/21 4:34 PM, Jack Hill wrote:
> Not related to the update, but I noticed `guix lint` complain about the 
> racket synopsis (it begins with an article). I think we could just drop 
> the 'a' and leave the rest of it as is and it would still make sense and 
> satisfy the linter.

Ah, yes, I had noticed that. It's not a big deal and I'm happy to defer 
to community consensus. I had kept the "a" because it's a reference to 
Felleisen et. al.'s "A Programmable Programming Language" 
(Communications of the ACM, March 2018) [1], the title of which in turn 
is a quote Foderaro's "LISP: Introduction" (Communications of the ACM, 
September 1991) [2]:

 > When Lisp adopts a new paradigm, it not only replicates
 > existing practice, but goes beyond it to become a testbed
 > for advancing the state of the art. Why has Lisp been able
 > to adapt so easily when other languages have not? One
 > reason is that Lisp is a *programmable* programming language.
 > Not only can you program *in* Lisp (that makes it a programming
 > language) but you can program the language itself.

[1]: 
https://cacm.acm.org/magazines/2018/3/225475-a-programmable-programming-language/fulltext
[2]: https://doi.org/10.1145/114669.114670

-Philip




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#48308: [PATCH] gnu: racket: Update to 8.1.
  2021-05-09 20:34 ` Jack Hill
  2021-05-09 21:06   ` Philip McGrath
@ 2021-05-10 13:13   ` Efraim Flashner
  1 sibling, 0 replies; 4+ messages in thread
From: Efraim Flashner @ 2021-05-10 13:13 UTC (permalink / raw)
  To: Jack Hill; +Cc: 48308-done, Philip McGrath

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

On Sun, May 09, 2021 at 04:34:02PM -0400, Jack Hill wrote:
> On Sun, 9 May 2021, Philip McGrath wrote:
> 
> > * gnu/packages/racket.scm (racket-minimal): Update to 8.1.
> > [arguments](#:phases): Remove 'patch-chez-configure: fixes applied upstream.
> > (racket): Update to 8.1.
> 
> Thanks for making the update. I tested building both racket and
> racket-minimal on x86_64, and was able to do a lite REPL session in each one
> without problems.
> 
> Its nice that you CS building patch made it into upstream. Congratulations.
> 
> Not related to the update, but I noticed `guix lint` complain about the
> racket synopsis (it begins with an article). I think we could just drop the
> 'a' and leave the rest of it as is and it would still make sense and satisfy
> the linter.
> 

Thank you both, I'm taking this as confirmation that the package works.

Patch pushed!

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-05-10 13:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-09  7:28 [bug#48308] [PATCH] gnu: racket: Update to 8.1 Philip McGrath
2021-05-09 20:34 ` Jack Hill
2021-05-09 21:06   ` Philip McGrath
2021-05-10 13:13   ` bug#48308: " Efraim Flashner

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).