[bug#27859] [PATCH] gnu: Add emacs-rpm-spec-mode.

[bug#27859] [PATCH] gnu: Add emacs-rpm-spec-mode.

[Oleg Pykhalov]

* gnu/packages/emacs.scm (emacs-rpm-spec-mode): New variable.
---
 gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 5f5b6fc2e..f551f4c31 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -5256,3 +5256,29 @@ src block.")
      "@code{emacs-emamux} lets Emacs interact with the @code{tmux} terminal
 multiplexer.")
     (license license:gpl3+)))
+
+(define-public emacs-rpm-spec-mode
+  (let ((commit "bbce63f042ea07aa8c2fe67e02357c8521624293")
+        (revision "1"))
+    (package
+      (name "emacs-rpm-spec-mode")
+      (version (string-append "0.0.1-" revision "."
+                              (string-take commit 7)))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url (string-append
+                            "https://src.fedoraproject.org/git/rpms"
+                            "/emacs-rpm-spec-mode.git"))
+                      (commit commit)))
+                (file-name (string-append name "-" version "-checkout"))
+                (sha256
+                 (base32
+                  "0cznnm5jmi38xr8ycnmkcyp60a9nvq9rlhy2w3lij4070n6xzcb4"))))
+      (build-system emacs-build-system)
+      (home-page (string-append "http://pkgs.fedoraproject.org/cgit/rpms"
+                                "/emacs-rpm-spec-mode.git"))
+      (synopsis "Emacs major mode for editing RPM spec files")
+      (description "@code{emacs-rpm-spec-mode} provides Emacs major mode for
+editing RPM spec files.")
+      (license license:gpl2+))))
-- 
2.13.3

[bug#27859] [PATCH] gnu: Add emacs-rpm-spec-mode.

[Arun Isaac]

Thanks for the patch!

> +(define-public emacs-rpm-spec-mode
> +  (let ((commit "bbce63f042ea07aa8c2fe67e02357c8521624293")
> +        (revision "1"))
> +    (package
> +      (name "emacs-rpm-spec-mode")
> +      (version (string-append "0.0.1-" revision "."
> +                              (string-take commit 7)))

version should be 0.16. Look at line 7 of rpm-spec-mode.el.

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url (string-append
> +                            "https://src.fedoraproject.org/git/rpms"
> +                            "/emacs-rpm-spec-mode.git"))
> +                      (commit commit)))
> +                (file-name (string-append name "-" version "-checkout"))
> +                (sha256
> +                 (base32
> +                  "0cznnm5jmi38xr8ycnmkcyp60a9nvq9rlhy2w3lij4070n6xzcb4"))))

It would be nice if upstream provided a release tarball. We wouldn't
have to clone their git repo. Could you ask them about it?

> +      (build-system emacs-build-system)
> +      (home-page (string-append "http://pkgs.fedoraproject.org/cgit/rpms"
> +                                "/emacs-rpm-spec-mode.git"))
> +      (synopsis "Emacs major mode for editing RPM spec files")
> +      (description "@code{emacs-rpm-spec-mode} provides Emacs major mode for
> +editing RPM spec files.")
> +      (license license:gpl2+))))

LGTM, otherwise!

[bug#27859] [PATCH] gnu: Add emacs-rpm-spec-mode.

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 1621 bytes --]

Hello Arun,

Arun Isaac <arunisaac@systemreboot.net> writes:

> Thanks for the patch!
>
>> +(define-public emacs-rpm-spec-mode
>> +  (let ((commit "bbce63f042ea07aa8c2fe67e02357c8521624293")
>> +        (revision "1"))
>> +    (package
>> +      (name "emacs-rpm-spec-mode")
>> +      (version (string-append "0.0.1-" revision "."
>> +                              (string-take commit 7)))
>
> version should be 0.16. Look at line 7 of rpm-spec-mode.el.

OK.

>> +      (source (origin
>> +                (method git-fetch)
>> +                (uri (git-reference
>> +                      (url (string-append
>> +                            "https://src.fedoraproject.org/git/rpms"
>> +                            "/emacs-rpm-spec-mode.git"))
>> +                      (commit commit)))
>> +                (file-name (string-append name "-" version "-checkout"))
>> +                (sha256
>> +                 (base32
>> +                  "0cznnm5jmi38xr8ycnmkcyp60a9nvq9rlhy2w3lij4070n6xzcb4"))))
>
> It would be nice if upstream provided a release tarball. We wouldn't
> have to clone their git repo. Could you ask them about it?

I hacked on their cgit repository little bit and found that they provide
release tarballs.

They based on tags.  So versions are equal to Fedora distro versions. Is
it OK?  By the way, I'm not sure how to properly make “version” variable

(uri (string-append
                    "https://src.fedoraproject.org/cgit/rpms"
                    "/emacs-rpm-spec-mode.git/snapshot"
                    "/emacs-rpm-spec-mode-f26.tar.gz"))


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Change url to release tarball. --]
[-- Type: text/x-patch, Size: 1540 bytes --]

From 8034e01f99411b2f08967e2765bdd3f8c0374c10 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Fri, 28 Jul 2017 17:48:23 +0300
Subject: [PATCH] gnu: Add emacs-rpm-spec-mode.

* gnu/packages/emacs.scm (emacs-rpm-spec-mode): New variable.
---
 gnu/packages/emacs.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 5f5b6fc2e..c97d46498 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -5256,3 +5256,24 @@ src block.")
      "@code{emacs-emamux} lets Emacs interact with the @code{tmux} terminal
 multiplexer.")
     (license license:gpl3+)))
+
+(define-public emacs-rpm-spec-mode
+  (package
+    (name "emacs-rpm-spec-mode")
+    (version "0.16")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://src.fedoraproject.org/cgit/rpms"
+                    "/emacs-rpm-spec-mode.git/snapshot"
+                    "/emacs-rpm-spec-mode-f26.tar.gz"))
+              (sha256
+               (base32
+                "17dz80lhjrc89fj17pysl8slahzrqdkxgcjdk55zls6jizkr6kz3"))))
+    (build-system emacs-build-system)
+    (home-page (string-append "http://pkgs.fedoraproject.org/cgit/rpms"
+                              "/emacs-rpm-spec-mode.git"))
+    (synopsis "Emacs major mode for editing RPM spec files")
+    (description "@code{emacs-rpm-spec-mode} provides Emacs major mode for
+editing RPM spec files.")
+    (license license:gpl2+)))
-- 
2.13.3


[-- Attachment #3: Type: text/plain, Size: 339 bytes --]



Can make another way with downloading plain “*.el” files.  We need only
two:
https://src.fedoraproject.org/cgit/rpms/emacs-rpm-spec-mode.git/plain/rpm-spec-mode.el
https://src.fedoraproject.org/cgit/rpms/emacs-rpm-spec-mode.git/plain/rpm-spec-mode-init.el


If this is not good, I'll write to their mailing list.

Thanks!

bug#27859: [PATCH] gnu: Add emacs-rpm-spec-mode.

[Arun Isaac]

Thanks, I've pushed the patch! I just added a comment mentioning the
minor difficulty with the Fedora release number being in the URI. I also
made a few other very minor stylistic changes.