unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#57492] [PATCH core-updates] gnu: boost: Update to 1.80.0.
@ 2022-08-30 16:36 Greg Hogan
  2022-08-30 19:50 ` Maxime Devos
  2022-08-31 13:43 ` [bug#57492] [PATCH core-updates v2] " Greg Hogan
  0 siblings, 2 replies; 5+ messages in thread
From: Greg Hogan @ 2022-08-30 16:36 UTC (permalink / raw)
  To: 57492; +Cc: Greg Hogan

* gnu/packages/boost.scm (boost): Update to 1.80.0.
[source](patches): Add new and remove old upstream patches.
---
 gnu/packages/boost.scm | 26 ++++++++++++++++++++------
 1 file changed, 20 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/boost.scm b/gnu/packages/boost.scm
index 818669b757..55296889b8 100644
--- a/gnu/packages/boost.scm
+++ b/gnu/packages/boost.scm
@@ -68,7 +68,7 @@ (define (boost-patch name version hash)
 (define-public boost
   (package
     (name "boost")
-    (version "1.79.0")
+    (version "1.80.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://boostorg.jfrog.io/artifactory/main/release/"
@@ -76,13 +76,27 @@ (define-public boost
                                   (version-with-underscores version) ".tar.bz2"))
               (patches
                (list (boost-patch
-                      ;; 1.79.0 was released with a segmentation fault:
-                      ;; <https://github.com/boostorg/json/issues/692>.
-                      "0001-json-array-erase-relocate.patch" version
-                      "1b0izwj8w92imr8ydzrh522syncprpf82n3kcy6apxn6p54b7p0f")))
+                      ;; Boost.Filesystem directory iterators may fail to
+                      ;; construct for a network share on Windows prior to 10:
+                      ;; https://github.com/boostorg/filesystem/pull/246,
+                      ;; https://github.com/boostorg/filesystem/issues/245
+                      "0001-filesystem-win-fix-dir-it-net-share.patch" version
+                      "067hhylqkzzdbqzc1hkbpaqmvz248lxqrdhb2yi6iq9qabsik3lk")
+                     (boost-patch
+                      ;; In Boost.Filesystem on Windows, weakly_canonical fails
+                      ;; to process paths that start with the "\\?\" prefix:
+                      ;; https://github.com/boostorg/filesystem/issues/247
+                      "0002-filesystem-fix-weakly-canonical-long-paths.patch" version
+                      "00w3albf8527glclx85p5b2ml3vr06xpwwmfyzg005v1cp8avcpi")
+                     (boost-patch
+                      ;; Boost.Unordered containers are not in a valid state
+                      ;; after moving:
+                      ;; https://github.com/boostorg/unordered/issues/139
+                      "0003-unordered-valid-after-move.patch" version
+                      "0dw839w22cawqawfpsx7j7v9y0x2vn66m732iidpxvdxbjn2kzva")))
               (sha256
                (base32
-                "0fggarccddj6q4ifj3kn7g565rbhn4ia1vd45fxb7y57a6fmhpa7"))))
+                "1h00qp4z5k6lfz310xjwsmqs8fwxi6ngas51169cafz4h9fmc68y"))))
     (build-system gnu-build-system)
     (inputs
      (append
-- 
2.37.2





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#57492] [PATCH core-updates] gnu: boost: Update to 1.80.0.
  2022-08-30 16:36 [bug#57492] [PATCH core-updates] gnu: boost: Update to 1.80.0 Greg Hogan
@ 2022-08-30 19:50 ` Maxime Devos
  2022-08-30 20:15   ` Greg Hogan
  2022-08-31 13:43 ` [bug#57492] [PATCH core-updates v2] " Greg Hogan
  1 sibling, 1 reply; 5+ messages in thread
From: Maxime Devos @ 2022-08-30 19:50 UTC (permalink / raw)
  To: Greg Hogan, 57492


[-- Attachment #1.1.1: Type: text/plain, Size: 1299 bytes --]

On 30-08-2022 18:36, Greg Hogan wrote:

> +                      ;; Boost.Filesystem directory iterators may fail to
> +                      ;; construct for a network share on Windows prior to 10:
> +                      ;;https://github.com/boostorg/filesystem/pull/246,
> +                      ;;https://github.com/boostorg/filesystem/issues/245
> +                      "0001-filesystem-win-fix-dir-it-net-share.patch" version
> +                      "067hhylqkzzdbqzc1hkbpaqmvz248lxqrdhb2yi6iq9qabsik3lk")
> +                     (boost-patch
> +                      ;; In Boost.Filesystem on Windows, weakly_canonical fails
> +                      ;; to process paths that start with the "\\?\" prefix:
> +                      ;;https://github.com/boostorg/filesystem/issues/247
> +                      "0002-filesystem-fix-weakly-canonical-long-paths.patch" version
> +                      "00w3albf8527glclx85p5b2ml3vr06xpwwmfyzg005v1cp8avcpi")

Going by https://www.boost.org/patches/, you seem to have missed 
0004-filesystem-posix-fix-no-at-apis-missing-include.patch. Perhaps it 
is not required for compilation on supported targets in Guix, but 
neither is Windows a supported target yet you are including 
Windows-specific patches.

Greetings,
Maxime


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#57492] [PATCH core-updates] gnu: boost: Update to 1.80.0.
  2022-08-30 19:50 ` Maxime Devos
@ 2022-08-30 20:15   ` Greg Hogan
  0 siblings, 0 replies; 5+ messages in thread
From: Greg Hogan @ 2022-08-30 20:15 UTC (permalink / raw)
  To: Maxime Devos; +Cc: 57492

On Tue, Aug 30, 2022 at 3:50 PM Maxime Devos <maximedevos@telenet.be> wrote:
> [...]
> Going by https://www.boost.org/patches/, you seem to have missed
> 0004-filesystem-posix-fix-no-at-apis-missing-include.patch. Perhaps it
> is not required for compilation on supported targets in Guix, but
> neither is Windows a supported target yet you are including
> Windows-specific patches.
>
> Greetings,
> Maxime

Thank you, this fourth patch was missed as it is absent from the
release page at
https://www.boost.org/users/history/version_1_80_0.html. I will submit
a revised patch and also check the full patch listing in the future.

Greg




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#57492] [PATCH core-updates v2] gnu: boost: Update to 1.80.0.
  2022-08-30 16:36 [bug#57492] [PATCH core-updates] gnu: boost: Update to 1.80.0 Greg Hogan
  2022-08-30 19:50 ` Maxime Devos
@ 2022-08-31 13:43 ` Greg Hogan
  2022-09-01 21:00   ` bug#57492: " Marius Bakke
  1 sibling, 1 reply; 5+ messages in thread
From: Greg Hogan @ 2022-08-31 13:43 UTC (permalink / raw)
  To: 57492; +Cc: Greg Hogan

* gnu/packages/boost.scm (boost): Update to 1.80.0.
[source](patches): Add new and remove old upstream patches.
---
 gnu/packages/boost.scm | 32 ++++++++++++++++++++++++++------
 1 file changed, 26 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/boost.scm b/gnu/packages/boost.scm
index 818669b757..d2b676cc73 100644
--- a/gnu/packages/boost.scm
+++ b/gnu/packages/boost.scm
@@ -68,7 +68,7 @@ (define (boost-patch name version hash)
 (define-public boost
   (package
     (name "boost")
-    (version "1.79.0")
+    (version "1.80.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://boostorg.jfrog.io/artifactory/main/release/"
@@ -76,13 +76,33 @@ (define-public boost
                                   (version-with-underscores version) ".tar.bz2"))
               (patches
                (list (boost-patch
-                      ;; 1.79.0 was released with a segmentation fault:
-                      ;; <https://github.com/boostorg/json/issues/692>.
-                      "0001-json-array-erase-relocate.patch" version
-                      "1b0izwj8w92imr8ydzrh522syncprpf82n3kcy6apxn6p54b7p0f")))
+                      ;; Boost.Filesystem directory iterators may fail to
+                      ;; construct for a network share on Windows prior to 10:
+                      ;; https://github.com/boostorg/filesystem/pull/246,
+                      ;; https://github.com/boostorg/filesystem/issues/245
+                      "0001-filesystem-win-fix-dir-it-net-share.patch" version
+                      "067hhylqkzzdbqzc1hkbpaqmvz248lxqrdhb2yi6iq9qabsik3lk")
+                     (boost-patch
+                      ;; In Boost.Filesystem on Windows, weakly_canonical fails
+                      ;; to process paths that start with the "\\?\" prefix:
+                      ;; https://github.com/boostorg/filesystem/issues/247
+                      "0002-filesystem-fix-weakly-canonical-long-paths.patch" version
+                      "00w3albf8527glclx85p5b2ml3vr06xpwwmfyzg005v1cp8avcpi")
+                     (boost-patch
+                      ;; Boost.Unordered containers are not in a valid state
+                      ;; after moving:
+                      ;; https://github.com/boostorg/unordered/issues/139
+                      "0003-unordered-valid-after-move.patch" version
+                      "0dw839w22cawqawfpsx7j7v9y0x2vn66m732iidpxvdxbjn2kzva")
+                     (boost-patch
+                      ;; Fixed a missing include on POSIX systems that don't
+                      ;; support *at APIs:
+                      ;; https://github.com/boostorg/filesystem/issues/250
+                      "0004-filesystem-posix-fix-no-at-apis-missing-include.patch" version
+                      "09k8k3b1306jkjls12wfghj820n828j6aaxzmcr0wpnjhp8fzi1v")))
               (sha256
                (base32
-                "0fggarccddj6q4ifj3kn7g565rbhn4ia1vd45fxb7y57a6fmhpa7"))))
+                "1h00qp4z5k6lfz310xjwsmqs8fwxi6ngas51169cafz4h9fmc68y"))))
     (build-system gnu-build-system)
     (inputs
      (append
-- 
2.37.2





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#57492: [PATCH core-updates v2] gnu: boost: Update to 1.80.0.
  2022-08-31 13:43 ` [bug#57492] [PATCH core-updates v2] " Greg Hogan
@ 2022-09-01 21:00   ` Marius Bakke
  0 siblings, 0 replies; 5+ messages in thread
From: Marius Bakke @ 2022-09-01 21:00 UTC (permalink / raw)
  To: Greg Hogan, 57492-done; +Cc: Greg Hogan

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

Greg Hogan <code@greghogan.com> skriver:

> * gnu/packages/boost.scm (boost): Update to 1.80.0.
> [source](patches): Add new and remove old upstream patches.

Applied, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-09-01 21:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-30 16:36 [bug#57492] [PATCH core-updates] gnu: boost: Update to 1.80.0 Greg Hogan
2022-08-30 19:50 ` Maxime Devos
2022-08-30 20:15   ` Greg Hogan
2022-08-31 13:43 ` [bug#57492] [PATCH core-updates v2] " Greg Hogan
2022-09-01 21:00   ` bug#57492: " Marius Bakke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).