From: paul <goodoldpaul@autistici.org>
To: Sarah Morgensen <iskarian@mgsn.dev>
Cc: 49281@debbugs.gnu.org
Subject: [bug#49281] Add dynaconf
Date: Mon, 2 Aug 2021 20:13:20 +0200 [thread overview]
Message-ID: <ec86a3e7-33c2-9451-fc5e-39af713f01c9@autistici.org> (raw)
In-Reply-To: <86im11r1yr.fsf@mgsn.dev>
Dear Sarah,
thank you for your suggestions :D , I believe I addressed most of them.
On 7/23/21 8:14 AM, Sarah Morgensen wrote:
> * Unvendoring or otherwise removing files from sources is typically done
> with a snippet in the origin rather than a patch, as it's much smaller
> and doesn't break when updating. It might look like (untested):
>
> (origin
> ...
> (modules '((guix build utils)))
> (snippet
> '(begin
> ;; Remove vendored dependencies
> (let ((unvendor '("click" "dotenv" "ruamel" "toml")))
> (with-directory-excursion "dynaconf/vendor"
> (for-each delete-file-recursively unvendor))
> (with-directory-excursion "dynaconf/vendor_src"
> (for-each delete-file-recursively unvendor))))))
>
> You'll still have to have the edits to dynaconf as a patch, of course.
It make much more sense, now the patch just changes the imports and the
actual removal is up to the snippet.
> * You've still included a python-box package despite none of the
> packages in your patch using it.
Yes I included it while unvendoring, I figured since the tests pass it
would still make sense to upstream it. Should I remove it?
> * pep8-naming has released 12.0.0, and tests pass :)
Fixed, thanks !
> * Some of your patches no longer apply on master, and you should rebase
> them before sending a revised patchset. Consider using the `--base`
> option with format-patch, which helps git know what commit the patch
> is based on when applying.
I rebased and I'll send the patches with
--base=f12a35cfa22092a7e3157c94abfef8335f86ac1c .
Thank you for your help!
Cheers,
giacomo
next prev parent reply other threads:[~2021-08-02 18:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 22:38 [bug#49281] Add dynaconf paul
2021-06-29 22:42 ` [bug#49281] [PATCH 1/7] gnu: Add python-flake8-debugger Giacomo Leidi
2021-06-29 22:42 ` [bug#49281] [PATCH 2/7] gnu: Add python-flake8-todo Giacomo Leidi
2021-06-29 22:42 ` [bug#49281] [PATCH 3/7] gnu: Add python-dotenv Giacomo Leidi
2021-06-29 22:42 ` [bug#49281] [PATCH 4/7] gnu: Add python-box Giacomo Leidi
2021-06-29 22:42 ` [bug#49281] [PATCH 5/7] gnu: python-ruamel.yaml: Update to 0.17.10 Giacomo Leidi
2021-06-29 22:42 ` [bug#49281] [PATCH 6/7] gnu: Add python-pep8-naming Giacomo Leidi
2021-06-29 22:42 ` [bug#49281] [PATCH 7/7] gnu: Add dynaconf Giacomo Leidi
2021-07-23 6:14 ` [bug#49281] " Sarah Morgensen
2021-08-02 18:13 ` paul [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-08-02 18:13 [bug#49834] [PATCH 1/7] gnu: Add python-flake8-debugger Giacomo Leidi
2021-08-02 18:13 ` [bug#49833] [PATCH 3/7] gnu: Add python-dotenv Giacomo Leidi
2021-08-04 18:35 ` [bug#49281] Add dynaconf Sarah Morgensen
2021-08-02 18:13 ` [bug#49835] [PATCH 7/7] gnu: " Giacomo Leidi
2021-08-04 19:13 ` [bug#49281] " Sarah Morgensen
2021-08-04 18:26 ` Sarah Morgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec86a3e7-33c2-9451-fc5e-39af713f01c9@autistici.org \
--to=goodoldpaul@autistici.org \
--cc=49281@debbugs.gnu.org \
--cc=iskarian@mgsn.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).