From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0BcBMAU2CGHoQQEAgWs5BA (envelope-from ) for ; Mon, 02 Aug 2021 20:14:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 6Du/KwU2CGGIBAAA1q6Kng (envelope-from ) for ; Mon, 02 Aug 2021 18:14:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 46DBAB03B for ; Mon, 2 Aug 2021 20:14:29 +0200 (CEST) Received: from localhost ([::1]:33772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAcSK-0005W0-5Q for larch@yhetil.org; Mon, 02 Aug 2021 14:14:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAcRu-0005Vj-Mp for guix-patches@gnu.org; Mon, 02 Aug 2021 14:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55908) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mAcRu-0006TT-F2 for guix-patches@gnu.org; Mon, 02 Aug 2021 14:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mAcRu-0000AH-C6 for guix-patches@gnu.org; Mon, 02 Aug 2021 14:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49281] Add dynaconf Resent-From: paul Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Aug 2021 18:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49281 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Sarah Morgensen Cc: 49281@debbugs.gnu.org Received: via spool by 49281-submit@debbugs.gnu.org id=B49281.1627928016592 (code B ref 49281); Mon, 02 Aug 2021 18:14:02 +0000 Received: (at 49281) by debbugs.gnu.org; 2 Aug 2021 18:13:36 +0000 Received: from localhost ([127.0.0.1]:39221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mAcRU-00009T-21 for submit@debbugs.gnu.org; Mon, 02 Aug 2021 14:13:36 -0400 Received: from latitanza.investici.org ([82.94.249.234]:56515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mAcRR-00009F-3I for 49281@debbugs.gnu.org; Mon, 02 Aug 2021 14:13:34 -0400 Received: from mx3.investici.org (unknown [127.0.0.1]) by latitanza.investici.org (Postfix) with ESMTP id 4GdmMv3x41zGp6p; Mon, 2 Aug 2021 18:13:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1627928011; bh=edZNkMdDpmmBWY20uNfrYp9x4xfuAjjAKsmBcaYyIec=; h=To:Cc:References:From:Subject:Date:In-Reply-To:From; b=Edr98BtwofGLH+o52miMxAMPxttTZXieBK3jSynKEx8GBhE/MewgMvjzde+k9tFKz 1/JwN/OCw9O1yOKl7SxxU3o/KB/CcUVpOxzzFMKXyXnXkV3wiPQy81qToB5onhEsgq pd/8yrqqmQHvY7fussQBtMgy/0ayh2+EMu+Rkjz8= Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234]) (Authenticated sender: goodoldpaul@autistici.org) by localhost (Postfix) with ESMTPSA id 4GdmMv3L3hzGp5p; Mon, 2 Aug 2021 18:13:31 +0000 (UTC) References: <86im11r1yr.fsf@mgsn.dev> From: paul Message-ID: Date: Mon, 2 Aug 2021 20:13:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.12.0 MIME-Version: 1.0 In-Reply-To: <86im11r1yr.fsf@mgsn.dev> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627928069; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=edZNkMdDpmmBWY20uNfrYp9x4xfuAjjAKsmBcaYyIec=; b=aROhotRm8ZerT7piCVW/6eizjXgh3eM5LF3B7zJR04JwCXiBtHRWgfU4Kug4PmbmFZu2nO 3XLVk89gvOYIbkD4GVBJzAKEWXYYx1eMerXD7MlV3flSdEpcHQScwj0WXwVBa+IlwLY7BH P0sGZJyso519Zr/yb0EZzAGkiVCBcWB2EV1DeOzeA710hTD2fkO7T/HuI+qu6bROPwp9AV LOUJtTRbsrepz2rC+o5eqtlbb2wZGrr/Zmohby2vo5gDwKStUchH8MWwbzaUhU/KmPvfeS Kr8KcHVcaiT2gTb76K71ZnYBYOJ1DBQBG6s8OhjrBZj6UwKdMLEsgNh6OMUvZA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627928069; a=rsa-sha256; cv=none; b=Ph77FYcS2Q3A//by7Objt18t6931VKJIb1B22+pGbWZc4+IF5ZGHxRnib6Bk5qLLf2ihbr lzPh9FRVIqcoS/JWjBq+xCllZMIQ1ZwTnhh5PUeVGkZ38MdqqdcMSvVy87WTiutCmHme3i b7W7UZYzdNnDifq1lAC18jwjelQPdq2ypC6A2yGsN4VoEft2QEh3BWBsrmBnl9u9O7VKcv r7MAvEWuPcMzWo41V9qkzOlVSCTN2rtaxNzkKlU9pk1V9hRLc6yjGxpuEWmkQ7tMWbfi61 0D3mQESCQy7ioiREF7ZpxVT0FlAnNr9GhXNnAQdHV0n93ViFRkV/EM+Nrw3iSQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=autistici.org header.s=stigmate header.b=Edr98Btw; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=autistici.org header.s=stigmate header.b=Edr98Btw; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 46DBAB03B X-Spam-Score: -1.42 X-Migadu-Scanner: scn1.migadu.com X-TUID: 78cWTekA7eEa Dear Sarah, thank you for your suggestions :D , I believe I addressed most of them. On 7/23/21 8:14 AM, Sarah Morgensen wrote: > * Unvendoring or otherwise removing files from sources is typically don= e > with a snippet in the origin rather than a patch, as it's much small= er > and doesn't break when updating. It might look like (untested): > > (origin > ... > (modules '((guix build utils))) > (snippet > '(begin > ;; Remove vendored dependencies > (let ((unvendor '("click" "dotenv" "ruamel" "toml"))) > (with-directory-excursion "dynaconf/vendor" > (for-each delete-file-recursively unvendor)) > (with-directory-excursion "dynaconf/vendor_src" > (for-each delete-file-recursively unvendor)))))) > > You'll still have to have the edits to dynaconf as a patch, of cours= e. It make much more sense, now the patch just changes the imports and the=20 actual removal is up to the snippet. > * You've still included a python-box package despite none of the > packages in your patch using it. Yes I included it while unvendoring, I figured since the tests pass it=20 would still make sense to upstream it. Should I remove it? > * pep8-naming has released 12.0.0, and tests pass :) Fixed, thanks ! > * Some of your patches no longer apply on master, and you should rebase= > them before sending a revised patchset. Consider using the `--base` > option with format-patch, which helps git know what commit the patch= > is based on when applying. I rebased and I'll send the patches with=20 --base=3Df12a35cfa22092a7e3157c94abfef8335f86ac1c . Thank you for your help! Cheers, giacomo