unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#56795] [PATCH core-updates] gnu: texlive-xcolor: Fix merge.
@ 2022-07-27 14:18 Greg Hogan
  2022-09-01 20:57 ` bug#56795: " Marius Bakke
  0 siblings, 1 reply; 2+ messages in thread
From: Greg Hogan @ 2022-07-27 14:18 UTC (permalink / raw)
  To: 56795; +Cc: Greg Hogan

* gnu/packages/tex.scm (texlive-xcolor)[arguments]<#:phases>: Restore
code from commit 5e796bfc22076a1126beaa853d9cac16f5c9a23d which was
reverted by the merge commit 8c3e9da13a3c92a7db308db8c0d81cb474ad7799.
---
 gnu/packages/tex.scm | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm
index 3ad16a1b46..482f18505c 100644
--- a/gnu/packages/tex.scm
+++ b/gnu/packages/tex.scm
@@ -3391,14 +3391,21 @@ (define-public texlive-xcolor
           #~(modify-phases #$phases
               (add-after 'unpack 'chdir
                 (lambda _ (chdir "source/latex/xcolor") #t))
-              (add-after 'install 'move-files
-                (lambda* (#:key outputs #:allow-other-keys)
-                  (let ((share (string-append (assoc-ref outputs "out")
-                                              "/share/texmf-dist")))
-                    (mkdir-p (string-append share "/dvips/xcolor"))
-                    (rename-file (string-append share "/tex/latex/xcolor/xcolor.pro")
-                                 (string-append share "/dvips/xcolor/xcolor.pro"))
-                    #t)))))))
+              (replace 'copy-files
+                (lambda* (#:key inputs outputs #:allow-other-keys)
+                  (let ((origin (assoc-ref inputs "source"))
+                        (source (string-append #$output
+                                               "/share/texmf-dist/source"))
+                        (doc (string-append #$output:doc
+                                            "/share/texmf-dist/doc")))
+                    (copy-recursively (string-append origin "/source") source)
+                    (copy-recursively (string-append origin "/doc") doc)
+                    (let ((share (string-append #$output
+                                                "/share/texmf-dist")))
+                      (mkdir-p (string-append share "/dvips/xcolor"))
+                      (rename-file
+                       (string-append share "/tex/latex/xcolor/xcolor.pro")
+                       (string-append share "/dvips/xcolor/xcolor.pro"))))))))))
       ;; TODO: Propagate texlive-hyperref and many others in the next rebuild
       ;; cycle.  Grep for '\usepackage' to see what packages it requires.
       ;; (propagated-inputs (list texlive-hyperref ...))
-- 
2.37.1





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#56795: [PATCH core-updates] gnu: texlive-xcolor: Fix merge.
  2022-07-27 14:18 [bug#56795] [PATCH core-updates] gnu: texlive-xcolor: Fix merge Greg Hogan
@ 2022-09-01 20:57 ` Marius Bakke
  0 siblings, 0 replies; 2+ messages in thread
From: Marius Bakke @ 2022-09-01 20:57 UTC (permalink / raw)
  To: Greg Hogan, 56795-close; +Cc: Greg Hogan

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

Greg Hogan <code@greghogan.com> skriver:

> * gnu/packages/tex.scm (texlive-xcolor)[arguments]<#:phases>: Restore
> code from commit 5e796bfc22076a1126beaa853d9cac16f5c9a23d which was
> reverted by the merge commit 8c3e9da13a3c92a7db308db8c0d81cb474ad7799.

Nice catch!  Unfortunately I did not see this patch before going on the
same debugging journey and arriving at the exact same solution in
121f6e0b0c45dba24301fbd405d07123e82c2de6.

Sorry for the duplicate work.  :-(

By the way, you have been around for a while now and generally produce
high quality patches.  Consider applying for commit access.  :-)

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-01 20:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-27 14:18 [bug#56795] [PATCH core-updates] gnu: texlive-xcolor: Fix merge Greg Hogan
2022-09-01 20:57 ` bug#56795: " Marius Bakke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).