From: fesoj000 <fesoj000@gmail.com>
To: Maxime Devos <maximedevos@telenet.be>, 54309@debbugs.gnu.org
Subject: [bug#54309] [PATCH] services: auditd: use exclusive log directory for auditd
Date: Sun, 20 Mar 2022 21:22:11 +0100 [thread overview]
Message-ID: <dce285c1-3d60-31ab-8f5a-1389c42080c2@gmail.com> (raw)
In-Reply-To: <80cc8802439c49138638dee6d4fb9015723f9727.camel@telenet.be>
On 3/20/22 12:13 AM, Maxime Devos wrote:
> fesoj000 schreef op za 19-03-2022 om 12:34 [+0100]:
>> + (let* ((previous-umask (umask #o077)))
>> + (mkdir-p "/var/log/audit")
>> + (umask previous-umask)))))
>
> I cannot recommend this, what if 'mkdir-p' throws an exception?
> That might cause problems. Or maybe not, but it would require
> some analysis that can be avoided with 'mkdir-p/perms'.
Hm, but i still have to set umask to prevent TOCTOU, the
implementation of 'mkdir-p/perms' does not take care of that.
BR
next prev parent reply other threads:[~2022-03-20 20:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 19:21 [bug#54309] [PATCH] services: auditd: use exclusive log directory for auditd fesoj000
2022-03-09 19:36 ` Maxime Devos
2022-03-09 20:44 ` fesoj000
2022-03-09 21:00 ` fesoj000
2022-03-10 7:12 ` Liliana Marie Prikler
2022-03-10 10:36 ` fesoj000
2022-03-10 16:29 ` fesoj000
2022-03-18 19:17 ` [bug#54309] What is the process from here? fesoj000
2022-03-18 20:06 ` Liliana Marie Prikler
2022-03-18 21:48 ` fesoj000
2022-03-18 22:36 ` Liliana Marie Prikler
2022-03-19 11:10 ` fesoj000
2022-03-19 23:09 ` Maxime Devos
2022-03-22 16:50 ` fesoj000
2022-03-22 20:06 ` Liliana Marie Prikler
2022-03-19 11:34 ` [bug#54309] [PATCH] services: auditd: use exclusive log directory for auditd fesoj000
2022-03-19 23:13 ` Maxime Devos
2022-03-20 20:22 ` fesoj000 [this message]
2022-03-20 20:30 ` Maxime Devos
2022-03-20 20:35 ` Maxime Devos
2022-03-23 20:22 ` [bug#54309] [PATCHv2] " fesoj000
2022-03-23 20:39 ` [bug#54309] [PATCHv3] " fesoj000
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dce285c1-3d60-31ab-8f5a-1389c42080c2@gmail.com \
--to=fesoj000@gmail.com \
--cc=54309@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).