unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christina O'Donnell <cdo@mutix.org>
To: 57021@debbugs.gnu.org, Mathieu Laparie <mlaparie@disr.it>
Cc: othacehe@gnu.org
Subject: [bug#57021] [PATCH] gnu: packages: Add nmail.
Date: Sun, 21 Apr 2024 15:03:05 +0100	[thread overview]
Message-ID: <db8a5d71-70ce-650c-4209-ecdeb4d97a30@mutix.org> (raw)
In-Reply-To: <d4bd4555b09366c28463643e16b272ad7ca4eed8.1659826927.git.matf@disr.it>

Hi Mathieu Laparie,

Thank you for your patch. Sorry it has taken so long to get to it.

This patch looks good. It applies and runs and lints with few issues.

I've re-rolled a version 9 patch on the latest master branch, updating 
the version and changing the formatting slightly.

Regarding the second diff, I'm not sure what the justification is for 
changing cyrus-sasl in the same patch, so I've removed that part. If 
that change needs to happen then I would think it would make more sense 
as a separate patch.

Kind regards,
Christina





  parent reply	other threads:[~2024-04-21 14:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-06 23:02 [bug#57021] [PATCH] gnu: packages: Add nmail M
2022-08-12  8:53 ` Mathieu Othacehe
2022-08-16 13:38   ` Mathieu
2022-09-11 21:41 ` [bug#57021] [PATCH v3] gnu: " M
2022-09-11 21:46   ` Mathieu
2022-09-11 21:56   ` Mathieu
2022-09-11 22:01 ` [bug#57021] [PATCH v4] " M
2022-09-15 12:24 ` [bug#57021] [PATCH v5] " M
2022-09-15 12:26 ` [bug#57021] [PATCH v6] Enable login in cyrus-sasl, as Exchange servers expect it M
2022-09-15 12:37 ` [bug#57021] [PATCH v7] gnu: cyrus-sasl: Enable login M
2022-09-16  9:22 ` [bug#57021] [PATCH v7 1/2] gnu: Add nmail M
2022-09-16  9:22   ` [bug#57021] [PATCH v7 2/2] gnu: cyrus-sasl: Enable login M
2022-09-24 13:55 ` [bug#57021] [PATCH v8 1/2] gnu: Add nmail M
2022-09-24 13:55   ` [bug#57021] [PATCH v8 2/2] gnu: cyrus-sasl: Enable login M
2024-04-21 13:49 ` [bug#57021] [PATCH v9] gnu: Add nmail Christina O'Donnell
2024-04-21 14:03 ` Christina O'Donnell [this message]
2024-04-22  9:21   ` [bug#57021] [PATCH] gnu: packages: " Mathieu
2024-04-22 10:19     ` Christina
2024-04-23 13:45     ` Christopher Baines
2024-04-22 11:18 ` [bug#57021] [PATCH v10] gnu: " Christina O'Donnell
2024-04-23 13:47   ` bug#57021: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db8a5d71-70ce-650c-4209-ecdeb4d97a30@mutix.org \
    --to=cdo@mutix.org \
    --cc=57021@debbugs.gnu.org \
    --cc=mlaparie@disr.it \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).