From: Mathieu Othacehe <othacehe@gnu.org>
To: M <matf@disr.it>
Cc: 57021@debbugs.gnu.org
Subject: [bug#57021] [PATCH] gnu: packages: Add nmail.
Date: Fri, 12 Aug 2022 10:53:33 +0200 [thread overview]
Message-ID: <8735e1267m.fsf@gnu.org> (raw)
In-Reply-To: <d4bd4555b09366c28463643e16b272ad7ca4eed8.1659826927.git.matf@disr.it> (M.'s message of "Sun, 7 Aug 2022 01:02:07 +0200")
Hello,
> * gnu/packages/nmail.scm: Reorder module imports. Remove
> duplicate imports.
> (nmail): New variable. Fix style.
Thanks for this first contribution. As you are adding a new package, the
preferred way to proceed is to amend your first patch with those changes
and submit a new revision (v2).
The module re-ordering stuff should also be part of a new patch. In
short, we would expect something like:
* gnu: Reorder mail module imports.
* gnu: nmail: New variable.
Do you think you could send those two patches in a v3? Don't hesitate to
ask for guidance here or on IRC if I'm unclear.
Mathieu
next prev parent reply other threads:[~2022-08-12 8:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-06 23:02 [bug#57021] [PATCH] gnu: packages: Add nmail M
2022-08-12 8:53 ` Mathieu Othacehe [this message]
2022-08-16 13:38 ` Mathieu
2022-09-11 21:41 ` [bug#57021] [PATCH v3] gnu: " M
2022-09-11 21:46 ` Mathieu
2022-09-11 21:56 ` Mathieu
2022-09-11 22:01 ` [bug#57021] [PATCH v4] " M
2022-09-15 12:24 ` [bug#57021] [PATCH v5] " M
2022-09-15 12:26 ` [bug#57021] [PATCH v6] Enable login in cyrus-sasl, as Exchange servers expect it M
2022-09-15 12:37 ` [bug#57021] [PATCH v7] gnu: cyrus-sasl: Enable login M
2022-09-16 9:22 ` [bug#57021] [PATCH v7 1/2] gnu: Add nmail M
2022-09-16 9:22 ` [bug#57021] [PATCH v7 2/2] gnu: cyrus-sasl: Enable login M
2022-09-24 13:55 ` [bug#57021] [PATCH v8 1/2] gnu: Add nmail M
2022-09-24 13:55 ` [bug#57021] [PATCH v8 2/2] gnu: cyrus-sasl: Enable login M
2024-04-21 13:49 ` [bug#57021] [PATCH v9] gnu: Add nmail Christina O'Donnell
2024-04-21 14:03 ` [bug#57021] [PATCH] gnu: packages: " Christina O'Donnell
2024-04-22 9:21 ` Mathieu
2024-04-22 10:19 ` Christina
2024-04-23 13:45 ` Christopher Baines
2024-04-22 11:18 ` [bug#57021] [PATCH v10] gnu: " Christina O'Donnell
2024-04-23 13:47 ` bug#57021: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735e1267m.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=57021@debbugs.gnu.org \
--cc=matf@disr.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).