unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#42280] [PATCH 1/2] gnu: Add bshapr.
@ 2020-07-08 21:36 Alexandros Theodotou
  2020-07-20 22:17 ` bug#42280: " Marius Bakke
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandros Theodotou @ 2020-07-08 21:36 UTC (permalink / raw)
  To: 42280


[-- Attachment #1.1: Type: text/plain, Size: 190 bytes --]

Hi,

These patches add bshapr and bjumblr, 2 LV2 plugins. I used inheritance
from bsequencer since they are by the same author and use the same
build procedure/system.

Thanks,
Alex

[-- Attachment #1.2: 0002-gnu-Add-bjumblr.patch --]
[-- Type: text/x-patch, Size: 1543 bytes --]

From 2a7fcaa98cc652a30f9d207509c9b52336363089 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Wed, 8 Jul 2020 22:32:39 +0100
Subject: [PATCH 2/2] gnu: Add bjumblr.

* gnu/packages/music.scm (bjumblr): New variable.
---
 gnu/packages/music.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index f12d2fb8ee..0b8b8df226 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -1316,6 +1316,31 @@ B.Choppr is the successor of B.Slizr.")
     (home-page "https://github.com/sjaehn/BShapr")
     (license license:gpl3+)))
 
+(define-public bjumblr
+  (package
+    (inherit bsequencer)
+    (name "bjumblr")
+    (version "0.2")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/sjaehn/BJumblr.git")
+               (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "14z8113zkwykbhm1a8h2xs972dgifvlfij92b08jckyc7cbz84ys"))))
+    (inputs
+      `(("cairo", cairo)
+        ("libsndfile", libsndfile)
+        ("lv2", lv2)))
+    (synopsis "Pattern-controlled audio stream/sample re-sequencer LV2 plugin")
+    (description "B.Jumblr is a pattern-controlled audio stream / sample
+re-sequencer LV2 plugin.")
+    (home-page "https://github.com/sjaehn/BJumblr")
+    (license license:gpl3+)))
+
 (define-public solfege
   (package
     (name "solfege")
-- 
2.27.0


[-- Attachment #1.3: 0001-gnu-Add-bshapr.patch --]
[-- Type: text/x-patch, Size: 1367 bytes --]

From 24e3da79b8adf2607a88430676b9be1ab1802e84 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Wed, 8 Jul 2020 22:31:48 +0100
Subject: [PATCH 1/2] gnu: Add bshapr.

* gnu/packages/music.scm (bshapr): New variable.
---
 gnu/packages/music.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 490f010c4a..f12d2fb8ee 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -1296,6 +1296,26 @@ B.Choppr is the successor of B.Slizr.")
     (home-page "https://github.com/sjaehn/BChoppr")
     (license license:gpl3+)))
 
+(define-public bshapr
+  (package
+    (inherit bsequencer)
+    (name "bshapr")
+    (version "0.8")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/sjaehn/BShapr.git")
+               (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "0jlq5rjicc4fxlpk869dg0l5bwwz8k9aj2wfk9v89b0qw8l8kaxl"))))
+    (synopsis "Beat/envelope shaper LV2 plugin")
+    (description "B.Shapr is a beat/envelope shaper LV2 plugin")
+    (home-page "https://github.com/sjaehn/BShapr")
+    (license license:gpl3+)))
+
 (define-public solfege
   (package
     (name "solfege")
-- 
2.27.0


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#42280: [PATCH 1/2] gnu: Add bshapr.
  2020-07-08 21:36 [bug#42280] [PATCH 1/2] gnu: Add bshapr Alexandros Theodotou
@ 2020-07-20 22:17 ` Marius Bakke
  0 siblings, 0 replies; 2+ messages in thread
From: Marius Bakke @ 2020-07-20 22:17 UTC (permalink / raw)
  To: Alexandros Theodotou, 42280-done

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

Alexandros Theodotou <alex@zrythm.org> writes:

> Hi,
>
> These patches add bshapr and bjumblr, 2 LV2 plugins. I used inheritance
> from bsequencer since they are by the same author and use the same
> build procedure/system.

Inheritance is a double-edged sword: someone making changes to
bsequencer may not realize that it affects these two packages.  I've
ignored that for now, but would not mind a patch to 'un-inherit' them.

[...]

> * gnu/packages/music.scm (bjumblr): New variable.

[...]
  
> +(define-public bjumblr
> +  (package
> +    (inherit bsequencer)
> +    (name "bjumblr")
> +    (version "0.2")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               (url "https://github.com/sjaehn/BJumblr.git")

I removed the .git suffix from these patches, as well as the ninja2
patch earlier, ref commit b0e7b6992f3f845e83cfbca4d700b51dba50b4d5.

> +               (commit (string-append "v" version))))
> +        (file-name (git-file-name name version))
> +        (sha256
> +          (base32
> +            "14z8113zkwykbhm1a8h2xs972dgifvlfij92b08jckyc7cbz84ys"))))

Also, indentation is off for both patches (but fixed!).

[...]

> +    (description "B.Shapr is a beat/envelope shaper LV2 plugin")

Missing punctuation (also fixed).  :-)

Applied!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-20 22:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-08 21:36 [bug#42280] [PATCH 1/2] gnu: Add bshapr Alexandros Theodotou
2020-07-20 22:17 ` bug#42280: " Marius Bakke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).