From: Bruno Victal <mirai@makinata.eu>
To: Saku Laesvuori <saku@laesvuori.fi>
Cc: 62292@debbugs.gnu.org
Subject: [bug#62292] [PATCH] gnu: Add kitsas
Date: Mon, 20 Mar 2023 18:09:03 +0000 [thread overview]
Message-ID: <d295a68e-f294-a967-1c85-062c8d03c017@makinata.eu> (raw)
In-Reply-To: <20230320105602.8040-1-saku@laesvuori.fi>
Hi Saku,
On 2023-03-20 10:56, Saku Laesvuori via Guix-patches via wrote:
>
> +(define-public kitsas
> + (package
> + (name "kitsas")
> + (version "4.0.3")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/artoh/kitupiikki/archive/refs/tags/v"
> + version ".tar.gz"))
Use git-fetch instead.
GitHub tarballs are not stable and their hash can change in the future.
> + (sha256
> + (base32
> + "1a15axggskrvjb3r3yyr3kdxyzcygxjj756b6dzpwlca5g1l7x5w"))))
> + (build-system qt-build-system)
> + (inputs (list qtbase-5 libzip poppler-qt5 qtsvg-5))
> + (arguments
[...]
> + '(#:test-target "check"
> + #:tests? #f
If the tests don't work, leave a comment stating such.
It's worth trying to get them working if possible though.
[...]
> + #:phases (modify-phases %standard-phases
> + (replace 'configure
> + (lambda* _
> + (invoke "qmake" "kitsasproject.pro" "CONFIG+=release")))
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (install-file "kitsas/kitsas"
> + (string-append out "/bin/"))
> + (install-file "kitsas.png"
> + (string-append out "/share/icons/"))
> + (install-file "kitsas.desktop"
> + (string-append out
> + "/share/applications/"))))))))
Prefer list to ' and use G-Expressions here, i.e.
(arguments
(list
#:tests? #f ;; comment here...
#:phases
#~(modify-phases %standard-phases
(replace 'install
(lambda* _
(install-file "kitsas/kitsas" (string-append #$output "/bin/"))
... )))))
> + (home-page "https://kitsas.fi")
> + (synopsis "Finnish bookkeeping software for small organisations")
> + (description
> + "The software is in Finnish only.
> +
> + Finnish free software accounting program with the following goals and features:
> +
> + @itemize @bullet
> + @item
> + Ease of use
> + @item
> + Digital management of documents
> + @item
> + Creating a digital archive
> + @item
> + Built-in invoicing
> + @item
> + Creating reports
> + @end itemize")
You can collapse this into:
@itemize @bullet
@item Ease of use
@item Digital management of documents
...
@end itemize
> + (license license:gpl3)))
> + ; GPL3 with additional terms:
> + ; - Modified versions of this software should be clearly mentioned as modified
> + ; - Kitsas Oy will not support any modified version of this software
> + ; - The name Kitsas Oy should not be used in any modified version
Move this comment into the package definition.
Cheers,
Bruno
next prev parent reply other threads:[~2023-03-20 18:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 10:56 [bug#62292] [PATCH] gnu: Add kitsas Saku Laesvuori via Guix-patches via
2023-03-20 18:09 ` Bruno Victal [this message]
2023-03-22 12:54 ` [bug#62292] [PATCH v2] " Saku Laesvuori via Guix-patches via
2023-04-17 21:29 ` bug#62292: [PATCH] " Ludovic Courtès
2023-04-18 14:51 ` [bug#62292] " Saku Laesvuori via Guix-patches via
2023-04-20 10:30 ` Ludovic Courtès
2023-04-20 11:38 ` Saku Laesvuori via Guix-patches via
2023-04-20 12:37 ` Saku Laesvuori via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d295a68e-f294-a967-1c85-062c8d03c017@makinata.eu \
--to=mirai@makinata.eu \
--cc=62292@debbugs.gnu.org \
--cc=saku@laesvuori.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).