From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id gFFkFbKiGGQdfgAASxT56A (envelope-from ) for ; Mon, 20 Mar 2023 19:15:14 +0100 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id cGxZFbKiGGQTIwAAauVa8A (envelope-from ) for ; Mon, 20 Mar 2023 19:15:14 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id 0BD7337087 for ; Mon, 20 Mar 2023 19:15:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peK2F-0004W4-VD; Mon, 20 Mar 2023 14:15:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peK2B-0004VK-Kb for guix-patches@gnu.org; Mon, 20 Mar 2023 14:15:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peK2B-00027X-4i for guix-patches@gnu.org; Mon, 20 Mar 2023 14:15:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1peK2A-0007KZ-Vu for guix-patches@gnu.org; Mon, 20 Mar 2023 14:15:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62292] [PATCH] gnu: Add kitsas Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 Mar 2023 18:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62292 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Saku Laesvuori Cc: 62292@debbugs.gnu.org Received: via spool by 62292-submit@debbugs.gnu.org id=B62292.167933607428120 (code B ref 62292); Mon, 20 Mar 2023 18:15:02 +0000 Received: (at 62292) by debbugs.gnu.org; 20 Mar 2023 18:14:34 +0000 Received: from localhost ([127.0.0.1]:56749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peK1h-0007JU-Te for submit@debbugs.gnu.org; Mon, 20 Mar 2023 14:14:34 -0400 Received: from smtpmciv1.myservices.hosting ([185.26.107.237]:55926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peK1f-0007JI-Ux for 62292@debbugs.gnu.org; Mon, 20 Mar 2023 14:14:32 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpmciv1.myservices.hosting (Postfix) with ESMTP id 9EC152080C; Mon, 20 Mar 2023 19:14:29 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 67F3A8009A; Mon, 20 Mar 2023 19:09:08 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id K7Mk7iJ14tbe; Mon, 20 Mar 2023 19:09:08 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id D1F9480079; Mon, 20 Mar 2023 19:09:07 +0100 (CET) Message-ID: Date: Mon, 20 Mar 2023 18:09:03 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US References: <20230320105602.8040-1-saku@laesvuori.fi> From: Bruno Victal In-Reply-To: <20230320105602.8040-1-saku@laesvuori.fi> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679336114; a=rsa-sha256; cv=none; b=gRzg1tYlkNUqlOwynuUgeGVglavlI0azwnikVpTKpGWGq2/cYu4Xe+GcG0bklhdAUOEY2T oKkStyowqlA7211h7L9NpE1/sjvSJNYLceMcIMKynhmE5ZUJTSVNfMT75Qv+OEknXAlw8o Lio5TBGFhSejgUeA39E1GMFzwQ4azpZds+kokWnA3I6Prk9tAa9Yp3D6i6HGzGLcY1K806 mrOcs8NH8HE2J27zzBm6UldPooyIbFy1jSXQQgzlXXUvGQSWCvP9PtFY9VoMilfgSqT1Al BjmPBI1wO3lCFyuwRRRtEUBJjQnOFj+wxLPdELzrr4GfMFW597EQD4BjJmn2FQ== ARC-Authentication-Results: i=1; aspmx2.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx2.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679336114; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=1mkWp9c1K5/xpORaxgLppvYfOQ02FLHnzRjVmxmgH0Q=; b=fxw6Ic18bJXkrbt+af+Ulslfd8kiDz/+vEEYRIVj1HMNAZp+MB3DLcNsrrRTKdjgTLPZTw CwU9IhGbPsQkkuidPPb91B2+XkhWZFe3GV2Ax2IGAXzyUcP3RDXoYhwg57GTQX1XrBUuFz QKvvlUlMqobI5D7sqs7zGDE4TlBWZgdrambFNKy05VrSF/UW7KpPwxB+992/wH+48/aY3P LGPTENPQzbCfF75GekounALDr/U40cU3krJdPpgIKqyILl1c5V1S9/q5tL+6LwlBdy39k4 OxOx+jPpWAStGZq8UGzIZhgUUD2zE3i0ZW/4un3BmvanDnZFoGlEeP61q/8Kjw== X-Migadu-Spam-Score: -3.25 X-Spam-Score: -3.25 X-Migadu-Queue-Id: 0BD7337087 Authentication-Results: aspmx2.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx2.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-TUID: Iye66lhHvNV2 Hi Saku, On 2023-03-20 10:56, Saku Laesvuori via Guix-patches via wrote: > > +(define-public kitsas > + (package > + (name "kitsas") > + (version "4.0.3") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "https://github.com/artoh/kitupiikki/archive/refs/tags/v" > + version ".tar.gz")) Use git-fetch instead. GitHub tarballs are not stable and their hash can change in the future. > + (sha256 > + (base32 > + "1a15axggskrvjb3r3yyr3kdxyzcygxjj756b6dzpwlca5g1l7x5w")))) > + (build-system qt-build-system) > + (inputs (list qtbase-5 libzip poppler-qt5 qtsvg-5)) > + (arguments [...] > + '(#:test-target "check" > + #:tests? #f If the tests don't work, leave a comment stating such. It's worth trying to get them working if possible though. [...] > + #:phases (modify-phases %standard-phases > + (replace 'configure > + (lambda* _ > + (invoke "qmake" "kitsasproject.pro" "CONFIG+=release"))) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (install-file "kitsas/kitsas" > + (string-append out "/bin/")) > + (install-file "kitsas.png" > + (string-append out "/share/icons/")) > + (install-file "kitsas.desktop" > + (string-append out > + "/share/applications/")))))))) Prefer list to ' and use G-Expressions here, i.e. (arguments (list #:tests? #f ;; comment here... #:phases #~(modify-phases %standard-phases (replace 'install (lambda* _ (install-file "kitsas/kitsas" (string-append #$output "/bin/")) ... ))))) > + (home-page "https://kitsas.fi") > + (synopsis "Finnish bookkeeping software for small organisations") > + (description > + "The software is in Finnish only. > + > + Finnish free software accounting program with the following goals and features: > + > + @itemize @bullet > + @item > + Ease of use > + @item > + Digital management of documents > + @item > + Creating a digital archive > + @item > + Built-in invoicing > + @item > + Creating reports > + @end itemize") You can collapse this into: @itemize @bullet @item Ease of use @item Digital management of documents ... @end itemize > + (license license:gpl3))) > + ; GPL3 with additional terms: > + ; - Modified versions of this software should be clearly mentioned as modified > + ; - Kitsas Oy will not support any modified version of this software > + ; - The name Kitsas Oy should not be used in any modified version Move this comment into the package definition. Cheers, Bruno