unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 29660@debbugs.gnu.org
Subject: [bug#29660] [PATCH] gnu: notmuch: Move elisp directory and generate	autoloads.
Date: Wed, 13 Dec 2017 12:23:43 +0530	[thread overview]
Message-ID: <cu7tvwvm83s.fsf@systemreboot.net> (raw)
In-Reply-To: <87shcgvsd8.fsf@fastmail.com>

Marius Bakke <mbakke@fastmail.com> writes:

> Arun Isaac <arunisaac@systemreboot.net> writes:
>
>> * gnu/packages/mail.scm (notmuch)[arguments]: Move elisp files to
>> share/emacs/site-lisp/guix.d/notmuch-<version>.
>> Add make-autoloads phase.
>
> I had to dive into emacs-build-system to understand what this patch
> does.  AFAICT the purpose is to move the emacs files to a versioned
> subdirectory instead of "polluting" site-lisp

Yes, this is what the configure flags do. And, all other emacs packages
in Guix follow this convention. So, I thought it appropriate for notmuch
to do the same.

> and that's why the make-autoloads phase is necessary?

The make-autoloads phase generates autoloads for notmuch commands so
that the full elisp files are loaded only at the last moment when some
notmuch command is actually invoked. This reduces the emacs startup
time. Again, all emacs packages in Guix have autoloads.

> I haven't tested it, but LGTM.

Shall I push?

  reply	other threads:[~2017-12-13  6:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11 14:24 [bug#29660] [PATCH] gnu: notmuch: Move elisp directory and generate autoloads Arun Isaac
2017-12-12 16:11 ` Marius Bakke
2017-12-13  6:53   ` Arun Isaac [this message]
2017-12-13  7:16     ` Marius Bakke
2017-12-13 18:40       ` bug#29660: " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cu7tvwvm83s.fsf@systemreboot.net \
    --to=arunisaac@systemreboot.net \
    --cc=29660@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).