From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45288)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eP0vf-0002i7-FF
	for guix-patches@gnu.org; Wed, 13 Dec 2017 01:54:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eP0vb-0000hN-Bx
	for guix-patches@gnu.org; Wed, 13 Dec 2017 01:54:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:50658)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eP0vb-0000hH-8Q
	for guix-patches@gnu.org; Wed, 13 Dec 2017 01:54:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eP0vb-0003Q6-23
	for guix-patches@gnu.org; Wed, 13 Dec 2017 01:54:03 -0500
Subject: [bug#29660] [PATCH] gnu: notmuch: Move elisp directory and
	generate	autoloads.
Resent-Message-ID: <handler.29660.B29660.151314803613111@debbugs.gnu.org>
From: Arun Isaac <arunisaac@systemreboot.net>
In-Reply-To: <87shcgvsd8.fsf@fastmail.com>
References: <20171211142452.27889-1-arunisaac@systemreboot.net>
	<87shcgvsd8.fsf@fastmail.com>
Date: Wed, 13 Dec 2017 12:23:43 +0530
Message-ID: <cu7tvwvm83s.fsf@systemreboot.net>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 29660@debbugs.gnu.org

Marius Bakke <mbakke@fastmail.com> writes:

> Arun Isaac <arunisaac@systemreboot.net> writes:
>
>> * gnu/packages/mail.scm (notmuch)[arguments]: Move elisp files to
>> share/emacs/site-lisp/guix.d/notmuch-<version>.
>> Add make-autoloads phase.
>
> I had to dive into emacs-build-system to understand what this patch
> does.  AFAICT the purpose is to move the emacs files to a versioned
> subdirectory instead of "polluting" site-lisp

Yes, this is what the configure flags do. And, all other emacs packages
in Guix follow this convention. So, I thought it appropriate for notmuch
to do the same.

> and that's why the make-autoloads phase is necessary?

The make-autoloads phase generates autoloads for notmuch commands so
that the full elisp files are loaded only at the last moment when some
notmuch command is actually invoked. This reduces the emacs startup
time. Again, all emacs packages in Guix have autoloads.

> I haven't tested it, but LGTM.

Shall I push?