unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#65257] [PATCH] gnu: pcsc-lite: Update to 2.0.0.
@ 2023-08-12 23:57 Arjan Adriaanse
  2024-04-21 21:27 ` [bug#65257] [PATCH v2 0/1] gnu: pcsc-lite: Update to 2.1.0 Christina O'Donnell
  0 siblings, 1 reply; 4+ messages in thread
From: Arjan Adriaanse @ 2023-08-12 23:57 UTC (permalink / raw)
  To: 65257; +Cc: Arjan Adriaanse

* gnu/packages/security-token.scm (pcsc-lite): Update to 2.0.0.
---
 gnu/packages/security-token.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 3a0ed245ad..1a4a433554 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -236,14 +236,14 @@ (define-public softhsm
 (define-public pcsc-lite
   (package
     (name "pcsc-lite")
-    (version "1.9.8")
+    (version "2.0.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://pcsclite.apdu.fr/files/"
                                   "pcsc-lite-" version ".tar.bz2"))
               (sha256
                (base32
-                "12923c6l5qzga1xlcxvm0vzbqrxnxq1qgzlrxf2y5gpcaz2q0bah"))))
+                "0mlk32gpzmzjf5v8qn56lpyyba625jzzw8rkrmpyvr8h8nvf5hyn"))))
     (build-system gnu-build-system)
     (arguments
      `(#:configure-flags '("--enable-usbdropdir=/var/lib/pcsc/drivers"

base-commit: eb25c2b3e204a36a97ec724defe8930757ab83c0
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#65257] [PATCH v2 0/1] gnu: pcsc-lite: Update to 2.1.0.
  2023-08-12 23:57 [bug#65257] [PATCH] gnu: pcsc-lite: Update to 2.0.0 Arjan Adriaanse
@ 2024-04-21 21:27 ` Christina O'Donnell
  2024-04-21 21:27   ` [bug#65257] [PATCH v2 1/1] " Christina O'Donnell
  0 siblings, 1 reply; 4+ messages in thread
From: Christina O'Donnell @ 2024-04-21 21:27 UTC (permalink / raw)
  To: arjan; +Cc: 65257, Christina O'Donnell

Hi,

Thanks for the patch. Sorry it's taken so long to get to you.

This looks good. I updated it to 2.1.0, which required a small change to get
it to work with polkit enabled. Otherweise the patch is as-is.

I've tested this against its major dependencies: keepassxc and gnupg and
they're building and working fine with my Yubikey.

I'm happy for this to be committed.

Kind regards,
Christina

Arjan Adriaanse (1):
  gnu: pcsc-lite: Update to 2.1.0.

 gnu/packages/security-token.scm | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)


base-commit: a1d711c92e119f6b5b8e99a620cdba92a4ca3bfb
-- 
2.41.0





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#65257] [PATCH v2 1/1] gnu: pcsc-lite: Update to 2.1.0.
  2024-04-21 21:27 ` [bug#65257] [PATCH v2 0/1] gnu: pcsc-lite: Update to 2.1.0 Christina O'Donnell
@ 2024-04-21 21:27   ` Christina O'Donnell
  2024-05-06 11:54     ` bug#65257: " Nicolas Goaziou via Guix-patches via
  0 siblings, 1 reply; 4+ messages in thread
From: Christina O'Donnell @ 2024-04-21 21:27 UTC (permalink / raw)
  To: arjan; +Cc: 65257, Christina O'Donnell

From: Arjan Adriaanse <arjan@adriaan.se>

* gnu/packages/security-token.scm (pcsc-lite): Update to 2.1.0.

Reviewed-by: Christina O'Donnell <cdo@mutix.org>

Change-Id: I133fd056afb84259cf5cb1f3e9c664ac336e50b9
---
 gnu/packages/security-token.scm | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 00a7f97582d..0da2d94ba6d 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -83,6 +83,7 @@ (define-module (gnu packages security-token)
   #:use-module (gnu packages tex)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages polkit)
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-build)
   #:use-module (gnu packages python-crypto)
@@ -240,24 +241,33 @@ (define-public softhsm
 (define-public pcsc-lite
   (package
     (name "pcsc-lite")
-    (version "1.9.8")
+    (version "2.1.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://pcsclite.apdu.fr/files/"
                                   "pcsc-lite-" version ".tar.bz2"))
               (sha256
                (base32
-                "12923c6l5qzga1xlcxvm0vzbqrxnxq1qgzlrxf2y5gpcaz2q0bah"))))
+                "1aimbddk6jx828xrw1vg2g82i11v55inhr9jqhmixj24qwfbdjl5"))))
     (build-system gnu-build-system)
     (arguments
      `(#:configure-flags '("--enable-usbdropdir=/var/lib/pcsc/drivers"
-                           "--disable-libsystemd")))
+                           "--disable-libsystemd")
+       #:phases ,#~(modify-phases %standard-phases
+                     (add-after 'unpack 'set-policy-dir
+                       (lambda _
+                         (substitute* "configure"
+                           (("polkit_policy_dir=.*")
+                            (string-append "polkit_policy_dir=\""
+                                           #$output "/share/polkit-1/actions\""))))))))
     (native-inputs
      (list flex
            perl                         ;for pod2man
            pkg-config))
     (inputs
-     (list python eudev))
+     (list python
+           eudev
+           polkit))
     (home-page "https://pcsclite.apdu.fr/")
     (synopsis "Middleware to access a smart card using PC/SC")
     (description
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#65257: [PATCH v2 1/1] gnu: pcsc-lite: Update to 2.1.0.
  2024-04-21 21:27   ` [bug#65257] [PATCH v2 1/1] " Christina O'Donnell
@ 2024-05-06 11:54     ` Nicolas Goaziou via Guix-patches via
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou via Guix-patches via @ 2024-05-06 11:54 UTC (permalink / raw)
  To: Christina O'Donnell; +Cc: 65257-done, arjan

Hello,

Christina O'Donnell <cdo@mutix.org> writes:

> From: Arjan Adriaanse <arjan@adriaan.se>
>
> * gnu/packages/security-token.scm (pcsc-lite): Update to 2.1.0.
>
> Reviewed-by: Christina O'Donnell <cdo@mutix.org>

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou






^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-05-06 11:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-12 23:57 [bug#65257] [PATCH] gnu: pcsc-lite: Update to 2.0.0 Arjan Adriaanse
2024-04-21 21:27 ` [bug#65257] [PATCH v2 0/1] gnu: pcsc-lite: Update to 2.1.0 Christina O'Donnell
2024-04-21 21:27   ` [bug#65257] [PATCH v2 1/1] " Christina O'Donnell
2024-05-06 11:54     ` bug#65257: " Nicolas Goaziou via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).