unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Simon South <simon@simonsouth.net>
To: 51241@debbugs.gnu.org
Subject: [bug#51241] [PATCH 0/1] gnu: ragel: Fix build of knot on aarch64-linux.
Date: Sat, 16 Oct 2021 13:04:19 -0400	[thread overview]
Message-ID: <cover.1634402642.git.simon@simonsouth.net> (raw)

This change fixes the build of Knot on AArch64 by patching Ragel to be
explicit in its use of signed "char" types and ranges rather than assuming
"char" is signed by default on all platforms, as it is not on aarch64-linux.

Presently Knot's test suite is failing on aarch64-linux due to the
src/libknot/ypbody.c file being improperly recreated in the package's
"update-parser" phase.  From Knot's runtests.log:

    ok 139 - set input string
    # wanted: 0
    #   seen: -999
    not ok 140 - parse key with a value in UTF-8
    not ok 141 - compare UTF-8 value
    1..141
    # Looks like you failed 2 tests of 141

With the patch applied, ypbody.c is generated as expected (including now the
explicit use of "signed char" where intended) and the tests pass.

I've tested these changes on AArch64 and x86-64.  On the latter I've
sucessfully re-built the output of "guix refresh --list-dependent ragel" with
the exception of ccextractor, which fails (even without this patch) for an
unrelated reason.  (On AArch64 this rebuild would be an unreasonably large
task, though the immediate dependents all build fine.)

--
Simon South
simon@simonsouth.net


Simon South (1):
  gnu: ragel: Fix build of knot on aarch64-linux.

 gnu/local.mk                                  |  1 +
 .../ragel-specify-char-signedness.patch       | 58 +++++++++++++++++++
 gnu/packages/ragel.scm                        |  4 +-
 3 files changed, 62 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/ragel-specify-char-signedness.patch


base-commit: 34b0aa16e77bdbb5b847267eb0f825a590e3d101
-- 
2.33.0





             reply	other threads:[~2021-10-16 17:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-16 17:04 Simon South [this message]
2021-10-16 17:06 ` [bug#51241] [PATCH 1/1] gnu: ragel: Fix build of knot on aarch64-linux Simon South
2021-10-16 17:42 ` [bug#51241] [PATCH 0/1] " Tobias Geerinckx-Rice via Guix-patches via
2021-10-16 20:09   ` Simon South
2021-10-16 21:37     ` Tobias Geerinckx-Rice via Guix-patches via
2021-11-12 20:44 ` [bug#51241] [PATCH v2 " Simon South
2021-11-12 20:44   ` [bug#51241] [PATCH v2 1/1] " Simon South
2021-12-19 22:30     ` [bug#51241] [PATCH 0/1] " Ludovic Courtès
2021-12-20 22:57       ` Simon South
2021-12-21  9:12         ` Ludovic Courtès
2021-12-29 17:46           ` Simon South
2021-12-29 17:46             ` [bug#51241] [PATCH 1/1] " Simon South
2021-12-31 17:29               ` bug#51241: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1634402642.git.simon@simonsouth.net \
    --to=simon@simonsouth.net \
    --cc=51241@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).