From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sH0kOl0Ga2GcrwAAgWs5BA (envelope-from ) for ; Sat, 16 Oct 2021 19:05:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 8OnHNV0Ga2ESVgAAB5/wlQ (envelope-from ) for ; Sat, 16 Oct 2021 17:05:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 929CF106F6 for ; Sat, 16 Oct 2021 19:05:33 +0200 (CEST) Received: from localhost ([::1]:54328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbn7k-0002L1-46 for larch@yhetil.org; Sat, 16 Oct 2021 13:05:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbn7H-0002K2-56 for guix-patches@gnu.org; Sat, 16 Oct 2021 13:05:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59637) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mbn7G-0002cZ-Rz for guix-patches@gnu.org; Sat, 16 Oct 2021 13:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mbn7G-0002Ul-L6 for guix-patches@gnu.org; Sat, 16 Oct 2021 13:05:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51241] [PATCH 0/1] gnu: ragel: Fix build of knot on aarch64-linux. Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Oct 2021 17:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51241 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51241@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16344038999577 (code B ref -1); Sat, 16 Oct 2021 17:05:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 Oct 2021 17:04:59 +0000 Received: from localhost ([127.0.0.1]:42950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbn7D-0002UP-DB for submit@debbugs.gnu.org; Sat, 16 Oct 2021 13:04:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:57688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbn78-0002UE-Cb for submit@debbugs.gnu.org; Sat, 16 Oct 2021 13:04:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbn77-0002HQ-RO for guix-patches@gnu.org; Sat, 16 Oct 2021 13:04:54 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:46220) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbn74-0001V0-Sq for guix-patches@gnu.org; Sat, 16 Oct 2021 13:04:53 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 42A851361 for ; Sat, 16 Oct 2021 17:04:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo02-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo02-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0q4p0ge6Hj3Y for ; Sat, 16 Oct 2021 17:04:47 +0000 (UTC) Received: from localhost.localdomain (unknown [108.162.141.208]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id EA8811350 for ; Sat, 16 Oct 2021 17:04:46 +0000 (UTC) From: Simon South Date: Sat, 16 Oct 2021 13:04:19 -0400 Message-Id: X-Mailer: git-send-email 2.25.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634403933; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=yWpeNrUq0LI508rIOumSbffL6tKcsgU1vYU+MnxyZ4Q=; b=tfqseNHRw/XLssD5rX8RKTdO6Onb5nGa+DabbQaYg7CSsSUW0gC0cIdHYfHVaZZwkS1ax7 wxrHSkVw9ngyBDiO0ni+HPSGB5yuumUKHnFxPDWPc+CG/2fu+nV6JcT//pASUJfj73FbS2 vl/5xVrvKHpspQ4lqdQRL5bpevYybxhoVoHbqnulGO4ZUYCN7jHHRfMA/IH/RZ06F/sUt7 r44k66tIitPW3XvgHJizvdvJAp0+8HYTxlussKVcs2Rnkl9vyuaXRqgtm/qb6Qgn/8p/mD En5vIuvVsT0jaeNKFZ5l7LYhYh3QfbTQ4LGmUJk0feTqxlhACsOtXuu0zrkduA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634403933; a=rsa-sha256; cv=none; b=RE8isOuYKtLoAGvoIazYR21xeJ/GVt6ZFpIDEQUPxiQnJe1oURmwqQr6xdT+rFSGyFBPvw hD9dg6BnSxRC/ucbrqbxrfnx24VoUB4Z7c/QOCl1UOn34Slzcq/GOLEQzkcv//tpLPyJwZ MVjKiEUc481MHM7Awi2Rw8kE3QCL/DS6oyoZgXBeKqLzECHWcVyGj2Tx2ES0K1H7iDSdV3 fWOBz2BspLM67f5XW1SJxDEee1nJFYEK36HiUrAzRiX92fmJLtWCRsTx231smOEBuI7Qs2 pVOb8Dler4ERYrZcl8Bojkm+M7IE6reODcnv9y2AW2YFlNbXiV+P8fAA5s/Xsw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 2.58 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 929CF106F6 X-Spam-Score: 2.58 X-Migadu-Scanner: scn0.migadu.com X-TUID: bME/gBVASOnc This change fixes the build of Knot on AArch64 by patching Ragel to be explicit in its use of signed "char" types and ranges rather than assuming "char" is signed by default on all platforms, as it is not on aarch64-linux. Presently Knot's test suite is failing on aarch64-linux due to the src/libknot/ypbody.c file being improperly recreated in the package's "update-parser" phase. From Knot's runtests.log: ok 139 - set input string # wanted: 0 # seen: -999 not ok 140 - parse key with a value in UTF-8 not ok 141 - compare UTF-8 value 1..141 # Looks like you failed 2 tests of 141 With the patch applied, ypbody.c is generated as expected (including now the explicit use of "signed char" where intended) and the tests pass. I've tested these changes on AArch64 and x86-64. On the latter I've sucessfully re-built the output of "guix refresh --list-dependent ragel" with the exception of ccextractor, which fails (even without this patch) for an unrelated reason. (On AArch64 this rebuild would be an unreasonably large task, though the immediate dependents all build fine.) -- Simon South simon@simonsouth.net Simon South (1): gnu: ragel: Fix build of knot on aarch64-linux. gnu/local.mk | 1 + .../ragel-specify-char-signedness.patch | 58 +++++++++++++++++++ gnu/packages/ragel.scm | 4 +- 3 files changed, 62 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/ragel-specify-char-signedness.patch base-commit: 34b0aa16e77bdbb5b847267eb0f825a590e3d101 -- 2.33.0