From: Maxime Devos <maximedevos@telenet.be>
To: Nicolas Graves <ngraves@ngraves.fr>
Cc: 53995@debbugs.gnu.org
Subject: [bug#53995] [PATCH 31/31] gnu: update rbw to 1.4.3.
Date: Tue, 15 Mar 2022 17:25:32 +0100 [thread overview]
Message-ID: <cf9bfdac32b3822900c5feceb9820984a29718c3.camel@telenet.be> (raw)
In-Reply-To: <87bky78htb.fsf@ngraves.fr>
[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]
Nicolas Graves schreef op di 15-03-2022 om 14:26 [+0100]:
> > Wouldn't this be a problem of the 'rust-rsa' package? I would move
> > this version relaxing to the 'rust-rsa' package, such that all
> > dependents of rust-rsa can benefit.
>
> I don't think that necessarily applies to every package dependent on
> rust-rsa, I would rather keep it this way.
Some remarks:
* while cargo-build-system creates a "guix-vendor" directory,
this seems an implementation detail to me, maybe one day it will
switch to a {CROSS_,}LIBRARY_PATH system like gcc uses.
* IIUC it does necessarily apply to every package dependent on
rust-rsa, at least those using #:cargo-inputs
/ #:cargo-development-inputs.
Empirically: I searched for "rust-rsa" in the source code of Guix.
Its only user 'rbw' apparently copies the 'substitute*'.
Theoretically: suppose a package rust-foo depends on rust-rsa (and
for simplicity, assume that rust-rsa is its only dependency), via
#:cargo-inputs / #:cargo-development-inputs.
Then currently, rust-rsa builds because of its 'relax-requirements'
phase, but IIUC, this is forgotten when 'rust-foo' is being built,
because 'expand-crate-sources' in (guix build-system cargo) just
looks at the 'source' field of 'rust-rsa' and not the build result,
so the build of rust-foo would fail (unverified).
* even if it's not necessary for all dependents, but only for, say,
20%, it seems more convenient to me to only have to do the
substitute* in a single location (i.e., rust-rsa). An additional
benefit is that, if the version requirements change at some point
in the future, then the 'substitute*' only has to be adjusted in a
single place.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-03-15 16:26 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 13:14 [bug#53995] [PATCH] gnu: rbw: Update to 1.4.3 Nicolas Graves via Guix-patches via
2022-02-14 19:23 ` Maxime Devos
2022-02-15 7:50 ` Nicolas Graves via Guix-patches via
2022-02-15 8:45 ` Maxime Devos
2022-02-16 1:25 ` Nicolas Graves via Guix-patches via
2022-02-16 1:08 ` [bug#53995] [PATCH 01/31] gnu: update rust-anyhow to 1.0.53 Nicolas Graves via Guix-patches via
2022-02-16 7:56 ` Maxime Devos
2022-02-16 8:08 ` Nicolas Graves via Guix-patches via
2022-02-16 11:08 ` Maxime Devos
2022-02-16 1:12 ` [bug#53995] [PATCH 02/31] gnu: update rust-arrayvec to 0.7.2 Nicolas Graves via Guix-patches via
2022-06-18 20:30 ` Maxime Devos
2022-02-16 1:13 ` [bug#53995] [PATCH 03/31] gnu: update rust-async-trait to 0.1.52 Nicolas Graves via Guix-patches via
2022-02-16 11:14 ` Maxime Devos
2022-02-16 1:14 ` [bug#53995] [PATCH 04/31] gnu: update rust-block-padding to 0.2.1 Nicolas Graves via Guix-patches via
2022-02-16 1:15 ` [bug#53995] [PATCH 05/31] gnu: update rust-h2 to 0.3.11 Nicolas Graves via Guix-patches via
2022-02-16 1:18 ` [bug#53995] [PATCH 06/31] gnu: update rust-libc to 0.2.117 Nicolas Graves via Guix-patches via
2022-02-16 1:20 ` [bug#53995] [PATCH 07/31] gnu: update rust-redox-syscall to 0.2.10 Nicolas Graves via Guix-patches via
2022-02-16 1:20 ` [bug#53995] [PATCH 08/31] gnu: update rust-serde-derive to 1.0.136 Nicolas Graves via Guix-patches via
2022-02-16 1:21 ` [bug#53995] [PATCH 09/31] gnu: update rust-cookie-store to 0.15 Nicolas Graves via Guix-patches via
2022-02-16 1:21 ` [bug#53995] [PATCH 10/31] gnu: update rust-hyper-rustls-0.23 Nicolas Graves via Guix-patches via
2022-02-16 1:21 ` [bug#53995] [PATCH 11/31] gnu: update rust-native-tls-0.2 to 0.2.8 Nicolas Graves via Guix-patches via
2022-02-16 1:21 ` [bug#53995] [PATCH 12/31] gnu: update rust-reqwest-0.11 to 0.11.9 Nicolas Graves via Guix-patches via
2022-02-16 1:21 ` [bug#53995] [PATCH 13/31] gnu: update rust-serde-1 to 1.0.136 Nicolas Graves via Guix-patches via
2022-02-16 1:21 ` [bug#53995] [PATCH 14/31] gnu: update rust-serde-json to 1.0.79 Nicolas Graves via Guix-patches via
2022-02-16 1:21 ` [bug#53995] [PATCH 15/31] gnu: update rust-serde-path-to-error-0.1 to 0.1.7 Nicolas Graves via Guix-patches via
2022-02-16 1:21 ` [bug#53995] [PATCH 16/31] gnu: update rust-serde-repr-0.1 " Nicolas Graves via Guix-patches via
2022-02-16 1:21 ` [bug#53995] [PATCH 17/31] gnu: update rust-sha-1-0.9 to 0.9.8 Nicolas Graves via Guix-patches via
2022-02-16 1:21 ` [bug#53995] [PATCH 18/31] gnu: update rust-sha2-0.9 to 0.9.9 Nicolas Graves via Guix-patches via
2022-02-16 1:21 ` [bug#53995] [PATCH 19/31] gnu: update rust-structopt-0.3 to 0.3.26 Nicolas Graves via Guix-patches via
2022-02-16 1:22 ` [bug#53995] [PATCH 20/31] gnu: update rust-structopt-derive-0.4 to 0.4.18 Nicolas Graves via Guix-patches via
2022-02-16 1:22 ` [bug#53995] [PATCH 21/31] gnu: update rust-tempfile-3 to 3.3.0 Nicolas Graves via Guix-patches via
2022-02-16 1:22 ` [bug#53995] [PATCH 22/31] gnu: update rust-thiserror-1 to 1.0.30 Nicolas Graves via Guix-patches via
2022-02-16 1:22 ` [bug#53995] [PATCH 23/31] gnu: update rust-thiserror-impl-1 " Nicolas Graves via Guix-patches via
2022-02-16 1:23 ` [bug#53995] [PATCH 24/31] gnu: update rust-tokio-1 to 1.16.1 Nicolas Graves via Guix-patches via
2022-02-16 1:23 ` [bug#53995] [PATCH 25/31] gnu: update rust-tokio-rustls-0.22 to 0.23.2 Nicolas Graves via Guix-patches via
2022-02-16 1:23 ` [bug#53995] [PATCH 26/31] gnu: update rust-tracing-0.1 to 0.1.30 Nicolas Graves via Guix-patches via
2022-02-16 1:23 ` [bug#53995] [PATCH 27/31] gnu: update rust-tracing-attributes-0.1 to 0.1.19 Nicolas Graves via Guix-patches via
2022-02-16 1:23 ` [bug#53995] [PATCH 28/31] gnu: update rust-tracing-core-0.1 to 0.1.22 Nicolas Graves via Guix-patches via
2022-02-16 1:23 ` [bug#53995] [PATCH 29/31] gnu: add rust-valuable-derive-0.1 Nicolas Graves via Guix-patches via
2022-02-16 11:17 ` Maxime Devos
2022-02-16 11:18 ` Maxime Devos
2022-02-16 1:23 ` [bug#53995] [PATCH 30/31] gnu: add rust-valuable-0.1 Nicolas Graves via Guix-patches via
2022-02-16 1:24 ` [bug#53995] [PATCH 31/31] gnu: update rbw to 1.4.3 Nicolas Graves via Guix-patches via
2022-02-16 11:16 ` Maxime Devos
2022-03-15 13:26 ` Nicolas Graves via Guix-patches via
2022-03-15 16:25 ` Maxime Devos [this message]
[not found] ` <878rm21grm.fsf@ngraves.fr>
2022-09-29 13:03 ` bug#53995: " Nicolas Graves via Guix-patches via
2023-05-28 17:52 ` [bug#53995] (no subject) Tyler Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf9bfdac32b3822900c5feceb9820984a29718c3.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=53995@debbugs.gnu.org \
--cc=ngraves@ngraves.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).