From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0LaXHSO+MGLIgwAAgWs5BA (envelope-from ) for ; Tue, 15 Mar 2022 17:26:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id UI3kGiO+MGJsnwAA9RJhRA (envelope-from ) for ; Tue, 15 Mar 2022 17:26:11 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 013552EA60 for ; Tue, 15 Mar 2022 17:26:10 +0100 (CET) Received: from localhost ([::1]:52060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nU9zt-0000iR-L4 for larch@yhetil.org; Tue, 15 Mar 2022 12:26:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU9zl-0000iJ-V6 for guix-patches@gnu.org; Tue, 15 Mar 2022 12:26:01 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55556) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nU9zl-0001Op-M5 for guix-patches@gnu.org; Tue, 15 Mar 2022 12:26:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nU9zl-0003d5-II for guix-patches@gnu.org; Tue, 15 Mar 2022 12:26:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#53995] [PATCH 31/31] gnu: update rbw to 1.4.3. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 15 Mar 2022 16:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53995 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Graves Cc: 53995@debbugs.gnu.org Received: via spool by 53995-submit@debbugs.gnu.org id=B53995.164736154213922 (code B ref 53995); Tue, 15 Mar 2022 16:26:01 +0000 Received: (at 53995) by debbugs.gnu.org; 15 Mar 2022 16:25:42 +0000 Received: from localhost ([127.0.0.1]:49453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nU9zS-0003cU-1X for submit@debbugs.gnu.org; Tue, 15 Mar 2022 12:25:42 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:45528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nU9zP-0003cI-9e for 53995@debbugs.gnu.org; Tue, 15 Mar 2022 12:25:40 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id 6gRd270084UW6Th01gRd8d; Tue, 15 Mar 2022 17:25:37 +0100 Message-ID: From: Maxime Devos Date: Tue, 15 Mar 2022 17:25:32 +0100 In-Reply-To: <87bky78htb.fsf@ngraves.fr> References: <20220216012409.25220-1-ngraves@ngraves.fr> <9b959752e0f2907d9c5a6de6a10aa76fa757f39b.camel@telenet.be> <87bky78htb.fsf@ngraves.fr> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-RQ7YQ64SqdMyADHw6sUO" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647361537; bh=wAn0gQxHmiwrZM5oL3NvfT3GLArxLvUeWZ4oc0FPPJM=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=RwLTpQ70tKdAbmTKzPzgvV6lbbi9eKLWm60JDPjWIHBM+QkgdhYzMsEifw2xOEOHZ 4/xl6o3NsLZuODNvuLmHpclNdw1cDbjKNq9MyO/Vhlz/KVE/OoGLpE2afS9El+fsdY CT7N5oWXTE9wthuZ2kfqlVFvlMaBXbsqS5HrD+Lvqgk24NCvpBpEZRfwEBpTf7ZfhZ KAuw9NUootRC6KgVLBCT+72mhJg46I2nY8+k2VjsrEluVP3AovG8Fd3JOc+tbnbo0/ BRe0F5josb7vhdnGz8gl6Y89PixzON6PDPqOF2rjuVH/LD7Pq433wIsqQ74qjYTbGa 8JYeP+lCLIDuw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647361571; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=wAn0gQxHmiwrZM5oL3NvfT3GLArxLvUeWZ4oc0FPPJM=; b=ZOPMb44SsgNagAkYHXCNFT4DDTFuyol2uQ2BvptNnd0LRVfkO1KDeq+Q2kD7dMiRDdfuX6 a8v8DTBbIod6ma0dSCbrCbSSKF6cyKtIvOJklNckQdmeuY/A5tRfRPx6PR5cd4NM4b4yaY NwIQOAWzh7bdQrQLjL7GS96Vwmo6SwgzMhU29+n9/L7ACioaTKbIubG8Z2d64S++LAjuXT K5uceXM4MALTGr8sXncnhb1d5qw/1M0NxAzFesqnDEXG8P5X0Dd7tlfyB/w1ePnMXQ6laO I3bnGKm/46+SVoWTS7ZCu7qU5zkYvjpyoEp9GsnHFdXDZhHQeIM94cn6wq75eA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647361571; a=rsa-sha256; cv=none; b=gwHfEeZ0DERKeeioEOrvymtmj3mfwyyzeZ0B6wMCKCP6NJIiMA0Hr1wet13MX5qhPB6ikJ pXNIm73U61F6lcmihu3gzTc5HAF/H3EKN0pfUdxoRdIgn+S1k+qKwl0/g6zM6mxQCxcwEG mPmgj9cZs1WsWNrpyThja4gy0qz2mpzfDlH1Y4wpJYFiceb/vwMF8+zadWZwzBiZT4pwo1 Qkw+8Um5TSiKtYKXT+gjNrlpfyyPQrrGrYaUcc3w2nHVnDt5PE0brw26xqKMTE+5A/YB1l 92LqTSFW8din0528Sswlb4jEkVG1+ZRKvXQ44oI3J+XA8FWh/sWGxqMNc+Adhg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=RwLTpQ70; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.23 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=RwLTpQ70; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 013552EA60 X-Spam-Score: 3.23 X-Migadu-Scanner: scn0.migadu.com X-TUID: CkXKP+D6K4Lo --=-RQ7YQ64SqdMyADHw6sUO Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Nicolas Graves schreef op di 15-03-2022 om 14:26 [+0100]: > > Wouldn't this be a problem of the 'rust-rsa' package? I would move > > this version relaxing to the 'rust-rsa' package, such that all > > dependents of rust-rsa can benefit. >=20 > I don't think that necessarily applies to every package dependent on > rust-rsa, I would rather keep it this way. Some remarks: * while cargo-build-system creates a "guix-vendor" directory, this seems an implementation detail to me, maybe one day it will switch to a {CROSS_,}LIBRARY_PATH system like gcc uses. * IIUC it does necessarily apply to every package dependent on rust-rsa, at least those using #:cargo-inputs / #:cargo-development-inputs. Empirically: I searched for "rust-rsa" in the source code of Guix. Its only user 'rbw' apparently copies the 'substitute*'. Theoretically: suppose a package rust-foo depends on rust-rsa (and for simplicity, assume that rust-rsa is its only dependency), via #:cargo-inputs / #:cargo-development-inputs. Then currently, rust-rsa builds because of its 'relax-requirements' phase, but IIUC, this is forgotten when 'rust-foo' is being built, because 'expand-crate-sources' in (guix build-system cargo) just looks at the 'source' field of 'rust-rsa' and not the build result, so the build of rust-foo would fail (unverified). * even if it's not necessary for all dependents, but only for, say, 20%, it seems more convenient to me to only have to do the substitute* in a single location (i.e., rust-rsa). An additional benefit is that, if the version requirements change at some point in the future, then the 'substitute*' only has to be adjusted in a single place. Greetings, Maxime. --=-RQ7YQ64SqdMyADHw6sUO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjC9/BccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qCgAQDvbtwuUayrlbu+01zcgDFMlGkX 9XLjdRYGJdefofznSQEAiHwSTPIfH9XrQkwt7UX8OzX9Crd/QOPEGVXMM9qFdQc= =1WXG -----END PGP SIGNATURE----- --=-RQ7YQ64SqdMyADHw6sUO--