[bug#39039] [PATCH 2/2] gnu: Add zrythm.

[bug#39039] [PATCH 2/2] gnu: Add zrythm.

[Alexandros Theodotou]

[-- Attachment #1.1: Type: text/plain, Size: 57 bytes --]

Hi,

Attaching the patch for Zrythm.

Thanks,
Alex

[-- Attachment #1.2: 0002-gnu-Add-zrythm.patch --]
[-- Type: text/x-patch, Size: 2721 bytes --]

From 008f999d55f995b41de02bdd02de9fb4042653b3 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Wed, 8 Jan 2020 14:31:05 +0000
Subject: [PATCH 2/2] gnu: Add zrythm.

* gnu/packages/music.scm (zrythm): New variable.
---
 gnu/packages/music.scm | 49 +++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 48 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index e607306282..a1f297832f 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -24,7 +24,7 @@
 ;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays@sdf.lonestar.org>
 ;;; Copyright © 2019 raingloom <raingloom@protonmail.com>
 ;;; Copyright © 2019 David Wilson <david@daviwil.com>
-;;; Copyright © 2019 Alexandros Theodotou <alex@zrythm.org>
+;;; Copyright © 2019, 2020 Alexandros Theodotou <alex@zrythm.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5113,3 +5113,50 @@ MIDI drums and comes as two separate drumkits: Black Pearl and Red Zeppelin.")
     (description "Helm is a cross-platform polyphonic synthesizer available standalone
 and as an LV2 plugin.")
     (license license:gpl3+)))
+
+(define-public zrythm
+  (package
+    (name "zrythm")
+    (version "0.7.345")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "https://www.zrythm.org/releases/zrythm-"
+                            version ".tar.xz"))
+        (sha256
+          (base32
+            "1csiwq38a1ckx23lairfpl7qjkz71wsa7a9vsxl3k58f9ybibiil"))))
+   (build-system meson-build-system)
+   (outputs '("out"))
+   (arguments
+    `(#:configure-flags
+      `("-Denable_tests=true" "-Dmanpage=true"
+        "-Dinstall_dseg_font=false" "-Denable_ffmpeg=true")))
+   (inputs
+    `(("alsa-lib" ,alsa-lib)
+      ("jack" ,jack-1)
+      ("font-dseg", font-dseg)
+      ("ffmpeg", ffmpeg)
+      ("fftw", fftw)
+      ("fftwf", fftwf)
+      ("gettext", gettext-minimal)
+      ("glibc", glibc)
+      ("gtk+", gtk+)
+      ("libsamplerate" ,libsamplerate)
+      ("libsndfile" ,libsndfile)
+      ("libyaml" ,libyaml)
+      ("lilv", lilv)
+      ("xdg-utils", xdg-utils)
+      ("rubberband", rubberband)))
+   (native-inputs
+     `(("pkg-config", pkg-config)
+       ("help2man", help2man)
+       ("libaudec" ,libaudec)
+       ("lv2", lv2)
+       ("glib" ,glib "bin"))) ;for 'glib-compile-resources'
+   (synopsis "Digital audio workstation focusing on usability")
+   (description "Zrythm is a digital audio workstation designed to be
+featureful and easy to use.  It offers unlimited automation options, LV2
+plugin support, JACK support and chord assistance.")
+   (home-page "https://www.zrythm.org")
+   (license license:agpl3+)))
-- 
2.24.1


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#39039] [PATCH 2/2] gnu: Add zrythm.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 119 bytes --]

xdg-utils seems to only contain binaries.  Yet, zrythm is not patched to refer
to them.  Are you sure they are used?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#39039] [PATCH 2/2] gnu: Add zrythm.

[Alexandros Theodotou]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

Hi Danny,

It calls xdg-open at runtime using popen(), to open directories in the
user's file browser app. See io_open_directory() in src/utils/io.c.

Thanks,
Alex

On Thu, 2020-01-09 at 23:32 +0100, Danny Milosavljevic wrote:
> xdg-utils seems to only contain binaries.  Yet, zrythm is not patched
> to refer
> to them.  Are you sure they are used?

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#39039: [PATCH 2/2] gnu: Add zrythm.

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

Hi,

Alexandros Theodotou <alex@zrythm.org> skribis:

> From 008f999d55f995b41de02bdd02de9fb4042653b3 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex@zrythm.org>
> Date: Wed, 8 Jan 2020 14:31:05 +0000
> Subject: [PATCH 2/2] gnu: Add zrythm.
>
> * gnu/packages/music.scm (zrythm): New variable.

I’ve applied the patch.

However, note that zrythm doesn’t keep any run-time reference to
‘xdg-utils’:

  guix gc --references \
  /gnu/store/6ahg92sk3akaspbvcd8vawkndjq97rf3-zrythm-0.7.345 |grep xdg-
  # nothing

That means that, at run time, it won’t find ‘xdg-open’ unless the user
explicitly adds it to their profile.  Could you take a look?

Furthermore, I get the usual:

--8<---------------cut here---------------start------------->8---
$ /gnu/store/6ahg92sk3akaspbvcd8vawkndjq97rf3-zrythm-0.7.345/bin/zrythm
[…]
(zrythm:31567): GLib-GIO-ERROR **: 23:13:27.284: Settings schema 'org.zrythm.Zrythm.preferences' is not installed

(zrythm:31567): GLib-GIO-ERROR **: 23:13:27.284: Settings schema 'org.zrythm.Zrythm' is not installed
Spurumo-/romppunkto-komando
--8<---------------cut here---------------end--------------->8---

… hence the attached patch, which I applied.

Thanks!

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 566 bytes --]

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 55c66a8081..e378e9880b 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5152,9 +5152,9 @@ and as an LV2 plugin.")
           (base32
             "1csiwq38a1ckx23lairfpl7qjkz71wsa7a9vsxl3k58f9ybibiil"))))
    (build-system meson-build-system)
-   (outputs '("out"))
    (arguments
-    `(#:configure-flags
+    `(#:glib-or-gtk? #t
+      #:configure-flags
       `("-Denable_tests=true" "-Dmanpage=true"
         "-Dinstall_dseg_font=false" "-Denable_ffmpeg=true")))
    (inputs