unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#39201] [PATCH] gnu: Add r-deconstructsigs.
@ 2020-01-20 12:18 Roel Janssen
  2020-01-20 13:16 ` Ricardo Wurmus
  0 siblings, 1 reply; 4+ messages in thread
From: Roel Janssen @ 2020-01-20 12:18 UTC (permalink / raw)
  To: 39201

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

Dear Guix,

Here's a patch to add r-deconstructsigs.  I added it to the cran module
because that's where it originates from, but it takes a reference
genome from bioconductor.  So I had to use the bioconductor module.  Is
that OK?

Thanks for your hard work and valuable time.

Kind regards,
Roel Janssen


[-- Attachment #2: 0001-gnu-Add-r-deconstructsigs.patch --]
[-- Type: text/x-patch, Size: 2735 bytes --]

From e2a436698e81ce6b70be982a2193e6307606be41 Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Mon, 20 Jan 2020 13:14:52 +0100
Subject: [PATCH] gnu: Add r-deconstructsigs.

* gnu/packages/cran.scm (r-deconstructsigs): New variable.
---
 gnu/packages/cran.scm | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index ff2490bc31..f4ecb9dec7 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -2,7 +2,7 @@
 ;;; Copyright © 2015, 2016, 2017, 2018, 2019, 2020 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2015 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2016, 2017 Ben Woodcroft <donttrustben@gmail.com>
-;;; Copyright © 2016, 2017, 2018 Roel Janssen <roel@gnu.org>
+;;; Copyright © 2016, 2017, 2018, 2020 Roel Janssen <roel@gnu.org>
 ;;; Copyright © 2017, 2018, 2019 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2017 Raoul Bonnal <ilpuccio.febo@gmail.com>
 ;;; Copyright © 2018 Vijayalakshmi Vedantham <vijimay12@gmail.com>
@@ -43,6 +43,7 @@
   #:use-module (guix build-system r)
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bioconductor)
   #:use-module (gnu packages bioinformatics)
   #:use-module (gnu packages c)
   #:use-module (gnu packages compression)
@@ -1911,6 +1912,32 @@ instructed to explore various modifications of the objects (e.g., sorting
 rows, dropping names) to see if the modified versions are identical.")
     (license license:gpl2+)))
 
+(define-public r-deconstructsigs
+  (package
+    (name "r-deconstructsigs")
+    (version "1.8.0")
+    (source (origin
+              (method url-fetch)
+              (uri (cran-uri "deconstructSigs" version))
+              (sha256
+               (base32
+                "014x0nb23jb98666kaav2phkvmkr38pi38jv0dqd4jv7zp0gdf1a"))))
+    (properties
+     `((upstream-name . "deconstructSigs")))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-bsgenome" ,r-bsgenome)
+       ("r-bsgenome-hsapiens-ucsc-hg19" ,r-bsgenome-hsapiens-ucsc-hg19)
+       ("r-genomeinfodb" ,r-genomeinfodb)
+       ("r-reshape2" ,r-reshape2)))
+    (home-page "https://github.com/raerose01/deconstructSigs")
+    (synopsis "Identifies signatures present in a tumor sample")
+    (description "This package takes sample information in the form of the
+fraction of mutations in each of 96 trinucleotide contexts and identifies
+the weighted combination of published signatures that, when summed, most
+closely reconstructs the mutational profile.")
+    (license license:gpl2+)))
+
 (define-public r-dendextend
   (package
     (name "r-dendextend")
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#39201] [PATCH] gnu: Add r-deconstructsigs.
  2020-01-20 12:18 [bug#39201] [PATCH] gnu: Add r-deconstructsigs Roel Janssen
@ 2020-01-20 13:16 ` Ricardo Wurmus
  2020-01-20 19:32   ` Roel Janssen
  0 siblings, 1 reply; 4+ messages in thread
From: Ricardo Wurmus @ 2020-01-20 13:16 UTC (permalink / raw)
  To: roel; +Cc: 39201


Hi Roel,

> Here's a patch to add r-deconstructsigs.  I added it to the cran module
> because that's where it originates from, but it takes a reference
> genome from bioconductor.  So I had to use the bioconductor module.  Is
> that OK?

Please add the package to the bioconductor module instead and add a
comment above to explain why.  (That’s what we’ve done for other
packages like this.)

--
Ricardo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#39201] [PATCH] gnu: Add r-deconstructsigs.
  2020-01-20 13:16 ` Ricardo Wurmus
@ 2020-01-20 19:32   ` Roel Janssen
  2020-01-27 21:31     ` bug#39201: " Ricardo Wurmus
  0 siblings, 1 reply; 4+ messages in thread
From: Roel Janssen @ 2020-01-20 19:32 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: 39201

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

Hi Ricardo!

On Mon, 2020-01-20 at 14:16 +0100, Ricardo Wurmus wrote:
> Hi Roel,
> 
> > Here's a patch to add r-deconstructsigs.  I added it to the cran module
> > because that's where it originates from, but it takes a reference
> > genome from bioconductor.  So I had to use the bioconductor module.  Is
> > that OK?
> 
> Please add the package to the bioconductor module instead and add a
> comment above to explain why.  (That’s what we’ve done for other
> packages like this.)

So I did.  Thanks for pointing this out.
I attached the new patch.

Thanks Ricardo!

Kind regards,
Roel Janssen


[-- Attachment #2: 0001-gnu-Add-r-deconstructsigs.patch --]
[-- Type: text/x-patch, Size: 1946 bytes --]

From 403a80754c3f53c29c4430cc5a537ee781cc9b1e Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Mon, 20 Jan 2020 20:21:09 +0100
Subject: [PATCH] gnu: Add r-deconstructsigs.

* gnu/packages/bioconductor.scm (r-deconstructsigs): New variable.
---
 gnu/packages/bioconductor.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/bioconductor.scm b/gnu/packages/bioconductor.scm
index ef34b99649..d4194e8ec2 100644
--- a/gnu/packages/bioconductor.scm
+++ b/gnu/packages/bioconductor.scm
@@ -694,6 +694,34 @@ annotations.")
      "This is a manifest package for Illumina's EPIC methylation arrays.")
     (license license:artistic2.0)))
 
+;; This is a CRAN package, but it depends on r-bsgenome-hsapiens-ucsc-hg19
+;; from Bioconductor.
+(define-public r-deconstructsigs
+  (package
+    (name "r-deconstructsigs")
+    (version "1.8.0")
+    (source (origin
+              (method url-fetch)
+              (uri (cran-uri "deconstructSigs" version))
+              (sha256
+               (base32
+                "014x0nb23jb98666kaav2phkvmkr38pi38jv0dqd4jv7zp0gdf1a"))))
+    (properties
+     `((upstream-name . "deconstructSigs")))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-bsgenome" ,r-bsgenome)
+       ("r-bsgenome-hsapiens-ucsc-hg19" ,r-bsgenome-hsapiens-ucsc-hg19)
+       ("r-genomeinfodb" ,r-genomeinfodb)
+       ("r-reshape2" ,r-reshape2)))
+    (home-page "https://github.com/raerose01/deconstructSigs")
+    (synopsis "Identifies signatures present in a tumor sample")
+    (description "This package takes sample information in the form of the
+fraction of mutations in each of 96 trinucleotide contexts and identifies
+the weighted combination of published signatures that, when summed, most
+closely reconstructs the mutational profile.")
+    (license license:gpl2+)))
+
 (define-public r-do-db
   (package
     (name "r-do-db")
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#39201: [PATCH] gnu: Add r-deconstructsigs.
  2020-01-20 19:32   ` Roel Janssen
@ 2020-01-27 21:31     ` Ricardo Wurmus
  0 siblings, 0 replies; 4+ messages in thread
From: Ricardo Wurmus @ 2020-01-27 21:31 UTC (permalink / raw)
  To: Roel Janssen; +Cc: 39201-done


Hi Roel,

sorry for the delay.  I pushed this to the master branch with commit
a38bf7c843.

Thanks!

--
Ricardo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-01-27 21:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-20 12:18 [bug#39201] [PATCH] gnu: Add r-deconstructsigs Roel Janssen
2020-01-20 13:16 ` Ricardo Wurmus
2020-01-20 19:32   ` Roel Janssen
2020-01-27 21:31     ` bug#39201: " Ricardo Wurmus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).