unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#36285] [PATCH] gnu: ungoogled-chromium: Install icons.
@ 2019-06-19  4:43 Alex Griffin
  2019-06-20 21:05 ` bug#36285: " Marius Bakke
  0 siblings, 1 reply; 2+ messages in thread
From: Alex Griffin @ 2019-06-19  4:43 UTC (permalink / raw)
  To: 36285

[-- Attachment #1: Type: text/plain, Size: 93 bytes --]

This patch installs the application icons in the ungoogled-chromium package.
-- 
Alex Griffin

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-ungoogled-chromium-Install-icons.patch --]
[-- Type: text/x-patch; name="0001-gnu-ungoogled-chromium-Install-icons.patch", Size: 2473 bytes --]

From 605782cf5da5faa668692ea31834dcfe324a357e Mon Sep 17 00:00:00 2001
From: Alex Griffin <a@ajgrf.com>
Date: Tue, 18 Jun 2019 14:55:30 -0500
Subject: [PATCH] gnu: ungoogled-chromium: Install icons.

* gnu/packages/chromium.scm (ungoogled-chromium)[arguments]: Install icons.
---
 gnu/packages/chromium.scm | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/chromium.scm b/gnu/packages/chromium.scm
index 2127e402d7..3a242220f6 100644
--- a/gnu/packages/chromium.scm
+++ b/gnu/packages/chromium.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2019 Marius Bakke <mbakke@fastmail.com>
+;;; Copyright © 2019 Alex Griffin <a@ajgrf.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -650,12 +651,6 @@ from forcing GEXP-PROMISE."
                            (scandir "." (cut regexp-exec install-regexp <>)))
                  (copy-file "chrome" (string-append lib "/chromium"))
 
-                 ;; TODO: Install icons from "../../chrome/app/themes" into
-                 ;; "out/share/icons/hicolor/$size".
-                 (install-file
-                  "product_logo_48.png"
-                  (string-append out "/share/icons/48x48/chromium.png"))
-
                  (copy-recursively "locales" locales)
                  (copy-recursively "resources" resources)
 
@@ -669,8 +664,18 @@ from forcing GEXP-PROMISE."
                      (,(string-append lib ":" nss "/lib/nss:" mesa "/lib:"
                                       udev "/lib")))
                    ;; Avoid file manager crash.  See <https://bugs.gnu.org/26593>.
-                   `("XDG_DATA_DIRS" ":" prefix (,(string-append gtk+ "/share"))))
-                 #t)))))))
+                   `("XDG_DATA_DIRS" ":" prefix (,(string-append gtk+ "/share")))))
+
+               (with-directory-excursion "chrome/app/theme/chromium"
+                 (for-each
+                  (lambda (size)
+                    (let ((icons (string-append out "/share/icons/hicolor/"
+                                                size "x" size "/apps")))
+                      (mkdir-p icons)
+                      (copy-file (string-append "product_logo_" size ".png")
+                                 (string-append icons "/chromium.png"))))
+                  '("22" "24" "48" "64" "128" "256")))
+               #t))))))
     (native-inputs
      `(("bison" ,bison)
        ("gcc" ,gcc-8)
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#36285: [PATCH] gnu: ungoogled-chromium: Install icons.
  2019-06-19  4:43 [bug#36285] [PATCH] gnu: ungoogled-chromium: Install icons Alex Griffin
@ 2019-06-20 21:05 ` Marius Bakke
  0 siblings, 0 replies; 2+ messages in thread
From: Marius Bakke @ 2019-06-20 21:05 UTC (permalink / raw)
  To: Alex Griffin, 36285-done

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

"Alex Griffin" <a@ajgrf.com> writes:

> This patch installs the application icons in the ungoogled-chromium package.

Pushed in 3df7b15e6c9a11cedba1451f0459c715b8ce3ca1, thank you!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-20 21:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-19  4:43 [bug#36285] [PATCH] gnu: ungoogled-chromium: Install icons Alex Griffin
2019-06-20 21:05 ` bug#36285: " Marius Bakke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).