From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Raghav Gururajan <rg@raghavgururajan.name>, 46536@debbugs.gnu.org
Subject: [bug#46536] Fix build of materialdecoration.
Date: Mon, 15 Feb 2021 18:07:47 +0100 [thread overview]
Message-ID: <c00a08f09fb276c5e64d3697bc33d5b2cb673e79.camel@student.tugraz.at> (raw)
In-Reply-To: <4b5cdf69-da37-dd7a-22f9-c9c7334afa1e@raghavgururajan.name>
Hi Raghav,
> * gnu/packages/cmake.scm (cmake-shared) [git-version]: Update to
> 1.1.0-32.
The git-version field doesn't actually change. You could annotate
[commit] and [revision] separately, but it usually makes sense to just
say "update to <commit hash>".
* gnu/packages/qt.scm (materialdecoration) [git-version]: Update to
> 1.1.0-9.
Same here.
> [arguments]<#:phases>['remove-3rdparty]: New phase.
Should that be a snippet instead?
> <#:phases>['remove-3rdparty]: New phase.
As above.
> [arguments]<#:configure-flags>[-DCMAKE_CXX_FLAGS]: New flag.
That's a bit too much nesting.
"[arguments]<#:configure-flags: Add -DCMAKE_CXX_FLAGS"
is probably a better choice.
Otherwise LGTM.
Regards,
Leo
next prev parent reply other threads:[~2021-02-15 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 16:35 [bug#46536] Fix build of materialdecoration Raghav Gururajan
2021-02-15 17:07 ` Leo Prikler [this message]
2021-02-15 17:41 ` Raghav Gururajan
2021-02-15 18:08 ` bug#46536: " Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c00a08f09fb276c5e64d3697bc33d5b2cb673e79.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=46536@debbugs.gnu.org \
--cc=rg@raghavgururajan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).