From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0NvIOqaqKmD+MQAA0tVLHw (envelope-from ) for ; Mon, 15 Feb 2021 17:08:54 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GByBNqaqKmCXXwAAB5/wlQ (envelope-from ) for ; Mon, 15 Feb 2021 17:08:54 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8882D14244 for ; Mon, 15 Feb 2021 18:08:54 +0100 (CET) Received: from localhost ([::1]:53692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBhMj-0007Hi-F7 for larch@yhetil.org; Mon, 15 Feb 2021 12:08:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBhLv-0006jQ-Gu for guix-patches@gnu.org; Mon, 15 Feb 2021 12:08:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55315) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBhLu-0006vt-J6 for guix-patches@gnu.org; Mon, 15 Feb 2021 12:08:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lBhLu-0005sj-ER for guix-patches@gnu.org; Mon, 15 Feb 2021 12:08:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46536] Fix build of materialdecoration. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Feb 2021 17:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46536 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Raghav Gururajan , 46536@debbugs.gnu.org Received: via spool by 46536-submit@debbugs.gnu.org id=B46536.161340887522581 (code B ref 46536); Mon, 15 Feb 2021 17:08:02 +0000 Received: (at 46536) by debbugs.gnu.org; 15 Feb 2021 17:07:55 +0000 Received: from localhost ([127.0.0.1]:38626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBhLm-0005s9-SK for submit@debbugs.gnu.org; Mon, 15 Feb 2021 12:07:55 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:48928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBhLk-0005ry-CZ for 46536@debbugs.gnu.org; Mon, 15 Feb 2021 12:07:53 -0500 Received: from nijino.local (217-149-164-20.nat.highway.telekom.at [217.149.164.20]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DfVsc3t5Mz3wY2; Mon, 15 Feb 2021 18:07:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1613408868; bh=ZC0fW3lTsja/I7iMDH6QDw0pCTA54iallcenXpeLv7w=; h=Subject:From:To:Date:In-Reply-To:References; b=HFGh8ZXtSq7a1zKGwTNId8MDQ394xxMQTZBixGipZQe0rWd/wLxpNrNsmhXhqrBsk byOiflZC2ANU/G+49H/MbJJKYs4thW1GkBaP4zcxmXiKuLBA/HYERYURLqyOR1joPc uVOp0d6qeYd8lQbKlCNKMe6OXlWXHiNaRgZMjFBw= Message-ID: From: Leo Prikler Date: Mon, 15 Feb 2021 18:07:47 +0100 In-Reply-To: <4b5cdf69-da37-dd7a-22f9-c9c7334afa1e@raghavgururajan.name> References: <4b5cdf69-da37-dd7a-22f9-c9c7334afa1e@raghavgururajan.name> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.26 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=HFGh8ZXt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8882D14244 X-Spam-Score: -1.26 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2t0AzABLMxBF Hi Raghav, > * gnu/packages/cmake.scm (cmake-shared) [git-version]: Update to > 1.1.0-32. The git-version field doesn't actually change. You could annotate [commit] and [revision] separately, but it usually makes sense to just say "update to ". * gnu/packages/qt.scm (materialdecoration) [git-version]: Update to > 1.1.0-9. Same here. > [arguments]<#:phases>['remove-3rdparty]: New phase. Should that be a snippet instead? > <#:phases>['remove-3rdparty]: New phase. As above. > [arguments]<#:configure-flags>[-DCMAKE_CXX_FLAGS]: New flag. That's a bit too much nesting. "[arguments]<#:configure-flags: Add -DCMAKE_CXX_FLAGS" is probably a better choice. Otherwise LGTM. Regards, Leo