unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#55377] [PATCH] gnu: recutils: Make it cross-compilable.
@ 2022-05-11 21:25 Maxime Devos
  2022-05-12  7:07 ` Maxime Devos
  0 siblings, 1 reply; 2+ messages in thread
From: Maxime Devos @ 2022-05-11 21:25 UTC (permalink / raw)
  To: 55377

[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]

TBD:

  * [ ] Commit message
  * [ ] Testing beyond ‘it builds’
  * [ ] Proper usage of "git format-patch"
  * [ ] 'guix style'
  * [ ] "guix refresh --list-dependents" and such

Just sending it now such that it doesn't disappear, intend to make it a
proper patch submission later ...

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 4472677ab3..ffadb1312b 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1569,18 +1569,17 @@ (define-public recutils
                
"14xiln4immfsw8isnvwvq0h23f6z0wilpgsc4qzabnrzb5lsx3nz"))))
     (build-system gnu-build-system)
 
-    (arguments '(#:configure-flags
-                 (list (string-append "--with-bash-headers="
-                                      (assoc-ref %build-inputs
"bash:include")
-                                      "/include/bash"))))
-
+    (arguments
+      (list #:configure-flags
+            #~(list (string-append "--with-bash-headers="
+                                    (search-input-directory %build-
inputs "/include/bash")))))
     (native-inputs `(("bc" ,bc)
-                     ("bash:include" ,bash "include")
                      ("check" ,check-0.14)
                      ("pkg-config" ,pkg-config)))
 
     ;; TODO: Add more optional inputs.
-    (inputs `(("curl" ,curl)
+    (inputs `(("bash:include" ,bash "include")
+              ("curl" ,curl)
               ("libgcrypt" ,libgcrypt)
               ("libuuid" ,util-linux "lib")))
     (synopsis "Manipulate plain text files as databases")


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [bug#55377] [PATCH] gnu: recutils: Make it cross-compilable.
  2022-05-11 21:25 [bug#55377] [PATCH] gnu: recutils: Make it cross-compilable Maxime Devos
@ 2022-05-12  7:07 ` Maxime Devos
  0 siblings, 0 replies; 2+ messages in thread
From: Maxime Devos @ 2022-05-12  7:07 UTC (permalink / raw)
  To: 55377; +Cc: control

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

tags 55377 + moreinfo
thanks

Maxime Devos schreef op wo 11-05-2022 om 23:25 [+0200]:
> TBD:
> 
>   * [ ] Commit message
>   * [ ] Testing beyond ‘it builds’
>   * [ ] Proper usage of "git format-patch"
>   * [ ] 'guix style'
>   * [ ] "guix refresh --list-dependents" and such

Needs a rebase because of
<https://git.savannah.gnu.org/cgit/guix.git/commit/?id=b4c9a3d23b06d9441e96938b45fbf6669685955d>.
Still, a bash:include in native-inputs doesn't seem correct to me even
if it happens to work here -- e.g., what if the include headers are
architecture-dependent?

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-12  7:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-11 21:25 [bug#55377] [PATCH] gnu: recutils: Make it cross-compilable Maxime Devos
2022-05-12  7:07 ` Maxime Devos

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).