* [bug#58620] Update blur my shell
@ 2022-10-19 4:25 Charles via Guix-patches via
2022-10-20 13:01 ` Liliana Marie Prikler
0 siblings, 1 reply; 4+ messages in thread
From: Charles via Guix-patches via @ 2022-10-19 4:25 UTC (permalink / raw)
To: 58620
[-- Attachment #1.1: Type: text/plain, Size: 13 bytes --]
Empty Message
[-- Attachment #1.2: Type: text/html, Size: 24 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-gnome-shell-extensions-Update-blur-my-shell-to-v.patch --]
[-- Type: text/x-patch; name=0001-gnu-gnome-shell-extensions-Update-blur-my-shell-to-v.patch, Size: 3148 bytes --]
From 2fec71f98487e19f49c992a27a55d00ac5821662 Mon Sep 17 00:00:00 2001
From: Charles <charles.b.jackson@protonmail.com>
Date: Tue, 18 Oct 2022 23:04:24 -0500
Subject: [PATCH] gnu: gnome-shell-extensions: Update blur my shell to version
44.
* gnu/packages/gnome-xyz.scm (gnome-shell-extension-blur-my-shell) Update
version and hash. Add a phase to move the contents of the src and resources
directories to project root so they get installed properly.
---
gnu/packages/gnome-xyz.scm | 31 ++++++++++++++++++++++---------
1 file changed, 22 insertions(+), 9 deletions(-)
diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 68166978a1..89bb9c9d7b 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -996,7 +996,7 @@ (define-public gnome-shell-extension-burn-my-windows
(define-public gnome-shell-extension-blur-my-shell
(package
(name "gnome-shell-extension-blur-my-shell")
- (version "29")
+ (version "44")
(source
(origin
(method git-fetch)
@@ -1006,9 +1006,7 @@ (define-public gnome-shell-extension-blur-my-shell
(file-name (git-file-name name version))
(sha256
(base32
- "13x7zgaj3dz7lypdv1bgmpmh0f2w53q567zxmhmqimi1gy5mjrvk"))
- (snippet
- '(begin (delete-file "src/schemas/gschemas.compiled")))))
+ "0h7yfvrrg5r821mzrp42c09jws06mw6v9avvkfykqj8n8qnslmyx"))))
(build-system copy-build-system)
(arguments
`(#:install-plan
@@ -1016,15 +1014,30 @@ (define-public gnome-shell-extension-blur-my-shell
"share/gnome-shell/extensions/"
"blur-my-shell@aunetx")
#:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$" "\\.png$"
- "\\.xml$" "\\.compiled$")))
+ "\\.svg$" "\\.xml$" "\\.compiled$")))
#:phases
(modify-phases %standard-phases
- (add-after 'unpack 'cd-src
- (lambda _ (chdir "src")))
- (add-before 'install 'compile-schemas
+ (add-after 'unpack 'compile-schemas
(lambda _
(with-directory-excursion "schemas"
- (invoke "glib-compile-schemas" ".")))))))
+ (invoke "glib-compile-schemas" "."))))
+ (add-before 'install 'unpack-src
+ (lambda _
+ (use-modules (ice-9 ftw))
+ (define (explode-dir dir)
+ (for-each
+ (lambda (file)
+ (let ((full-file-name
+ (string-append (getcwd) "/" dir "/" file)))
+ (rename-file
+ full-file-name
+ (string-append (getcwd) "/" file))))
+ (filter (lambda (file)
+ (not (or (string=? file ".")
+ (string=? file ".."))))
+ (scandir (string-append (getcwd) "/" dir)))))
+ (explode-dir "src")
+ (explode-dir "resources"))))))
(native-inputs
(list (list glib "bin"))) ; for glib-compile-schemas
(home-page "https://github.com/aunetx/blur-my-shell")
--
2.38.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [bug#58620] Update blur my shell
2022-10-19 4:25 [bug#58620] Update blur my shell Charles via Guix-patches via
@ 2022-10-20 13:01 ` Liliana Marie Prikler
2022-10-22 4:33 ` Charles via Guix-patches via
0 siblings, 1 reply; 4+ messages in thread
From: Liliana Marie Prikler @ 2022-10-20 13:01 UTC (permalink / raw)
To: Charles, 58620
Am Mittwoch, dem 19.10.2022 um 04:25 +0000 schrieb Charles:
> [PATCH] gnu: gnome-shell-extensions: Update blur my shell to version
> 44.
Should be: "gnu: update gnome-shell-extension-blur-my-shell to 44".
>
> * gnu/packages/gnome-xyz.scm (gnome-shell-extension-blur-my-shell)
> Update version and hash. Add a phase to move the contents of the src
> and resources directories to project root so they get installed
> properly.
Break lines between changes and make clear what's changed. Use
indicators such as [#:phases].
> ---
> gnu/packages/gnome-xyz.scm | 31 ++++++++++++++++++++++---------
> 1 file changed, 22 insertions(+), 9 deletions(-)
>
> diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
> index 68166978a1..89bb9c9d7b 100644
> --- a/gnu/packages/gnome-xyz.scm
> +++ b/gnu/packages/gnome-xyz.scm
> @@ -996,7 +996,7 @@ (define-public gnome-shell-extension-burn-my-
> windows
> (define-public gnome-shell-extension-blur-my-shell
> (package
> (name "gnome-shell-extension-blur-my-shell")
> - (version "29")
> + (version "44")
> (source
> (origin
> (method git-fetch)
> @@ -1006,9 +1006,7 @@ (define-public gnome-shell-extension-blur-my-
> shell
> (file-name (git-file-name name version))
> (sha256
> (base32
> - "13x7zgaj3dz7lypdv1bgmpmh0f2w53q567zxmhmqimi1gy5mjrvk"))
> - (snippet
> - '(begin (delete-file "src/schemas/gschemas.compiled")))))
> + "0h7yfvrrg5r821mzrp42c09jws06mw6v9avvkfykqj8n8qnslmyx"))))
Why is the snippet removed?
> (build-system copy-build-system)
> (arguments
> `(#:install-plan
> @@ -1016,15 +1014,30 @@ (define-public gnome-shell-extension-blur-my-
> shell
> "share/gnome-shell/extensions/"
> "blur-my-shell@aunetx")
> #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$"
> "\\.png$"
> - "\\.xml$" "\\.compiled$")))
> + "\\.svg$" "\\.xml$" "\\.compiled$")))
Note the addition of "\\.svg$" in the ChangeLog.
> #:phases
> (modify-phases %standard-phases
> - (add-after 'unpack 'cd-src
> - (lambda _ (chdir "src")))
> - (add-before 'install 'compile-schemas
> + (add-after 'unpack 'compile-schemas
> (lambda _
> (with-directory-excursion "schemas"
> - (invoke "glib-compile-schemas" ".")))))))
> + (invoke "glib-compile-schemas" "."))))
> + (add-before 'install 'unpack-src
> + (lambda _
> + (use-modules (ice-9 ftw))
> + (define (explode-dir dir)
> + (for-each
> + (lambda (file)
> + (let ((full-file-name
> + (string-append (getcwd) "/" dir "/" file)))
> + (rename-file
> + full-file-name
> + (string-append (getcwd) "/" file))))
> + (filter (lambda (file)
> + (not (or (string=? file ".")
> + (string=? file ".."))))
> + (scandir (string-append (getcwd) "/"
> dir)))))
> + (explode-dir "src")
> + (explode-dir "resources"))))))
Adjust #:install-plan instead.
> (native-inputs
> (list (list glib "bin"))) ; for glib-compile-schemas
> (home-page "https://github.com/aunetx/blur-my-shell")
> --
Cheers
^ permalink raw reply [flat|nested] 4+ messages in thread* [bug#58620] Update blur my shell
2022-10-20 13:01 ` Liliana Marie Prikler
@ 2022-10-22 4:33 ` Charles via Guix-patches via
2022-10-22 9:07 ` bug#58620: " Liliana Marie Prikler
0 siblings, 1 reply; 4+ messages in thread
From: Charles via Guix-patches via @ 2022-10-22 4:33 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 58620
[-- Attachment #1: Type: text/plain, Size: 3450 bytes --]
Thank you for the great review, Liliana. Using the install plan makes this so much better. I think I have addressed all your feedback. Updated patch attatched.
------- Original Message -------
On Thursday, October 20th, 2022 at 8:01 AM, Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> wrote:
> Am Mittwoch, dem 19.10.2022 um 04:25 +0000 schrieb Charles:
>
> > [PATCH] gnu: gnome-shell-extensions: Update blur my shell to version
> > 44.
>
> Should be: "gnu: update gnome-shell-extension-blur-my-shell to 44".
>
> > * gnu/packages/gnome-xyz.scm (gnome-shell-extension-blur-my-shell)
> > Update version and hash. Add a phase to move the contents of the src
> > and resources directories to project root so they get installed
> > properly.
>
> Break lines between changes and make clear what's changed. Use
> indicators such as [#:phases].
>
> > ---
> > gnu/packages/gnome-xyz.scm | 31 ++++++++++++++++++++++---------
> > 1 file changed, 22 insertions(+), 9 deletions(-)
> >
> > diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
> > index 68166978a1..89bb9c9d7b 100644
> > --- a/gnu/packages/gnome-xyz.scm
> > +++ b/gnu/packages/gnome-xyz.scm
> > @@ -996,7 +996,7 @@ (define-public gnome-shell-extension-burn-my-
> > windows
> > (define-public gnome-shell-extension-blur-my-shell
> > (package
> > (name "gnome-shell-extension-blur-my-shell")
> > - (version "29")
> > + (version "44")
> > (source
> > (origin
> > (method git-fetch)
> > @@ -1006,9 +1006,7 @@ (define-public gnome-shell-extension-blur-my-
> > shell
> > (file-name (git-file-name name version))
> > (sha256
> > (base32
> > - "13x7zgaj3dz7lypdv1bgmpmh0f2w53q567zxmhmqimi1gy5mjrvk"))
> > - (snippet
> > - '(begin (delete-file "src/schemas/gschemas.compiled")))))
> > + "0h7yfvrrg5r821mzrp42c09jws06mw6v9avvkfykqj8n8qnslmyx"))))
>
> Why is the snippet removed?
>
> > (build-system copy-build-system)
> > (arguments
> > `(#:install-plan
> > @@ -1016,15 +1014,30 @@ (define-public gnome-shell-extension-blur-my-
> > shell
> > "share/gnome-shell/extensions/"
> > "blur-my-shell@aunetx")
> > #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$"
> > "\\.png$"
> > - "\\.xml$" "\\.compiled$")))
> > + "\\.svg$" "\\.xml$" "\\.compiled$")))
>
> Note the addition of "\\.svg$" in the ChangeLog.
>
> > #:phases
> > (modify-phases %standard-phases
> > - (add-after 'unpack 'cd-src
> > - (lambda _ (chdir "src")))
> > - (add-before 'install 'compile-schemas
> > + (add-after 'unpack 'compile-schemas
> > (lambda _
> > (with-directory-excursion "schemas"
> > - (invoke "glib-compile-schemas" ".")))))))
> > + (invoke "glib-compile-schemas" "."))))
> > + (add-before 'install 'unpack-src
> > + (lambda _
> > + (use-modules (ice-9 ftw))
> > + (define (explode-dir dir)
> > + (for-each
> > + (lambda (file)
> > + (let ((full-file-name
> > + (string-append (getcwd) "/" dir "/" file)))
> > + (rename-file
> > + full-file-name
> > + (string-append (getcwd) "/" file))))
> > + (filter (lambda (file)
> > + (not (or (string=? file ".")
> > + (string=? file ".."))))
> > + (scandir (string-append (getcwd) "/"
> > dir)))))
> > + (explode-dir "src")
> > + (explode-dir "resources"))))))
>
> Adjust #:install-plan instead.
>
> > (native-inputs
> > (list (list glib "bin"))) ; for glib-compile-schemas
> > (home-page "https://github.com/aunetx/blur-my-shell")
> > --
>
> Cheers
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Update-gnome-shell-extension-blur-my-shell-to-44.patch --]
[-- Type: text/x-patch; name=0001-gnu-Update-gnome-shell-extension-blur-my-shell-to-44.patch, Size: 3087 bytes --]
From 6181077fa41eac60929533e16716ac857d6f5576 Mon Sep 17 00:00:00 2001
From: Charles <charles.b.jackson@protonmail.com>
Date: Tue, 18 Oct 2022 23:04:24 -0500
Subject: [PATCH] gnu: Update gnome-shell-extension-blur-my-shell to 44.
* gnu/packages/gnome-xyz.scm (gnome-shell-extension-blur-my-shell): Update
version and hash.
Remove snippet to delete compiled schemas because upstream stopped keeping
them in version control.
Install files from the resources and src directories into the root directory in [#:install-plan].
Add identifier glib:bin to satisfy guix lint.
---
gnu/packages/gnome-xyz.scm | 32 +++++++++++++++++---------------
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 68166978a1..fbf110159f 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -996,7 +996,7 @@ (define-public gnome-shell-extension-burn-my-windows
(define-public gnome-shell-extension-blur-my-shell
(package
(name "gnome-shell-extension-blur-my-shell")
- (version "29")
+ (version "44")
(source
(origin
(method git-fetch)
@@ -1006,27 +1006,29 @@ (define-public gnome-shell-extension-blur-my-shell
(file-name (git-file-name name version))
(sha256
(base32
- "13x7zgaj3dz7lypdv1bgmpmh0f2w53q567zxmhmqimi1gy5mjrvk"))
- (snippet
- '(begin (delete-file "src/schemas/gschemas.compiled")))))
+ "0h7yfvrrg5r821mzrp42c09jws06mw6v9avvkfykqj8n8qnslmyx"))))
(build-system copy-build-system)
(arguments
- `(#:install-plan
- '(("." ,(string-append
- "share/gnome-shell/extensions/"
- "blur-my-shell@aunetx")
- #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$" "\\.png$"
- "\\.xml$" "\\.compiled$")))
+ '(#:install-plan
+ (let ((install-location
+ (string-append
+ "share/gnome-shell/extensions/"
+ "blur-my-shell@aunetx")))
+ `(("src/" ,install-location)
+ ("resources/" ,install-location
+ #:include-regexp ("\\.svg$" "\\.ui"))
+ ("." ,install-location
+ #:exclude-regexp ("src/" "resources/")
+ #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$" "\\.png$"
+ "\\.xml$" "\\.compiled$"))))
#:phases
(modify-phases %standard-phases
- (add-after 'unpack 'cd-src
- (lambda _ (chdir "src")))
- (add-before 'install 'compile-schemas
+ (add-after 'unpack 'compile-schemas
(lambda _
(with-directory-excursion "schemas"
(invoke "glib-compile-schemas" ".")))))))
(native-inputs
- (list (list glib "bin"))) ; for glib-compile-schemas
+ (list (list "glib:bin" glib "bin"))) ; for glib-compile-schemas
(home-page "https://github.com/aunetx/blur-my-shell")
(synopsis "Blurs different parts of the GNOME Shell")
(description "Blur My Shell adds a blur look to different parts of the
--
2.38.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* bug#58620: Update blur my shell
2022-10-22 4:33 ` Charles via Guix-patches via
@ 2022-10-22 9:07 ` Liliana Marie Prikler
0 siblings, 0 replies; 4+ messages in thread
From: Liliana Marie Prikler @ 2022-10-22 9:07 UTC (permalink / raw)
To: Charles; +Cc: 58620-done
Am Samstag, dem 22.10.2022 um 04:33 +0000 schrieb Charles:
> Thank you for the great review, Liliana. Using the install plan makes
> this so much better. I think I have addressed all your feedback.
> Updated patch attatched.
Pushed with the following changes:
> + '(#:install-plan
> + (let ((install-location
> + (string-append
> + "share/gnome-shell/extensions/"
> + "blur-my-shell@aunetx")))
> + `(("src/" ,install-location)
> + ("resources/" ,install-location
> + #:include-regexp ("\\.svg$" "\\.ui"))
> + ("." ,install-location
> + #:exclude-regexp ("src/" "resources/")
> + #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$"
> "\\.png$"
> + "\\.xml$" "\\.compiled$"))))
Used a shorter name for install-location for the sake of conciseness.
> - (list (list glib "bin"))) ; for glib-compile-schemas
> + (list (list "glib:bin" glib "bin"))) ; for glib-compile-schemas
Dropped this, because the linter warning is a false positive.
I also rewrote the commit message to fall in line with the others.
Cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-22 9:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-19 4:25 [bug#58620] Update blur my shell Charles via Guix-patches via
2022-10-20 13:01 ` Liliana Marie Prikler
2022-10-22 4:33 ` Charles via Guix-patches via
2022-10-22 9:07 ` bug#58620: " Liliana Marie Prikler
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).