* [bug#51108] [PATCH] import: pypi: Support 'input-changes'.
@ 2021-10-09 10:21 Xinglu Chen
2021-10-15 21:22 ` bug#51108: " Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Xinglu Chen @ 2021-10-09 10:21 UTC (permalink / raw)
To: 51108
* guix/import/pypi.scm (latest-release): Specify the ‘input-changes’ field.
---
guix/import/pypi.scm | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
index b7859c8341..52835cf44d 100644
--- a/guix/import/pypi.scm
+++ b/guix/import/pypi.scm
@@ -532,7 +532,8 @@ (define pypi-package?
(define (latest-release package)
"Return an <upstream-source> for the latest release of PACKAGE."
(let* ((pypi-name (guix-package->pypi-name package))
- (pypi-package (pypi-fetch pypi-name)))
+ (pypi-package (pypi-fetch pypi-name))
+ (name (package-name package)))
(and pypi-package
(guard (c ((missing-source-error? c) #f))
(let* ((info (pypi-project-info pypi-package))
@@ -540,9 +541,12 @@ (define (latest-release package)
(url (distribution-url
(latest-source-release pypi-package))))
(upstream-source
- (package (package-name package))
+ (package name)
(version version)
- (urls (list url))))))))
+ (urls (list url))
+ (input-changes
+ (changed-inputs name
+ (pypi->guix-package pypi-name)))))))))
(define %pypi-updater
(upstream-updater
base-commit: fd8ea9abf5b4ded096b7ccadb5e36fde4bac0867
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#51108: [PATCH] import: pypi: Support 'input-changes'.
2021-10-09 10:21 [bug#51108] [PATCH] import: pypi: Support 'input-changes' Xinglu Chen
@ 2021-10-15 21:22 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2021-10-15 21:22 UTC (permalink / raw)
To: Xinglu Chen; +Cc: 51108-done
Hi,
Xinglu Chen <public@yoctocell.xyz> skribis:
> * guix/import/pypi.scm (latest-release): Specify the ‘input-changes’ field.
[...]
> + (input-changes
> + (changed-inputs name
> + (pypi->guix-package pypi-name)))))))))
This was bogus (it passes the package name of instead of the package
itself). I fixed it and pushed as
50d2900e7621aed7aea99884b6d9b41c389167d9. It works with:
./pre-inst-env guix refresh python-notebook -u
Let me know if anything’s amiss!
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-15 21:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-09 10:21 [bug#51108] [PATCH] import: pypi: Support 'input-changes' Xinglu Chen
2021-10-15 21:22 ` bug#51108: " Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).