* [bug#46433] [PATCH] gnu: gst-plugins-base: Depend on Opus for all systems.
@ 2021-02-11 0:02 Leo Famulari
2021-02-11 9:43 ` Leo Prikler
0 siblings, 1 reply; 3+ messages in thread
From: Leo Famulari @ 2021-02-11 0:02 UTC (permalink / raw)
To: 46433
I tested this by building gst-plugins-base for --system=i686-linux and
also building wine.
* gnu/packages/gstreamer.scm (gst-plugins-base)[inputs]: Include opus
unconditionally.
---
gnu/packages/gstreamer.scm | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index b582585d75..0921e9ac9f 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -553,11 +553,7 @@ This package provides the core library and elements.")
("libXext" ,libxext)
("libxv" ,libxv)
("alsa-lib" ,alsa-lib)
- ;; XXX Don't build with opus on 32-bit systems:
- ;; <https://bugs.gnu.org/32360>
- ,@(if (target-64bit?)
- `(("opus" ,opus))
- '())))
+ ("opus" ,opus)))
(native-inputs
`(("pkg-config" ,pkg-config)
("glib:bin" ,glib "bin")
--
2.30.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [bug#46433] [PATCH] gnu: gst-plugins-base: Depend on Opus for all systems.
2021-02-11 0:02 [bug#46433] [PATCH] gnu: gst-plugins-base: Depend on Opus for all systems Leo Famulari
@ 2021-02-11 9:43 ` Leo Prikler
2021-02-11 19:13 ` Leo Famulari
0 siblings, 1 reply; 3+ messages in thread
From: Leo Prikler @ 2021-02-11 9:43 UTC (permalink / raw)
To: Leo Famulari, 46433
Am Mittwoch, den 10.02.2021, 19:02 -0500 schrieb Leo Famulari:
> I tested this by building gst-plugins-base for --system=i686-linux
> and
> also building wine.
I tried applying this to staging and running `./pre-inst-env guix build
--system=i686-linux gst-plugins-base`, but interestingly it just
substituted from ci.guix.gnu.org. I suppose it's probably fine to push
this to staging, but it's still an interesting result.
Regards,
Leo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [bug#46433] [PATCH] gnu: gst-plugins-base: Depend on Opus for all systems.
2021-02-11 9:43 ` Leo Prikler
@ 2021-02-11 19:13 ` Leo Famulari
0 siblings, 0 replies; 3+ messages in thread
From: Leo Famulari @ 2021-02-11 19:13 UTC (permalink / raw)
To: Leo Prikler; +Cc: 46433
On Thu, Feb 11, 2021 at 10:43:45AM +0100, Leo Prikler wrote:
> I tried applying this to staging and running `./pre-inst-env guix build
> --system=i686-linux gst-plugins-base`, but interestingly it just
> substituted from ci.guix.gnu.org. I suppose it's probably fine to push
> this to staging, but it's still an interesting result.
You got a substitute because I built the package "by hand" on
ci.guix.gnu.org.
Thanks for your review! Pushed to staging as
ea73e829d7d061d9fd8e1f672926363fe8db2a1b
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-11 19:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-11 0:02 [bug#46433] [PATCH] gnu: gst-plugins-base: Depend on Opus for all systems Leo Famulari
2021-02-11 9:43 ` Leo Prikler
2021-02-11 19:13 ` Leo Famulari
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).