[bug#46378] [PATCH] gnu: Add instead.

[Leo Prikler <leo.prikler@student.tugraz.at>]

[-- Attachment #1: Type: text/plain, Size: 1936 bytes --]

Am Montag, den 08.02.2021, 12:15 -0500 schrieb Dmitry Polyakov:
> Leo Prikler writes:
> 
> > the patch now applies with "git apply", but not "git am", which 
> > makes
> > it difficult to sign off.  I can however rewrite the commit on your
> > behalf if that is what you want.
> 
> No, my goal is to send as good patch as possible without any stuff 
> like
> rewriting patch by maintainer. My first patch was submitting with
> copy-pasting patch from output of magit `W c c` to message-buffer,
> but
> format=flowed (as this artcle https://useplaintext.email/ urges) in 
> m4ue
> wrap some lines and therefore inline patch is brocken.
That looks like a decent recommendation for normal email, but is
inadequate for patches.  You might want to disable line wrapping for
patches.

> Second sended by `git send-email --to="46378@debbugs.gnu.org" HEAD^`.
> 
> May be I should turn off format=flowed option? Or send patch as 
> attached
> file? I dunno what way is produce minimal effort by your side, so 
> please
> tell me.
The output of git send-email *should* be compatible with git am. 
However, the mail that you've sent seems to have some of the fields
mixed up.  I'm not sure if send-email has a format=flowed option, but
if it does, you might want to uncheck it.

Don't forget to add --cc=leo.prikler@student.tugraz.at (or more
generally --cc=<reviewer>) to your invocation of `git send-email`, so
that reviewers, that are not subscribed to the ML (like myself) are
also immediately informed.

I'm personally fine with patches as attachment, but others might not
be.  I'll send one of my own commits as formatted by format-patch as an
attachment to this, so that you can cross-check your own git send-email 
setup.  Especially make sure that the header sequence matches up.

> Sorry, I literally have no expirience with email driven changes
> submitting before.
Don't worry too much about it, everyone's a beginner :)

Regards,
Leo

[-- Attachment #2: 0001-gnu-python2-renpy-Update-to-7.4.2.patch --]
[-- Type: text/x-patch, Size: 1937 bytes --]

From 771e1e7521fddc1f36f966c4b418f69c13c1aeea Mon Sep 17 00:00:00 2001
From: Leo Prikler <leo.prikler@student.tugraz.at>
Date: Sun, 7 Feb 2021 20:25:12 +0100
Subject: [PATCH] gnu: python2-renpy: Update to 7.4.2.

* gnu/packages/game-development.scm (python2-renpy): Update to 7.4.2.
[native-inputs]: Add gcc-8.
---
 gnu/packages/game-development.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 1ddd0e531f..92c3da92ab 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -63,6 +63,7 @@
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages fribidi)
   #:use-module (gnu packages dbm)
+  #:use-module (gnu packages gcc)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
@@ -1141,13 +1142,13 @@ developed mainly for Ren'py.")
 (define-public python2-renpy
   (package
     (name "python2-renpy")
-    (version "7.4.0")
+    (version "7.4.2")
     (source
      (origin
        (method url-fetch)
        (uri (string-append "https://www.renpy.org/dl/" version
                            "/renpy-" version "-source.tar.bz2"))
-       (sha256 (base32 "0av3mbh54xh6i3rvf60x5hbsjcfpzgia2j958mhyc5826zjxzfpg"))
+       (sha256 (base32 "1mlrq9q3r36izyskq674qhp8s32iirvvfb4r8z6hi26189aaydsw"))
        (modules '((guix build utils)))
        (patches
         (search-patches
@@ -1224,7 +1225,8 @@ developed mainly for Ren'py.")
      `(("python2-future" ,python2-future)
        ("python2-pygame" ,python2-pygame-sdl2)))
     (native-inputs
-     `(("python2-cython" ,python2-cython)
+     `(("gcc" ,gcc-8) ; for const variables as initializer elements
+       ("python2-cython" ,python2-cython)
        ("xdg-utils" ,xdg-utils)))
     (home-page "https://www.renpy.org/")
     (synopsis "Ren'py python module")
-- 
2.30.0