From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iNoRCeG4IWDueQAA0tVLHw (envelope-from ) for ; Mon, 08 Feb 2021 22:19:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iGDqBOG4IWCUPQAA1q6Kng (envelope-from ) for ; Mon, 08 Feb 2021 22:19:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8B6C29402B1 for ; Mon, 8 Feb 2021 22:19:12 +0000 (UTC) Received: from localhost ([::1]:49682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9EsB-00010K-FF for larch@yhetil.org; Mon, 08 Feb 2021 17:19:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9Aas-0001UO-6P for guix-patches@gnu.org; Mon, 08 Feb 2021 12:45:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40308) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9Aar-0008DN-TC for guix-patches@gnu.org; Mon, 08 Feb 2021 12:45:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9Aar-0005YX-MP for guix-patches@gnu.org; Mon, 08 Feb 2021 12:45:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46378] [PATCH] gnu: Add instead. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 Feb 2021 17:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46378 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dmitry Polyakov Cc: 46378@debbugs.gnu.org Received: via spool by 46378-submit@debbugs.gnu.org id=B46378.161280624821281 (code B ref 46378); Mon, 08 Feb 2021 17:45:01 +0000 Received: (at 46378) by debbugs.gnu.org; 8 Feb 2021 17:44:08 +0000 Received: from localhost ([127.0.0.1]:51854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9Aa0-0005XB-Bv for submit@debbugs.gnu.org; Mon, 08 Feb 2021 12:44:08 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:45427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9AZu-0005Wl-Q2 for 46378@debbugs.gnu.org; Mon, 08 Feb 2021 12:44:06 -0500 Received: from nijino.local (217-149-173-242.nat.highway.telekom.at [217.149.173.242]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DZD0b6zNcz1LBMx; Mon, 8 Feb 2021 18:43:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4DZD0b6zNcz1LBMx DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1612806240; bh=6u2908hkAd5yQxZ+UbslN2YPCgxxPnVfdJaOxe0c8bk=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=ocAyfQGH7PKzxd1jNF6MX3WGbDIiOU1qaOliXv/QypVlKpIxCSvGvBXSVmosfbsfR gm1XTvpHNlWXFn+QNP9Q5Bhl/Ik0BCMic8Jk8SbRUkEZishr7wPfpsmDDrnONXzLXH 7jA4r894GWi8b6vEbdrgS4xfBCgJOFKI9pcOXWDU= Message-ID: From: Leo Prikler Date: Mon, 08 Feb 2021 18:43:59 +0100 In-Reply-To: <87v9b2cwh4.fsf@liltechdude.xyz> References: <20210208141120.9184-1-polyakov@liltechdude.xyz> <6398b29a976e3e804e224268fd58afd26326b35b.camel@student.tugraz.at> <87v9b2cwh4.fsf@liltechdude.xyz> Content-Type: multipart/mixed; boundary="=-VwGnWuxL+8ObPLgA+E0z" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-TUG-Spam-Score: 1.0 X-TUGAntiSpamFlag: ham X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.16 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=ocAyfQGH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8B6C29402B1 X-Spam-Score: -0.16 X-Migadu-Scanner: scn1.migadu.com X-TUID: AhNZcS2c/7C5 --=-VwGnWuxL+8ObPLgA+E0z Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Am Montag, den 08.02.2021, 12:15 -0500 schrieb Dmitry Polyakov: > Leo Prikler writes: > > > the patch now applies with "git apply", but not "git am", which > > makes > > it difficult to sign off. I can however rewrite the commit on your > > behalf if that is what you want. > > No, my goal is to send as good patch as possible without any stuff > like > rewriting patch by maintainer. My first patch was submitting with > copy-pasting patch from output of magit `W c c` to message-buffer, > but > format=flowed (as this artcle https://useplaintext.email/ urges) in > m4ue > wrap some lines and therefore inline patch is brocken. That looks like a decent recommendation for normal email, but is inadequate for patches. You might want to disable line wrapping for patches. > Second sended by `git send-email --to="46378@debbugs.gnu.org" HEAD^`. > > May be I should turn off format=flowed option? Or send patch as > attached > file? I dunno what way is produce minimal effort by your side, so > please > tell me. The output of git send-email *should* be compatible with git am. However, the mail that you've sent seems to have some of the fields mixed up. I'm not sure if send-email has a format=flowed option, but if it does, you might want to uncheck it. Don't forget to add --cc=leo.prikler@student.tugraz.at (or more generally --cc=) to your invocation of `git send-email`, so that reviewers, that are not subscribed to the ML (like myself) are also immediately informed. I'm personally fine with patches as attachment, but others might not be. I'll send one of my own commits as formatted by format-patch as an attachment to this, so that you can cross-check your own git send-email setup. Especially make sure that the header sequence matches up. > Sorry, I literally have no expirience with email driven changes > submitting before. Don't worry too much about it, everyone's a beginner :) Regards, Leo --=-VwGnWuxL+8ObPLgA+E0z Content-Disposition: attachment; filename="0001-gnu-python2-renpy-Update-to-7.4.2.patch" Content-Type: text/x-patch; name="0001-gnu-python2-renpy-Update-to-7.4.2.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA3NzFlMWU3NTIxZmRkYzFmMzZmOTY2YzRiNDE4ZjY5YzEzYzFhZWVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gUHJpa2xlciA8bGVvLnByaWtsZXJAc3R1ZGVudC50dWdy YXouYXQ+CkRhdGU6IFN1biwgNyBGZWIgMjAyMSAyMDoyNToxMiArMDEwMApTdWJqZWN0OiBbUEFU Q0hdIGdudTogcHl0aG9uMi1yZW5weTogVXBkYXRlIHRvIDcuNC4yLgoKKiBnbnUvcGFja2FnZXMv Z2FtZS1kZXZlbG9wbWVudC5zY20gKHB5dGhvbjItcmVucHkpOiBVcGRhdGUgdG8gNy40LjIuCltu YXRpdmUtaW5wdXRzXTogQWRkIGdjYy04LgotLS0KIGdudS9wYWNrYWdlcy9nYW1lLWRldmVsb3Bt ZW50LnNjbSB8IDggKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDMg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2dhbWUtZGV2ZWxvcG1lbnQu c2NtIGIvZ251L3BhY2thZ2VzL2dhbWUtZGV2ZWxvcG1lbnQuc2NtCmluZGV4IDFkZGQwZTUzMWYu LjkyYzNkYTkyYWIgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9nYW1lLWRldmVsb3BtZW50LnNj bQorKysgYi9nbnUvcGFja2FnZXMvZ2FtZS1kZXZlbG9wbWVudC5zY20KQEAgLTYzLDYgKzYzLDcg QEAKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZnJlZWRlc2t0b3ApCiAgICM6dXNlLW1v ZHVsZSAoZ251IHBhY2thZ2VzIGZyaWJpZGkpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2Vz IGRibSkKKyAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZ2NjKQogICAjOnVzZS1tb2R1bGUg KGdudSBwYWNrYWdlcyBnbCkKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZ2xpYikKICAg Izp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZ25vbWUpCkBAIC0xMTQxLDEzICsxMTQyLDEzIEBA IGRldmVsb3BlZCBtYWlubHkgZm9yIFJlbidweS4iKQogKGRlZmluZS1wdWJsaWMgcHl0aG9uMi1y ZW5weQogICAocGFja2FnZQogICAgIChuYW1lICJweXRob24yLXJlbnB5IikKLSAgICAodmVyc2lv biAiNy40LjAiKQorICAgICh2ZXJzaW9uICI3LjQuMiIpCiAgICAgKHNvdXJjZQogICAgICAob3Jp Z2luCiAgICAgICAgKG1ldGhvZCB1cmwtZmV0Y2gpCiAgICAgICAgKHVyaSAoc3RyaW5nLWFwcGVu ZCAiaHR0cHM6Ly93d3cucmVucHkub3JnL2RsLyIgdmVyc2lvbgogICAgICAgICAgICAgICAgICAg ICAgICAgICAgIi9yZW5weS0iIHZlcnNpb24gIi1zb3VyY2UudGFyLmJ6MiIpKQotICAgICAgIChz aGEyNTYgKGJhc2UzMiAiMGF2M21iaDU0eGg2aTNydmY2MHg1aGJzamNmcHpnaWEyajk1OG1oeWM1 ODI2emp4emZwZyIpKQorICAgICAgIChzaGEyNTYgKGJhc2UzMiAiMW1scnE5cTNyMzZpenlza3E2 NzRxaHA4czMyaWlydnZmYjRyOHo2aGkyNjE4OWFheWRzdyIpKQogICAgICAgIChtb2R1bGVzICco KGd1aXggYnVpbGQgdXRpbHMpKSkKICAgICAgICAocGF0Y2hlcwogICAgICAgICAoc2VhcmNoLXBh dGNoZXMKQEAgLTEyMjQsNyArMTIyNSw4IEBAIGRldmVsb3BlZCBtYWlubHkgZm9yIFJlbidweS4i KQogICAgICBgKCgicHl0aG9uMi1mdXR1cmUiICxweXRob24yLWZ1dHVyZSkKICAgICAgICAoInB5 dGhvbjItcHlnYW1lIiAscHl0aG9uMi1weWdhbWUtc2RsMikpKQogICAgIChuYXRpdmUtaW5wdXRz Ci0gICAgIGAoKCJweXRob24yLWN5dGhvbiIgLHB5dGhvbjItY3l0aG9uKQorICAgICBgKCgiZ2Nj IiAsZ2NjLTgpIDsgZm9yIGNvbnN0IHZhcmlhYmxlcyBhcyBpbml0aWFsaXplciBlbGVtZW50cwor ICAgICAgICgicHl0aG9uMi1jeXRob24iICxweXRob24yLWN5dGhvbikKICAgICAgICAoInhkZy11 dGlscyIgLHhkZy11dGlscykpKQogICAgIChob21lLXBhZ2UgImh0dHBzOi8vd3d3LnJlbnB5Lm9y Zy8iKQogICAgIChzeW5vcHNpcyAiUmVuJ3B5IHB5dGhvbiBtb2R1bGUiKQotLSAKMi4zMC4wCgo= --=-VwGnWuxL+8ObPLgA+E0z--