From: Maxime Devos <maximedevos@telenet.be>
To: "Sébastien Lerique" <sl@eauchat.org>, 54595@debbugs.gnu.org
Subject: [bug#54595] [PATCH v2 2/2] gnu: libfido2: Fix cross-compilation.
Date: Sun, 27 Mar 2022 16:09:03 +0200 [thread overview]
Message-ID: <a8df2ce7774466766dd4e50530a273f3ab869bd4.camel@telenet.be> (raw)
In-Reply-To: <20220327130004.533714-2-sl@eauchat.org>
[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]
Sébastien Lerique schreef op zo 27-03-2022 om 22:00 [+0900]:
> + `(#:configure-flags (list ,@(if (%current-target-system)
> + `((string-append
> + "-DPKG_CONFIG_EXECUTABLE="
> + (search-input-file %build-inputs
> + (string-append
> + "/bin/"
> + ,(pkg-config-for-target)))))
> + '()))
'pkg-config-for-target' just returns "pkg-config" when compiling
natively, so the 'if' can be dropped here and the "-
DPKG_CONFIG_EXECUTABLE=..." be made unconditional.
For clarity, I would put the 'list' on a separate line, though for
style reasons that might require removing the quasiquote and turning it
in a 'list': (arguments (list #:phases #~(foo ...) #:configure-flags
#~(bar ... #$(pkg-config-for-target)))).
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
prev parent reply other threads:[~2022-03-27 14:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 12:28 [bug#54595] [PATCH 0/2] Fix cross-compilation for libfido2 Sébastien Lerique
2022-03-27 12:29 ` [bug#54595] [PATCH 1/2] gnu: libfido2: Use new style Sébastien Lerique
2022-03-27 12:29 ` [bug#54595] [PATCH 2/2] gnu: libfido2: Fix cross-compilation Sébastien Lerique
2022-03-27 12:36 ` Maxime Devos
2022-03-27 13:01 ` Sébastien Lerique
2022-03-27 14:04 ` Pierre Langlois
2022-03-27 15:43 ` Maxime Devos
2022-03-27 17:27 ` Pierre Langlois
2022-03-27 18:00 ` Maxime Devos
2022-03-27 22:12 ` Thiago Jung Bauermann via Guix-patches via
2022-03-27 15:44 ` Maxime Devos
2022-03-27 13:00 ` [bug#54595] [PATCH v2 1/2] gnu: libfido2: Use new style Sébastien Lerique
2022-03-27 13:00 ` [bug#54595] [PATCH v2 2/2] gnu: libfido2: Fix cross-compilation Sébastien Lerique
2022-03-27 14:09 ` Maxime Devos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8df2ce7774466766dd4e50530a273f3ab869bd4.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=54595@debbugs.gnu.org \
--cc=sl@eauchat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).