From: Thiago Jung Bauermann via Guix-patches via <guix-patches@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: pierre.langlois@gmx.com, sl@eauchat.org, 54595@debbugs.gnu.org
Subject: [bug#54595] [PATCH 2/2] gnu: libfido2: Fix cross-compilation.
Date: Sun, 27 Mar 2022 19:12:25 -0300 [thread overview]
Message-ID: <87o81r2g05.fsf@kolabnow.com> (raw)
In-Reply-To: <1d2b3dc1ff2195c9e9df86f0943cdaf024cb0234.camel@telenet.be>
Maxime Devos <maximedevos@telenet.be> writes:
> [[PGP Signed Part:Undecided]]
> Pierre Langlois schreef op zo 27-03-2022 om 18:27 [+0100]:
>> Yeah, if we have this pattern often it sounds like a good idea.
>> However, better yet maybe could be to make the cmake build-system
>> handle
>> it automagically. I see `PKG_CONFIG_EXECUTABLE' is part of cmake
>> itself
>> so that might be OK?
>>
>> https://cmake.org/cmake/help/latest/module/FindPkgConfig.html
>
> Seems reasonable to me, though it that probably needs to be on core-
> updates due to many impacted packages, so that's more of a long-term
> thing.
IMHO the most correct way to fix this problem is in CMake itself. If
it's cross-compiling and there's a $TARGET_PREFIX-pkg-config in path,
then it ought to use it automatically.
I'm not volunteering to champion that solution though. :-)
So of course the next best thing is to make Guix's build system do that
for us.
--
Thanks
Thiago
next prev parent reply other threads:[~2022-03-27 22:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 12:28 [bug#54595] [PATCH 0/2] Fix cross-compilation for libfido2 Sébastien Lerique
2022-03-27 12:29 ` [bug#54595] [PATCH 1/2] gnu: libfido2: Use new style Sébastien Lerique
2022-03-27 12:29 ` [bug#54595] [PATCH 2/2] gnu: libfido2: Fix cross-compilation Sébastien Lerique
2022-03-27 12:36 ` Maxime Devos
2022-03-27 13:01 ` Sébastien Lerique
2022-03-27 14:04 ` Pierre Langlois
2022-03-27 15:43 ` Maxime Devos
2022-03-27 17:27 ` Pierre Langlois
2022-03-27 18:00 ` Maxime Devos
2022-03-27 22:12 ` Thiago Jung Bauermann via Guix-patches via [this message]
2022-03-27 15:44 ` Maxime Devos
2022-03-27 13:00 ` [bug#54595] [PATCH v2 1/2] gnu: libfido2: Use new style Sébastien Lerique
2022-03-27 13:00 ` [bug#54595] [PATCH v2 2/2] gnu: libfido2: Fix cross-compilation Sébastien Lerique
2022-03-27 14:09 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o81r2g05.fsf@kolabnow.com \
--to=guix-patches@gnu.org \
--cc=54595@debbugs.gnu.org \
--cc=bauermann@kolabnow.com \
--cc=maximedevos@telenet.be \
--cc=pierre.langlois@gmx.com \
--cc=sl@eauchat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).