* [bug#65410] [PATCH] gnu: prboom-plus: Fix build.
@ 2023-08-20 12:55 iyzsong--- via Guix-patches via
2023-08-20 15:43 ` Liliana Marie Prikler
2023-08-21 10:31 ` [bug#65410] [PATCH v2] " iyzsong--- via Guix-patches via
0 siblings, 2 replies; 5+ messages in thread
From: iyzsong--- via Guix-patches via @ 2023-08-20 12:55 UTC (permalink / raw)
To: 65410
Cc: 宋文武, Liliana Marie Prikler,
宋文武
From: 宋文武 <iyzsong@member.fsf.org>
* gnu/packages/games.scm (prboom-plus)[arguments]<#:phases>:
Set CFLAGS to '-fcommon'.
---
gnu/packages/games.scm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index a5fa19fc20..4563089326 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -2381,6 +2381,9 @@ (define-public prboom-plus
(assoc-ref %outputs "out") "/bin"))
#:phases
(modify-phases %standard-phases
+ (add-before 'configure 'set-CFLAGS
+ (lambda _
+ (setenv "CFLAGS" "-fcommon")))
(add-after 'set-paths 'set-sdl'paths
(lambda* (#:key inputs #:allow-other-keys)
(setenv "CPATH"
base-commit: 95a1a819dffa833bdd7a47f272da7ee4ff3260c8
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#65410] [PATCH] gnu: prboom-plus: Fix build.
2023-08-20 12:55 [bug#65410] [PATCH] gnu: prboom-plus: Fix build iyzsong--- via Guix-patches via
@ 2023-08-20 15:43 ` Liliana Marie Prikler
2023-08-21 10:32 ` 宋文武 via Guix-patches via
2023-08-21 10:31 ` [bug#65410] [PATCH v2] " iyzsong--- via Guix-patches via
1 sibling, 1 reply; 5+ messages in thread
From: Liliana Marie Prikler @ 2023-08-20 15:43 UTC (permalink / raw)
To: iyzsong, 65410; +Cc: 宋文武
Am Sonntag, dem 20.08.2023 um 20:55 +0800 schrieb iyzsong@envs.net:
> From: 宋文武 <iyzsong@member.fsf.org>
>
> * gnu/packages/games.scm (prboom-plus)[arguments]<#:phases>:
> Set CFLAGS to '-fcommon'.
> ---
> gnu/packages/games.scm | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index a5fa19fc20..4563089326 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -2381,6 +2381,9 @@ (define-public prboom-plus
> (assoc-ref %outputs "out")
> "/bin"))
> #:phases
> (modify-phases %standard-phases
> + (add-before 'configure 'set-CFLAGS
> + (lambda _
> + (setenv "CFLAGS" "-fcommon")))
Could this be added via #:configure-flags?
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#65410] [PATCH v2] gnu: prboom-plus: Fix build.
2023-08-20 12:55 [bug#65410] [PATCH] gnu: prboom-plus: Fix build iyzsong--- via Guix-patches via
2023-08-20 15:43 ` Liliana Marie Prikler
@ 2023-08-21 10:31 ` iyzsong--- via Guix-patches via
2023-08-23 10:59 ` bug#65410: [PATCH] " 宋文武 via Guix-patches via
1 sibling, 1 reply; 5+ messages in thread
From: iyzsong--- via Guix-patches via @ 2023-08-21 10:31 UTC (permalink / raw)
To: 65410
Cc: 宋文武, Liliana Marie Prikler,
宋文武
From: 宋文武 <iyzsong@member.fsf.org>
* gnu/packages/games.scm (prboom-plus)[arguments]<#:configure-flags>:
Add "CFLAGS=-fcommon".
---
gnu/packages/games.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index a5fa19fc20..e1b6dbd43b 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -2376,7 +2376,7 @@ (define-public prboom-plus
#t))))
(build-system gnu-build-system)
(arguments
- '(#:configure-flags '("--disable-cpu-opt")
+ '(#:configure-flags '("--disable-cpu-opt" "CFLAGS=-fcommon")
#:make-flags `(,(string-append "gamesdir="
(assoc-ref %outputs "out") "/bin"))
#:phases
base-commit: 3c6b6941a2c76c26ebf0c1bfd7f901a22c19dce1
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#65410] [PATCH] gnu: prboom-plus: Fix build.
2023-08-20 15:43 ` Liliana Marie Prikler
@ 2023-08-21 10:32 ` 宋文武 via Guix-patches via
0 siblings, 0 replies; 5+ messages in thread
From: 宋文武 via Guix-patches via @ 2023-08-21 10:32 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 65410, 宋文武
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Am Sonntag, dem 20.08.2023 um 20:55 +0800 schrieb iyzsong@envs.net:
>> + (lambda _
>> + (setenv "CFLAGS" "-fcommon")))
> Could this be added via #:configure-flags?
Yes, updated patch sent, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#65410: [PATCH] gnu: prboom-plus: Fix build.
2023-08-21 10:31 ` [bug#65410] [PATCH v2] " iyzsong--- via Guix-patches via
@ 2023-08-23 10:59 ` 宋文武 via Guix-patches via
0 siblings, 0 replies; 5+ messages in thread
From: 宋文武 via Guix-patches via @ 2023-08-23 10:59 UTC (permalink / raw)
To: 65410-done; +Cc: 宋文武, Liliana Marie Prikler
Pushed now, closing.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-23 11:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-20 12:55 [bug#65410] [PATCH] gnu: prboom-plus: Fix build iyzsong--- via Guix-patches via
2023-08-20 15:43 ` Liliana Marie Prikler
2023-08-21 10:32 ` 宋文武 via Guix-patches via
2023-08-21 10:31 ` [bug#65410] [PATCH v2] " iyzsong--- via Guix-patches via
2023-08-23 10:59 ` bug#65410: [PATCH] " 宋文武 via Guix-patches via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).