[bug#56840] [PATCH] FeatherPad package

[bug#56840] [PATCH] FeatherPad package

[Pavel Shlyak]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hello!

Here is my patch to add FeatherPad package to guix. I upstream it from PantherX channel, hence 3 copyright lines.
I build it against Qt5 as Qt6 support in FeatherPad is experimental and is not recommended for daily usage yet.

Thank you in advance for your feedback.
Have a nice day!


[-- Attachment #2: 0001-gnu-featherpad-new-package.patch --]
[-- Type: application/octet-stream, Size: 2100 bytes --]

From d70fc5d6c2f81248b37aa7c96e06c3b1f103c889 Mon Sep 17 00:00:00 2001
From: Pavel Shlyak <p.shlyak@pantherx.org>
Date: Sat, 30 Jul 2022 13:57:30 +0300
Subject: [PATCH] gnu: featherpad: new package.

    * gnu/packages/text-editors.scm (featherpad): new package.
---
 gnu/packages/text-editors.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 0c8531cc4d..6715dda95f 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -19,6 +19,9 @@
 ;;; Copyright © 2021 Calum Irwin <calumirwin1@gmail.com>
 ;;; Copyright © 2022 Luis Henrique Gomes Higino <luishenriquegh2701@gmail.com>
 ;;; Copyright © 2022 Foo Chuan Wei <chuanwei.foo@hotmail.com>
+;;; Copyright © 2018 Fakhri Sajadi <f.sajadi@pantherx.org>
+;;; Copyright © 2021 Reza Alizadeh Majd <r.majd@pantherx.org>
+;;; Copyright © 2022 Pavel Shlyak <p.shlyak@pantherx.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -849,6 +852,27 @@ (define-public editorconfig-core-c
 editors.")
     (license license:bsd-2)))
 
+(define-public featherpad
+  (package
+    (name "featherpad")
+    (version "1.3.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/tsujan/FeatherPad")
+                    (commit (string-append "V" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1knxf05lfvpfkj4lxi71kidg2f7nfkgsidb45m86h9mnbqmxzjcg"))))
+    (build-system cmake-build-system)
+    (arguments `(#:tests? #f))
+    (native-inputs (list pkg-config hunspell qtsvg qtx11extras qtbase-5))
+    (home-page "https://github.com/tsujan/FeatherPad")
+    (synopsis "Lightweight Qt5 plain-text editor for Linux")
+    (description "FeatherPad is a lightweight Qt5 plain-text editor for Linux")
+    (license license:gpl3)))
+
 (define-public texmacs
   (package
     (name "texmacs")
-- 
2.32.1 (Apple Git-133)

[bug#56840] [PATCH] FeatherPad package

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 2676 bytes --]


On 30-07-2022 14:31, Pavel Shlyak wrote:
> Hello!
>
> Here is my patch to add FeatherPad package to guix. I upstream it from PantherX channel, hence 3 copyright lines.
> I build it against Qt5 as Qt6 support in FeatherPad is experimental and is not recommended for daily usage yet.
>
> Thank you in advance for your feedback.
> Have a nice day!
>
> +    (synopsis "Lightweight Qt5 plain-text editor for Linux")
> +    (description "FeatherPad is a lightweight Qt5 plain-text editor 
> for Linux")

If it's only for Linux, that needs to be mentioned in the 
'supported-systems'; there is no need to duplicate this information in 
the description and synopsis. Also, according to the README, this is 
incorrect -- e.g., it mentions 'Haiku OS' support; maybe it supports the 
Hurd too. There is also no need to mention implementation details such 
as Qt5 -- if the user is interested in that, they can do "guix show 
featherpad" to see the list of dependencies.

Additionally, descriptions are not the same thing as descriptions, yet 
you are writing essentially the same thing in both, try mentioning what 
FeatherPad can do and its limitations (especially if they are 
limitations compared to other text editors or features not implemented 
by them, to help the user deciding between them). Marketing talk like 
"lightweight" (*) is to be avoided, see (guix)Synopses and Descriptions.

(*) It's super subjective. Is "lightweight" considering memory usage, 
disk usage, CPU usage, ...? I've tested this statement (with disk usage) 
for "nano" and the inputs of FeatherPad, and I find that nano takes 86.7 
MiB in total and FeatherPad's dependencies take 1156.5 MiB in total -- 
13.3 times larger! So in a certain sense, it's not lightweight at all, 
but heavyweight. If you really want to mention it's lightweight, then be 
precise in your exact claim.

 > +    (native-inputs (list pkg-config hunspell qtsvg qtx11extras 
qtbase-5))

Only pkg-config looks like a native-input to me. See (guix)package 
Reference for the difference.

> +    (arguments `(#:tests? #f))

Tests exist for a reason, don't simply disable them -- if there is a 
reason, write down the reason, in a comment. Also, there appears to be 
some preference for (list #:tests? #false) -- ` / , is a complicated 
construct, and if used, you can get things like ,#~.

> +    (license license:gpl3)))

Looking at a random source file (featherpad/fpwin.cpp), this appears to 
be incorrect -- GPL-3.0 and GPL-3.0+ are different.

> https://github.com/tsujan/FeatherPad/blob/master/cmake/Modules/FindHUNSPELL.cmake 
>

Greetings,
Maxime.


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[bug#56840] [PATCH] FeatherPad package

[Tsu Jan]

I don't have any comment on guix but:


 > It's super subjective...


It isn't. Most users judge about "lightweight" pragmatically, based on 
response time (CPU usage), RAM usage, and the amount of features 
compared to similar apps.

The disk usage is relative and depends on the DE -- installing a light 
Qt app under Gnome, a light GTK app under LXQt or a light EFL app under 
both may require lots of packages.


 > Marketing talk like "lightweight"


Who cares about marketing?! It's a valid info, helpful to users. It also 
tells about the direction of development.

[bug#56840] [PATCH] FeatherPad package

[Pavel Shlyak]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

Thank you for your feedback! I have tried to fix the issues you mentioned and I also added translations. I have edited the package description in accordance with your recommendations and I kindly asked app author/maintainer to appear in this thread to comment it.

[-- Attachment #2: 0001-gnu-featherpad-new-package.patch --]
[-- Type: application/octet-stream, Size: 2356 bytes --]

From 6f2038d57b543e9fb1df22dcc75e778f3742660c Mon Sep 17 00:00:00 2001
From: Pavel Shlyak <p.shlyak@pantherx.org>
Date: Sat, 30 Jul 2022 13:57:30 +0300
Subject: [PATCH] gnu: featherpad: new package.

    * gnu/packages/text-editors.scm (featherpad): new package.
---
 gnu/packages/text-editors.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 0c8531cc4d..50ab492c0b 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -19,6 +19,9 @@
 ;;; Copyright © 2021 Calum Irwin <calumirwin1@gmail.com>
 ;;; Copyright © 2022 Luis Henrique Gomes Higino <luishenriquegh2701@gmail.com>
 ;;; Copyright © 2022 Foo Chuan Wei <chuanwei.foo@hotmail.com>
+;;; Copyright © 2018 Fakhri Sajadi <f.sajadi@pantherx.org>
+;;; Copyright © 2021 Reza Alizadeh Majd <r.majd@pantherx.org>
+;;; Copyright © 2022 Pavel Shlyak <p.shlyak@pantherx.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -849,6 +852,32 @@ (define-public editorconfig-core-c
 editors.")
     (license license:bsd-2)))
 
+(define-public featherpad
+  (package
+    (name "featherpad")
+    (version "1.3.0")
+    (home-page "https://github.com/tsujan/FeatherPad")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url home-page)
+                    (commit (string-append "V" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1knxf05lfvpfkj4lxi71kidg2f7nfkgsidb45m86h9mnbqmxzjcg"))))
+    (build-system cmake-build-system)
+    (arguments (list #:tests? #f))           ;no upstream tests
+    (native-inputs (list pkg-config qttools))           ; for lrelease
+    (inputs (list hunspell qtsvg qtx11extras qtbase-5))
+    (synopsis "GUI Plain-text editor")
+    (description "FeatherPad is a GUI plain-text editor.
+It is independent of any desktop environment and has
+syntax highlighting, session management, side-pane mode, auto-saving,
+spell checking, drag and drop support, instant highlighting
+and automatic detection of text encoding..")
+    (license license:gpl3+)))
+
 (define-public texmacs
   (package
     (name "texmacs")
-- 
2.32.1 (Apple Git-133)


[-- Attachment #3: Type: text/plain, Size: 2808 bytes --]



> 30 июля 2022 г., в 16:00, Maxime Devos <maximedevos@telenet.be> написал(а):
> 
> 
> On 30-07-2022 14:31, Pavel Shlyak wrote:
>> Hello!
>> 
>> Here is my patch to add FeatherPad package to guix. I upstream it from PantherX channel, hence 3 copyright lines.
>> I build it against Qt5 as Qt6 support in FeatherPad is experimental and is not recommended for daily usage yet.
>> 
>> Thank you in advance for your feedback.
>> Have a nice day!
>> 
>> +    (synopsis "Lightweight Qt5 plain-text editor for Linux")
>> +    (description "FeatherPad is a lightweight Qt5 plain-text editor for Linux")
> 
> If it's only for Linux, that needs to be mentioned in the 'supported-systems'; there is no need to duplicate this information in the description and synopsis. Also, according to the README, this is incorrect -- e.g., it mentions 'Haiku OS' support; maybe it supports the Hurd too. There is also no need to mention implementation details such as Qt5 -- if the user is interested in that, they can do "guix show featherpad" to see the list of dependencies.
> 
> Additionally, descriptions are not the same thing as descriptions, yet you are writing essentially the same thing in both, try mentioning what FeatherPad can do and its limitations (especially if they are limitations compared to other text editors or features not implemented by them, to help the user deciding between them). Marketing talk like "lightweight" (*) is to be avoided, see (guix)Synopses and Descriptions.
> 
> (*) It's super subjective. Is "lightweight" considering memory usage, disk usage, CPU usage, ...? I've tested this statement (with disk usage) for "nano" and the inputs of FeatherPad, and I find that nano takes 86.7 MiB in total and FeatherPad's dependencies take 1156.5 MiB in total -- 13.3 times larger! So in a certain sense, it's not lightweight at all, but heavyweight. If you really want to mention it's lightweight, then be precise in your exact claim.
> 
> > +    (native-inputs (list pkg-config hunspell qtsvg qtx11extras qtbase-5))
> 
> Only pkg-config looks like a native-input to me. See (guix)package Reference for the difference.
> 
>> +    (arguments `(#:tests? #f))
> 
> Tests exist for a reason, don't simply disable them -- if there is a reason, write down the reason, in a comment. Also, there appears to be some preference for (list #:tests? #false) -- ` / , is a complicated construct, and if used, you can get things like ,#~.
> 
>> +    (license license:gpl3)))
> 
> Looking at a random source file (featherpad/fpwin.cpp), this appears to be incorrect -- GPL-3.0 and GPL-3.0+ are different.
> 
>> https://github.com/tsujan/FeatherPad/blob/master/cmake/Modules/FindHUNSPELL.cmake 
> 
> Greetings,
> Maxime.
> 
> <OpenPGP_0x49E3EE22191725EE.asc>

[bug#56840] [PATCH] FeatherPad package

[Pavel Shlyak]

Also, the app works as I expect it to work and I’m not sure if it is good/required to change build system to qt-build-system (it is now cmake-build-system). On the one hand, docs say it adds extra helpful steps. On the other hand, it works fine here as submitted in the previous patch. What do you think?

[bug#56840] [PATCH] FeatherPad package

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 1066 bytes --]


On 30-07-2022 23:52, Pavel Shlyak wrote:
> Also, the app works as I expect it to work and I’m not sure if it is good/required to change build system to qt-build-system (it is now cmake-build-system). On the one hand, docs say it adds extra helpful steps. On the other hand, it works fine here as submitted in the previous patch. What do you think?
>
Those helpful steps that 'work fine without' are there for a reason, 
from the documentation:

      ‘qt-wrap’
           The phase ‘qt-wrap’ searches for Qt5 plugin paths, QML paths
           and some XDG in the inputs and output.  In case some path is
           found, all programs in the output’s ‘bin/’, ‘sbin/’,
           ‘libexec/’ and ‘lib/libexec/’ directories are wrapped in
           scripts defining the necessary environment variables.

-- quite likely, it won't actually work without -- try "guix shell 
--pure featherpad -- featherpad" (the --pure is important). Does that work?

Greetings,
Maxime


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[bug#56840] [PATCH] FeatherPad package

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 1536 bytes --]

On 30-07-2022 15:52, Tsu Jan wrote:

> > It's super subjective...
>
>
> It isn't. Most users judge about "lightweight" pragmatically, based on 
> response time (CPU usage), RAM usage, and the amount of features 
> compared to similar apps.
>
> The disk usage is relative and depends on the DE -- installing a light 
> Qt app under Gnome, a light GTK app under LXQt or a light EFL app 
> under both may require lots of packages. 

Exactly, it's an 'it depends', whether it's lightweight depends on 
what's important to the user -- e.g., on my previous computer, lots of 
disk was practically irrelevant but RAM and CPU was limited. "It's 
relative" and "it depends" is pretty much a definition of subjectivity; 
everyone's notion of pragmatism is different.

 > Who cares about marketing?!

Guix doesn't, as I wrote previously.

 > It's a valid info,

Theoretically, it could be, but currently just copying the "lightweight" 
descriptor would give undue weight to some projects that just say 
"lightweight" without making any tests on how lightweight it is w.r.t. 
feature set and lack-of-bugs, etc., especially given that many other 
projects are more modest in their claims even if they are are more 
lightweight than much of the rest (e.g.: nano).

As such, words like "lightweight" tend to appear mere marketing to me, 
with some very few exceptions where the claims were actually precise, 
measurable and proven and the writer was honest and upfront on the 
limitations.

Greetings,
Maxime.


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[bug#56840] [PATCH] FeatherPad package

[Pavel Shlyak]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]


> -- quite likely, it won't actually work without -- try "guix shell --pure featherpad -- featherpad" (the --pure is important). Does that work?

It works fine on my machine. However, I decided to follow guidelines and to use qt-build-system just in case. Here is the patch.

[-- Attachment #2: 0001-gnu-featherpad-new-package.patch --]
[-- Type: application/octet-stream, Size: 2714 bytes --]

From aac4a029a0dfc0489ec5d0c03d7f1b46062d9128 Mon Sep 17 00:00:00 2001
From: Pavel Shlyak <p.shlyak@pantherx.org>
Date: Sat, 30 Jul 2022 13:57:30 +0300
Subject: [PATCH] gnu: featherpad: new package.

    * gnu/packages/text-editors.scm (featherpad): new package.
---
 gnu/packages/text-editors.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 0c8531cc4d..a2a311643f 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -19,6 +19,9 @@
 ;;; Copyright © 2021 Calum Irwin <calumirwin1@gmail.com>
 ;;; Copyright © 2022 Luis Henrique Gomes Higino <luishenriquegh2701@gmail.com>
 ;;; Copyright © 2022 Foo Chuan Wei <chuanwei.foo@hotmail.com>
+;;; Copyright © 2018 Fakhri Sajadi <f.sajadi@pantherx.org>
+;;; Copyright © 2021 Reza Alizadeh Majd <r.majd@pantherx.org>
+;;; Copyright © 2022 Pavel Shlyak <p.shlyak@pantherx.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -46,6 +49,7 @@ (define-module (gnu packages text-editors)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system python)
+  #:use-module (guix build-system qt)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages)
   #:use-module (gnu packages aspell)
@@ -849,6 +853,32 @@ (define-public editorconfig-core-c
 editors.")
     (license license:bsd-2)))
 
+(define-public featherpad
+  (package
+    (name "featherpad")
+    (version "1.3.0")
+    (home-page "https://github.com/tsujan/FeatherPad")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url home-page)
+                    (commit (string-append "V" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1knxf05lfvpfkj4lxi71kidg2f7nfkgsidb45m86h9mnbqmxzjcg"))))
+    (build-system qt-build-system)
+    (arguments (list #:tests? #f))           ;no upstream tests
+    (native-inputs (list pkg-config qttools))           ; for lrelease
+    (inputs (list hunspell qtsvg qtx11extras qtbase-5))
+    (synopsis "GUI Plain-text editor")
+    (description "FeatherPad is a GUI plain-text editor.
+It is independent of any desktop environment and has
+syntax highlighting, session management, side-pane mode, auto-saving,
+spell checking, drag and drop support, instant highlighting
+and automatic detection of text encoding..")
+    (license license:gpl3+)))
+
 (define-public texmacs
   (package
     (name "texmacs")
-- 
2.32.1 (Apple Git-133)

[bug#56840] [PATCH] FeatherPad package

[Pavel Shlyak]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

Hello

The patch is not valid, as qtsvg became qtsvg-5 in 1ef04fb2288dade3ad2883026ae286a68ef13a1e and qttools became qttools-5 in eef8e2ec46c4155980815e00a394428c0c3de075
Here’s the fixed version.
I just hope qtx11extras hasn’t become qtx11extras-5 as I compose this email XD
By the way, I’m glad to see Qt being updated and I’d like to thank everyone who works on it.

Have a nice day!




[-- Attachment #2: 0001-gnu-featherpad-new-package.patch --]
[-- Type: application/octet-stream, Size: 2718 bytes --]

From 6e35c4a8167a785885e9e2c638e2c5779566d702 Mon Sep 17 00:00:00 2001
From: Pavel Shlyak <p.shlyak@pantherx.org>
Date: Sat, 30 Jul 2022 13:57:30 +0300
Subject: [PATCH] gnu: featherpad: new package.

    * gnu/packages/text-editors.scm (featherpad): new package.
---
 gnu/packages/text-editors.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 0c8531cc4d..a3093ef2ca 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -19,6 +19,9 @@
 ;;; Copyright © 2021 Calum Irwin <calumirwin1@gmail.com>
 ;;; Copyright © 2022 Luis Henrique Gomes Higino <luishenriquegh2701@gmail.com>
 ;;; Copyright © 2022 Foo Chuan Wei <chuanwei.foo@hotmail.com>
+;;; Copyright © 2018 Fakhri Sajadi <f.sajadi@pantherx.org>
+;;; Copyright © 2021 Reza Alizadeh Majd <r.majd@pantherx.org>
+;;; Copyright © 2022 Pavel Shlyak <p.shlyak@pantherx.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -46,6 +49,7 @@ (define-module (gnu packages text-editors)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system python)
+  #:use-module (guix build-system qt)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages)
   #:use-module (gnu packages aspell)
@@ -849,6 +853,32 @@ (define-public editorconfig-core-c
 editors.")
     (license license:bsd-2)))
 
+(define-public featherpad
+  (package
+    (name "featherpad")
+    (version "1.3.0")
+    (home-page "https://github.com/tsujan/FeatherPad")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url home-page)
+                    (commit (string-append "V" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1knxf05lfvpfkj4lxi71kidg2f7nfkgsidb45m86h9mnbqmxzjcg"))))
+    (build-system qt-build-system)
+    (arguments (list #:tests? #f))           ;no upstream tests
+    (native-inputs (list pkg-config qttools-5))           ; for lrelease
+    (inputs (list hunspell qtsvg-5 qtx11extras qtbase-5))
+    (synopsis "GUI Plain-text editor")
+    (description "FeatherPad is a GUI plain-text editor.
+It is independent of any desktop environment and has
+syntax highlighting, session management, side-pane mode, auto-saving,
+spell checking, drag and drop support, instant highlighting
+and automatic detection of text encoding..")
+    (license license:gpl3+)))
+
 (define-public texmacs
   (package
     (name "texmacs")
-- 
2.32.1 (Apple Git-133)

[bug#56840] [PATCH] FeatherPad package

[Mathieu Othacehe]

Hello Pavel,

Thanks for the updated version. I was about to push when I noticed that
the 1.3.1 is out there. Could you please update this patch?

Thanks,

Mathieu

[bug#56840] [PATCH] FeatherPad package

[Pavel Shlyak]

Dear Mathieu,

We need to discuss it before I can update the patch. The latest FeatherPad and FeatherNotes require dbus in runtime for single process mode to function. If dbus is not present, the app changes previous behavior and opens a new process/window each time it is called.
So, we can
1. Keep the same inputs. Systems that have dbus will function as they functioned before, others will loose single instance mode.
2. Add dbus to propagated-inputs. This will not ensure dbus is actually running, will it?
3. Do something else
I am not experienced enough to know how to handle this change. 

Check Release Notes for details https://github.com/tsujan/FeatherPad/releases/tag/V1.3.1 

Sincerely,
Pavel

[bug#56840] [PATCH] FeatherPad package

[Pavel Shlyak]

[-- Attachment #1: Type: text/plain, Size: 106 bytes --]

Ok, as there’s no clear answer for the question above, let’s keep it without dbus support for now.


[-- Attachment #2: 0001-gnu-featherpad-new-package.patch --]
[-- Type: application/octet-stream, Size: 2718 bytes --]

From a261808523150f8b6f3643eb87dfb71851c63f12 Mon Sep 17 00:00:00 2001
From: Pavel Shlyak <p.shlyak@pantherx.org>
Date: Sat, 30 Jul 2022 13:57:30 +0300
Subject: [PATCH] gnu: featherpad: new package.

    * gnu/packages/text-editors.scm (featherpad): new package.
---
 gnu/packages/text-editors.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 0c30a705b9..08ad9470aa 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -19,6 +19,9 @@
 ;;; Copyright © 2021 Calum Irwin <calumirwin1@gmail.com>
 ;;; Copyright © 2022 Luis Henrique Gomes Higino <luishenriquegh2701@gmail.com>
 ;;; Copyright © 2022 Foo Chuan Wei <chuanwei.foo@hotmail.com>
+;;; Copyright © 2018 Fakhri Sajadi <f.sajadi@pantherx.org>
+;;; Copyright © 2021 Reza Alizadeh Majd <r.majd@pantherx.org>
+;;; Copyright © 2022 Pavel Shlyak <p.shlyak@pantherx.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -46,6 +49,7 @@ (define-module (gnu packages text-editors)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system python)
+  #:use-module (guix build-system qt)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages)
   #:use-module (gnu packages aspell)
@@ -848,6 +852,32 @@ (define-public editorconfig-core-c
 editors.")
     (license license:bsd-2)))
 
+(define-public featherpad
+  (package
+    (name "featherpad")
+    (version "1.3.2")
+    (home-page "https://github.com/tsujan/FeatherPad")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url home-page)
+                    (commit (string-append "V" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0baqinm8kf4sp0ysifbbn6wc9izwlkslcjdkljkrqin1l8q456z1"))))
+    (build-system qt-build-system)
+    (arguments (list #:tests? #f))           ;no upstream tests
+    (native-inputs (list pkg-config qttools-5))           ; for lrelease
+    (inputs (list hunspell qtsvg-5 qtx11extras qtbase-5))
+    (synopsis "GUI Plain-text editor")
+    (description "FeatherPad is a GUI plain-text editor.
+It is independent of any desktop environment and has
+syntax highlighting, session management, side-pane mode, auto-saving,
+spell checking, drag and drop support, instant highlighting
+and automatic detection of text encoding..")
+    (license license:gpl3+)))
+
 (define-public texmacs
   (package
     (name "texmacs")
-- 
2.37.0 (Apple Git-136)


[-- Attachment #3: Type: text/plain, Size: 290 bytes --]


> 11 авг. 2022 г., в 10:58, Mathieu Othacehe <othacehe@gnu.org> написал(а):
> 
> 
> Hello Pavel,
> 
> Thanks for the updated version. I was about to push when I noticed that
> the 1.3.1 is out there. Could you please update this patch?
> 
> Thanks,
> 
> Mathieu