unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Steve George <steve@futurile.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 69091@debbugs.gnu.org, Andreas Enge <andreas@enge.fr>,
	69119@debbugs.gnu.org
Subject: [bug#69119] [PATCH v2 1/1] gnu: Add clojure.java-time.
Date: Sun, 3 Mar 2024 16:45:10 +0000	[thread overview]
Message-ID: <ZeSpFh+a2XkGWk8c@t25sg> (raw)
In-Reply-To: <87cyscd2w4.fsf_-_@gnu.org>

Hi Ludo,

I got blocked as this patch caused me to look at whether we should be compiling to byte-code by default. I have not been able to achieve consensus so far (and have taken some time off from the thread):

https://lists.gnu.org/archive/html/guix-devel/2024-02/msg00241.html

Having been unable to convince others I also asked the Clojure community:

https://clojureverse.org/t/should-linux-distributions-ship-clojure-byte-compiled-aot-or-not/10595

Their perspective is that:

a. We should not byte-code compile libraries (what Clojure calls AOT), but we could do so for tools/apps.
b. We should not package libraries at all

From both interactions I'm unsure if packaging this (or any other Clojure libs/tools) is the right move. 

Steve

On  2 Mar, Ludovic Courtès wrote:
> Hi Steve,
> 
> Did you have a chance to look into Andreas’ comments about this patch?
> 
>   https://issues.guix.gnu.org/69119
> 
> Ludo’.
> 
> Andreas Enge <andreas@enge.fr> skribis:
> 
> > Hello,
> >
> > according to our naming convention
> >    https://guix.gnu.org/de/manual/devel/en/html_node/Package-Naming.html
> >    https://guix.gnu.org/de/manual/devel/en/html_node/Python-Modules.html
> > I think the package should be called clojure-java-time (well, this is not
> > spelt out precisely, but we could argue by analogy, and by consistency with
> > the existing clojure packages).
> >
> > I know nothing about clojure, but am wondering about two things:
> > - There is one other package with #:aot-exclude '(#:all), which gives
> >   an explanation why the line is there; could you add one here as well?
> > - Would it make sense to package math.combinatorics first to enable the
> >   tests? If we do not test now, I am afraid we will forget it later...
> >
> > Andreas




      reply	other threads:[~2024-03-03 16:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12 22:18 [bug#69091] [PATCH 0/1] Adding clojure.java-time Steve George
2024-02-13  8:44 ` [bug#69091] [PATCH 1/1] gnu: Add clojure.java-time Steve George
2024-02-14  8:57   ` [bug#69119] [PATCH v2 " Steve George
2024-02-16 10:06 ` [bug#69091] Package name Andreas Enge
2024-03-02 16:17   ` [bug#69119] [PATCH v2 1/1] gnu: Add clojure.java-time Ludovic Courtès
2024-03-03 16:45     ` Steve George [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZeSpFh+a2XkGWk8c@t25sg \
    --to=steve@futurile.net \
    --cc=69091@debbugs.gnu.org \
    --cc=69119@debbugs.gnu.org \
    --cc=andreas@enge.fr \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).