unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: Saku Laesvuori <saku@laesvuori.fi>
Cc: 69068@debbugs.gnu.org
Subject: [bug#69068] To test or not to test?
Date: Wed, 28 Feb 2024 13:36:54 +0100	[thread overview]
Message-ID: <Zd8o5lkpMeAxJzfz@jurong> (raw)
In-Reply-To: <rfu3i6umq422ybbmi6h7ggyeqptor3beun3rbnvdxcsmzq22tv@ein4ptojvip7>

Am Wed, Feb 28, 2024 at 01:47:47PM +0200 schrieb Saku Laesvuori:
> I don't believe any of them even compile with Qt6. The test suite has
> been unmaintained for years, so it doesn't really tell anything about
> whether the program works correctly or not.

Sorry for not being more precise:

I am wondering if this part of the patch:
+               ;; The tests are not maintained and some don't even build
+               (add-before 'configure 'disable-broken-tests
+                 (lambda _
+                   (substitute* "kitsasproject.pro"
+                     ((" *(unittest|testit).*") "")
+                     (("\\\\") ""))))

is of interest given that there already is
      (list #:tests? #f               ;XXX: some tests fail and others segfault
            #:test-target "check"

?

Andreas





  reply	other threads:[~2024-02-28 12:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12  7:03 [bug#69068] [PATCH] gnu: kitsas: Update to 5.4.1 Saku Laesvuori via Guix-patches via
2024-02-13 11:30 ` Christopher Baines
2024-02-13 12:17   ` Saku Laesvuori via Guix-patches via
2024-02-28 10:32 ` [bug#69068] To test or not to test? Andreas Enge
2024-02-28 11:47   ` Saku Laesvuori via Guix-patches via
2024-02-28 12:36     ` Andreas Enge [this message]
2024-02-28 12:49       ` Andreas Enge
2024-02-28 15:36         ` bug#69068: " Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zd8o5lkpMeAxJzfz@jurong \
    --to=andreas@enge.fr \
    --cc=69068@debbugs.gnu.org \
    --cc=saku@laesvuori.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).