From: Christopher Baines <mail@cbaines.net>
To: Saku Laesvuori <saku@laesvuori.fi>
Cc: 69068@debbugs.gnu.org
Subject: [bug#69068] [PATCH] gnu: kitsas: Update to 5.4.1
Date: Tue, 13 Feb 2024 11:30:50 +0000 [thread overview]
Message-ID: <87le7obnxl.fsf@cbaines.net> (raw)
In-Reply-To: <e21c3633ace452c4d3eaecb8d843674ce1369b99.1707721437.git.saku@laesvuori.fi>
[-- Attachment #1: Type: text/plain, Size: 2240 bytes --]
Saku Laesvuori via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/finance.scm (kitsas): Update to 5.4.1.
>
> Change-Id: I968579d762ebecef9f9e8b602682587a054c41ad
> ---
> gnu/packages/finance.scm | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
> index 98a220385b..96e2729dda 100644
> --- a/gnu/packages/finance.scm
> +++ b/gnu/packages/finance.scm
> @@ -1307,7 +1307,7 @@ (define-public keepkey-agent
> (define-public kitsas
> (package
> (name "kitsas")
> - (version "4.0.3")
> + (version "5.4.1")
> (source (origin
> (method git-fetch)
> (uri (git-reference
> @@ -1316,17 +1316,24 @@ (define-public kitsas
> (file-name (git-file-name name version))
> (sha256
> (base32
> - "0hrbsqqm6v2pmjq17s7i4akjgclz3d051mg02vcykq80xgxvbkgf"))))
> + "16zkfpl5d9ia202fqg5vrhjqdw0g6wp044ih6n7nz2hbxj9y3m1z"))))
> (build-system qt-build-system)
> - (inputs (list qtbase-5 libzip poppler-qt5 qtsvg-5))
> + (inputs (list libzip qtsvg qtwebengine qt5compat))
> (arguments
> (list #:tests? #f ;XXX: some tests fail and others segfault
> #:test-target "check"
> + #:qtbase qtbase
> #:phases
> #~(modify-phases %standard-phases
> (replace 'configure
> (lambda* _
> (invoke "qmake" "kitsasproject.pro" "CONFIG+=release")))
> + ;; The tests are not maintained and some don't even build
> + (add-before 'configure 'disable-broken-tests
> + (lambda _
> + (substitute* "kitsasproject.pro"
> + ((" *(unittest|testit).*") "")
> + (("\\\\") ""))))
> (replace 'install
> (lambda* _
> (install-file "kitsas/kitsas"
>
> base-commit: f2102cb5b9239be2ed2023b908b726af542e0124
The commit message is missing information on the non-version changes to
the package.
In particular, the removal of qtbase from inputs confuses me, is this
not needed?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2024-02-13 11:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 7:03 [bug#69068] [PATCH] gnu: kitsas: Update to 5.4.1 Saku Laesvuori via Guix-patches via
2024-02-13 11:30 ` Christopher Baines [this message]
2024-02-13 12:17 ` Saku Laesvuori via Guix-patches via
2024-02-28 10:32 ` [bug#69068] To test or not to test? Andreas Enge
2024-02-28 11:47 ` Saku Laesvuori via Guix-patches via
2024-02-28 12:36 ` Andreas Enge
2024-02-28 12:49 ` Andreas Enge
2024-02-28 15:36 ` bug#69068: " Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le7obnxl.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=69068@debbugs.gnu.org \
--cc=saku@laesvuori.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).